linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] acerhdf: remove unneeded semicolon
@ 2022-10-08  7:04 Jiapeng Chong
  2022-10-24 14:06 ` Hans de Goede
  0 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-10-08  7:04 UTC (permalink / raw)
  To: peter
  Cc: hdegoede, markgross, platform-driver-x86, linux-kernel,
	Jiapeng Chong, Abaci Robot

./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/platform/x86/acerhdf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 1956469c3457..6cf7f2a8a074 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
 		pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
 		       fanoff, fanon, fanon);
 		fanoff = fanon;
-	};
+	}
 
 	trips[0].temperature = fanon;
 	trips[0].hysteresis  = fanon - fanoff;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] acerhdf: remove unneeded semicolon
  2022-10-08  7:04 [PATCH] acerhdf: remove unneeded semicolon Jiapeng Chong
@ 2022-10-24 14:06 ` Hans de Goede
  0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2022-10-24 14:06 UTC (permalink / raw)
  To: Jiapeng Chong, peter
  Cc: markgross, platform-driver-x86, linux-kernel, Abaci Robot

Hi,

On 10/8/22 09:04, Jiapeng Chong wrote:
> ./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

This patch does not apply:

[hans@x1 platform-drivers-x86]$ git am -s ~/1.eml
Applying: acerhdf: remove unneeded semicolon
error: patch failed: drivers/platform/x86/acerhdf.c:341
error: drivers/platform/x86/acerhdf.c: patch does not apply
Patch failed at 0001 acerhdf: remove unneeded semicolon
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Please make sure that you base this on the latest version of
the acerhdf code from:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

Regards,

Hans



> ---
>  drivers/platform/x86/acerhdf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 1956469c3457..6cf7f2a8a074 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
>  		pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
>  		       fanoff, fanon, fanon);
>  		fanoff = fanon;
> -	};
> +	}
>  
>  	trips[0].temperature = fanon;
>  	trips[0].hysteresis  = fanon - fanoff;


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] acerhdf: remove unneeded semicolon
  2023-03-09  6:10 Jiapeng Chong
@ 2023-03-16 14:36 ` Hans de Goede
  0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2023-03-16 14:36 UTC (permalink / raw)
  To: Jiapeng Chong, peter
  Cc: markgross, platform-driver-x86, linux-kernel, Abaci Robot

Hi,

On 3/9/23 07:10, Jiapeng Chong wrote:
> ./drivers/platform/x86/acerhdf.c:343:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/acerhdf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index a48638ad2a8a..ec8cc780b822 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
>  		pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
>  		       fanoff, fanon, fanon);
>  		fanoff = fanon;
> -	};
> +	}
>  
>  	trips[0].temperature = fanon;
>  	trips[0].hysteresis  = fanon - fanoff;


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] acerhdf: remove unneeded semicolon
@ 2023-03-09  6:10 Jiapeng Chong
  2023-03-16 14:36 ` Hans de Goede
  0 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2023-03-09  6:10 UTC (permalink / raw)
  To: peter
  Cc: hdegoede, markgross, platform-driver-x86, linux-kernel,
	Jiapeng Chong, Abaci Robot

./drivers/platform/x86/acerhdf.c:343:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/platform/x86/acerhdf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index a48638ad2a8a..ec8cc780b822 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
 		pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
 		       fanoff, fanon, fanon);
 		fanoff = fanon;
-	};
+	}
 
 	trips[0].temperature = fanon;
 	trips[0].hysteresis  = fanon - fanoff;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] acerhdf: remove unneeded semicolon
  2022-09-26  3:33 Jiapeng Chong
@ 2022-09-27 14:19 ` Hans de Goede
  0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2022-09-27 14:19 UTC (permalink / raw)
  To: Jiapeng Chong, peter
  Cc: markgross, platform-driver-x86, linux-kernel, Abaci Robot

Hi,

On 9/26/22 05:33, Jiapeng Chong wrote:
> ./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/platform/x86/acerhdf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index a7407aa032ba..b48c6c5da147 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
>  		pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
>  		       fanoff, fanon, fanon);
>  		fanoff = fanon;
> -	};
> +	}
>  
>  	trips[0].temperature = fanon;
>  	trips[0].hysteresis  = fanon - fanoff;


This patch does not apply on my current for-next branch:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

I guess that this might be based on the thermal-zone changes which are going upstream
for 6.1 through another tree.

Please rebase + resend this once 6.1-rc1 is out.

Regards,

Hans


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] acerhdf: remove unneeded semicolon
@ 2022-09-26  3:33 Jiapeng Chong
  2022-09-27 14:19 ` Hans de Goede
  0 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-26  3:33 UTC (permalink / raw)
  To: peter
  Cc: hdegoede, markgross, platform-driver-x86, linux-kernel,
	Jiapeng Chong, Abaci Robot

./drivers/platform/x86/acerhdf.c:344:2-3: Unneeded semicolon.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2271
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/platform/x86/acerhdf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index a7407aa032ba..b48c6c5da147 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -341,7 +341,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal)
 		pr_err("fanoff temperature (%d) is above fanon temperature (%d), clamping to %d\n",
 		       fanoff, fanon, fanon);
 		fanoff = fanon;
-	};
+	}
 
 	trips[0].temperature = fanon;
 	trips[0].hysteresis  = fanon - fanoff;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-16 14:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-08  7:04 [PATCH] acerhdf: remove unneeded semicolon Jiapeng Chong
2022-10-24 14:06 ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2023-03-09  6:10 Jiapeng Chong
2023-03-16 14:36 ` Hans de Goede
2022-09-26  3:33 Jiapeng Chong
2022-09-27 14:19 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).