* [PATCH] scsi: qedf: Remove set but unused variable 'page'
@ 2022-10-09 6:02 Jiapeng Chong
2022-10-27 2:58 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-10-09 6:02 UTC (permalink / raw)
To: skashyap
Cc: jhasan, GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux,
linux-scsi, linux-kernel, netdev, Jiapeng Chong, Abaci Robot
The variable page is not effectively used in the function, so delete
it.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2348
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/qedf/qedf_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index e045c6e25090..35e16600fc63 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2951,7 +2951,6 @@ static int qedf_alloc_bdq(struct qedf_ctx *qedf)
int i;
struct scsi_bd *pbl;
u64 *list;
- dma_addr_t page;
/* Alloc dma memory for BDQ buffers */
for (i = 0; i < QEDF_BDQ_SIZE; i++) {
@@ -3012,11 +3011,9 @@ static int qedf_alloc_bdq(struct qedf_ctx *qedf)
qedf->bdq_pbl_list_num_entries = qedf->bdq_pbl_mem_size /
QEDF_PAGE_SIZE;
list = (u64 *)qedf->bdq_pbl_list;
- page = qedf->bdq_pbl_list_dma;
for (i = 0; i < qedf->bdq_pbl_list_num_entries; i++) {
*list = qedf->bdq_pbl_dma;
list++;
- page += QEDF_PAGE_SIZE;
}
return 0;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qedf: Remove set but unused variable 'page'
2022-10-09 6:02 [PATCH] scsi: qedf: Remove set but unused variable 'page' Jiapeng Chong
@ 2022-10-27 2:58 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-10-27 2:58 UTC (permalink / raw)
To: skashyap, Jiapeng Chong
Cc: Martin K . Petersen, Abaci Robot, jejb, netdev, jhasan,
linux-scsi, GR-QLogic-Storage-Upstream, linux, linux-kernel
On Sun, 9 Oct 2022 14:02:49 +0800, Jiapeng Chong wrote:
> The variable page is not effectively used in the function, so delete
> it.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: qedf: Remove set but unused variable 'page'
https://git.kernel.org/mkp/scsi/c/e6f8a22ff4a1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-27 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-09 6:02 [PATCH] scsi: qedf: Remove set but unused variable 'page' Jiapeng Chong
2022-10-27 2:58 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).