* [PATCH] drivers: watchdog: exar_wdt.c fix use after free
@ 2022-10-13 9:54 Manank Patel
2022-10-13 13:53 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Manank Patel @ 2022-10-13 9:54 UTC (permalink / raw)
To: linux; +Cc: linux-watchdog, linux-kernel, Manank Patel
fix use after free by storing the result of PTR_ERR(n->pdev)
to a local variable before returning.
Signed-off-by: Manank Patel <pmanank200502@gmail.com>
---
drivers/watchdog/exar_wdt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/exar_wdt.c b/drivers/watchdog/exar_wdt.c
index 35058d8b21bc..7c61ff343271 100644
--- a/drivers/watchdog/exar_wdt.c
+++ b/drivers/watchdog/exar_wdt.c
@@ -355,8 +355,10 @@ static int __init exar_wdt_register(struct wdt_priv *priv, const int idx)
&priv->wdt_res, 1,
priv, sizeof(*priv));
if (IS_ERR(n->pdev)) {
+ int err = PTR_ERR(n->pdev);
+
kfree(n);
- return PTR_ERR(n->pdev);
+ return err;
}
list_add_tail(&n->list, &pdev_list);
--
2.38.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: watchdog: exar_wdt.c fix use after free
2022-10-13 9:54 [PATCH] drivers: watchdog: exar_wdt.c fix use after free Manank Patel
@ 2022-10-13 13:53 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-10-13 13:53 UTC (permalink / raw)
To: Manank Patel; +Cc: linux-watchdog, linux-kernel
On 10/13/22 02:54, Manank Patel wrote:
> fix use after free by storing the result of PTR_ERR(n->pdev)
> to a local variable before returning.
>
> Signed-off-by: Manank Patel <pmanank200502@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/exar_wdt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/exar_wdt.c b/drivers/watchdog/exar_wdt.c
> index 35058d8b21bc..7c61ff343271 100644
> --- a/drivers/watchdog/exar_wdt.c
> +++ b/drivers/watchdog/exar_wdt.c
> @@ -355,8 +355,10 @@ static int __init exar_wdt_register(struct wdt_priv *priv, const int idx)
> &priv->wdt_res, 1,
> priv, sizeof(*priv));
> if (IS_ERR(n->pdev)) {
> + int err = PTR_ERR(n->pdev);
> +
> kfree(n);
> - return PTR_ERR(n->pdev);
> + return err;
> }
>
> list_add_tail(&n->list, &pdev_list);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-13 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 9:54 [PATCH] drivers: watchdog: exar_wdt.c fix use after free Manank Patel
2022-10-13 13:53 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).