* [PATCH] ACPI: x86: Add another system to quirk list for forcing StorageD3Enable
@ 2022-10-14 12:11 Mario Limonciello
2022-10-25 0:13 ` Limonciello, Mario
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2022-10-14 12:11 UTC (permalink / raw)
To: mario.limonciello, linux-kernel
Cc: Dell.Client.Kernel, Julius Brockmann, Rafael J. Wysocki,
Len Brown, linux-acpi
commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
for StorageD3Enable") introduced a quirk to allow a system with ambiguous
use of _ADR 0 to force StorageD3Enable.
Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
Add this other system to the list as well.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
Reported-and-tested-by: Julius Brockmann <mail@juliusbrockmann.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/acpi/x86/utils.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
index f8a2cbdc0ce2b..d7d3f1669d4c0 100644
--- a/drivers/acpi/x86/utils.c
+++ b/drivers/acpi/x86/utils.c
@@ -219,6 +219,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 7425 2-in-1"),
}
},
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
+ }
+ },
{}
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: x86: Add another system to quirk list for forcing StorageD3Enable
2022-10-14 12:11 [PATCH] ACPI: x86: Add another system to quirk list for forcing StorageD3Enable Mario Limonciello
@ 2022-10-25 0:13 ` Limonciello, Mario
2022-10-28 15:33 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Limonciello, Mario @ 2022-10-25 0:13 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Dell.Client.Kernel, Julius Brockmann, Len Brown, linux-acpi,
linux-kernel
On 10/14/2022 07:11, Mario Limonciello wrote:
> commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
> for StorageD3Enable") introduced a quirk to allow a system with ambiguous
> use of _ADR 0 to force StorageD3Enable.
>
> Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
> Add this other system to the list as well.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
> Reported-and-tested-by: Julius Brockmann <mail@juliusbrockmann.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/acpi/x86/utils.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Hi Rafael,
This got sent near the merge window a few weeks ago. It's a trivial fix
so I just want to make sure it didn't get misplaced.
Thanks!
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index f8a2cbdc0ce2b..d7d3f1669d4c0 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -219,6 +219,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 7425 2-in-1"),
> }
> },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
> + }
> + },
> {}
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: x86: Add another system to quirk list for forcing StorageD3Enable
2022-10-25 0:13 ` Limonciello, Mario
@ 2022-10-28 15:33 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-10-28 15:33 UTC (permalink / raw)
To: Limonciello, Mario
Cc: Rafael J. Wysocki, Dell.Client.Kernel, Julius Brockmann,
Len Brown, linux-acpi, linux-kernel
On Tue, Oct 25, 2022 at 2:13 AM Limonciello, Mario
<mario.limonciello@amd.com> wrote:
>
> On 10/14/2022 07:11, Mario Limonciello wrote:
> > commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
> > for StorageD3Enable") introduced a quirk to allow a system with ambiguous
> > use of _ADR 0 to force StorageD3Enable.
> >
> > Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
> > Add this other system to the list as well.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
> > Reported-and-tested-by: Julius Brockmann <mail@juliusbrockmann.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > ---
> > drivers/acpi/x86/utils.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
>
> Hi Rafael,
>
> This got sent near the merge window a few weeks ago. It's a trivial fix
> so I just want to make sure it didn't get misplaced.
I had a plan to push it for -rc3, but then I didn't include it in the PR.
I'll queue it up for -rc4 now.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-28 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14 12:11 [PATCH] ACPI: x86: Add another system to quirk list for forcing StorageD3Enable Mario Limonciello
2022-10-25 0:13 ` Limonciello, Mario
2022-10-28 15:33 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).