* [PATCH] leds-pca955x: Remove the unused function pca95xx_num_led_regs()
@ 2022-10-17 8:10 Jiapeng Chong
2022-10-21 13:08 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-10-17 8:10 UTC (permalink / raw)
To: pavel; +Cc: linux-leds, linux-kernel, Jiapeng Chong, Abaci Robot
The function pca95xx_num_led_regs() is defined in the leds-pca955x.c
file, but not called elsewhere, so delete this unused function.
drivers/leds/leds-pca955x.c:149:19: warning: unused function 'pca95xx_num_led_regs'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2411
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/leds/leds-pca955x.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
index 81aaf21212d7..33ec4543fb4f 100644
--- a/drivers/leds/leds-pca955x.c
+++ b/drivers/leds/leds-pca955x.c
@@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits)
return (bits + 7) / 8;
}
-/* 4 bits per LED selector register */
-static inline int pca95xx_num_led_regs(int bits)
-{
- return (bits + 3) / 4;
-}
-
/*
* Return an LED selector register value based on an existing one, with
* the appropriate 2-bit state value set for the given LED number (0-3).
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds-pca955x: Remove the unused function pca95xx_num_led_regs()
2022-10-17 8:10 [PATCH] leds-pca955x: Remove the unused function pca95xx_num_led_regs() Jiapeng Chong
@ 2022-10-21 13:08 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2022-10-21 13:08 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-leds, linux-kernel, Abaci Robot
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Hi!
> The function pca95xx_num_led_regs() is defined in the leds-pca955x.c
> file, but not called elsewhere, so delete this unused function.
>
> drivers/leds/leds-pca955x.c:149:19: warning: unused function 'pca95xx_num_led_regs'.
Thank you, applied.
Best regards,
Pavel
> +++ b/drivers/leds/leds-pca955x.c
> @@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits)
> return (bits + 7) / 8;
> }
>
> -/* 4 bits per LED selector register */
> -static inline int pca95xx_num_led_regs(int bits)
> -{
> - return (bits + 3) / 4;
> -}
> -
> /*
> * Return an LED selector register value based on an existing one, with
> * the appropriate 2-bit state value set for the given LED number (0-3).
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-21 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 8:10 [PATCH] leds-pca955x: Remove the unused function pca95xx_num_led_regs() Jiapeng Chong
2022-10-21 13:08 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).