* [PATCH] net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict()
@ 2022-10-17 9:35 Jiapeng Chong
2022-10-18 10:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-10-17 9:35 UTC (permalink / raw)
To: davem
Cc: yoshfuji, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel,
Jiapeng Chong, Abaci Robot
The function ip6gre_tnl_addr_conflict() is defined in the ip6_gre.c file,
but not called elsewhere, so delete this unused function.
net/ipv6/ip6_gre.c:887:20: warning: unused function 'ip6gre_tnl_addr_conflict'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2419
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
net/ipv6/ip6_gre.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 48b4ff0294f6..02b1b54165e8 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -870,26 +870,6 @@ static inline int ip6gre_xmit_ipv6(struct sk_buff *skb, struct net_device *dev)
return 0;
}
-/**
- * ip6gre_tnl_addr_conflict - compare packet addresses to tunnel's own
- * @t: the outgoing tunnel device
- * @hdr: IPv6 header from the incoming packet
- *
- * Description:
- * Avoid trivial tunneling loop by checking that tunnel exit-point
- * doesn't match source of incoming packet.
- *
- * Return:
- * 1 if conflict,
- * 0 else
- **/
-
-static inline bool ip6gre_tnl_addr_conflict(const struct ip6_tnl *t,
- const struct ipv6hdr *hdr)
-{
- return ipv6_addr_equal(&t->parms.raddr, &hdr->saddr);
-}
-
static int ip6gre_xmit_other(struct sk_buff *skb, struct net_device *dev)
{
struct ip6_tnl *t = netdev_priv(dev);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict()
2022-10-17 9:35 [PATCH] net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict() Jiapeng Chong
@ 2022-10-18 10:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-18 10:10 UTC (permalink / raw)
To: Jiapeng Chong
Cc: davem, yoshfuji, dsahern, edumazet, kuba, pabeni, netdev,
linux-kernel, abaci
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 17 Oct 2022 17:35:40 +0800 you wrote:
> The function ip6gre_tnl_addr_conflict() is defined in the ip6_gre.c file,
> but not called elsewhere, so delete this unused function.
>
> net/ipv6/ip6_gre.c:887:20: warning: unused function 'ip6gre_tnl_addr_conflict'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2419
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> [...]
Here is the summary with links:
- net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict()
https://git.kernel.org/netdev/net-next/c/f00909e2e6fe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-18 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 9:35 [PATCH] net: ip6_gre: Remove the unused function ip6gre_tnl_addr_conflict() Jiapeng Chong
2022-10-18 10:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).