From: Maxime Ripard <maxime@cerno.tech>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Maxime Ripard <maxime@cerno.tech>,
linux-clk@vger.kernel.org
Subject: [PATCH 3/4] clk: Initialize max_rate in struct clk_rate_request
Date: Tue, 18 Oct 2022 15:52:58 +0200 [thread overview]
Message-ID: <20221018-clk-range-checks-fixes-v1-3-f3ef80518140@cerno.tech> (raw)
In-Reply-To: <20221018-clk-range-checks-fixes-v1-0-f3ef80518140@cerno.tech>
Since commit b46fd8dbe8ad ("clk: Zero the clk_rate_request structure"),
the clk_core_init_rate_req() function clears the struct clk_rate_request
passed as argument.
However, the default value for max_rate isn't 0 but ULONG_MAX, and we
end up creating a clk_rate_request instance where the maximum rate is 0.
Let's initialize max_rate to ULONG_MAX properly.
Fixes: b46fd8dbe8ad ("clk: Zero the clk_rate_request structure")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/clk/clk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index eb2f9be9b9aa..57b83665e5c3 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1463,6 +1463,7 @@ static void clk_core_init_rate_req(struct clk_core * const core,
return;
memset(req, 0, sizeof(*req));
+ req->max_rate = ULONG_MAX;
if (!core)
return;
--
b4 0.11.0-dev-7da52
next prev parent reply other threads:[~2022-10-18 13:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:52 [PATCH 0/4] clk: Rate range improvements Maxime Ripard
2022-10-18 13:52 ` [PATCH 1/4] clk: Remove WARN_ON NULL parent in clk_core_init_rate_req() Maxime Ripard
2022-10-18 14:35 ` AngeloGioacchino Del Regno
2022-10-28 0:06 ` Stephen Boyd
2022-10-18 13:52 ` [PATCH 2/4] clk: Initialize the clk_rate_request even if clk_core is NULL Maxime Ripard
2022-10-18 14:35 ` AngeloGioacchino Del Regno
2022-10-28 0:09 ` Stephen Boyd
2022-10-18 13:52 ` Maxime Ripard [this message]
2022-10-18 14:35 ` [PATCH 3/4] clk: Initialize max_rate in struct clk_rate_request AngeloGioacchino Del Regno
2022-10-28 0:09 ` Stephen Boyd
2022-10-18 13:52 ` [PATCH 4/4] clk: Warn if we register a mux without determine_rate Maxime Ripard
2022-10-18 14:34 ` AngeloGioacchino Del Regno
2022-10-26 2:07 ` Stephen Boyd
2022-10-26 13:52 ` maxime
2022-10-27 21:45 ` Stephen Boyd
2022-11-03 12:39 ` Maxime Ripard
2022-11-03 12:33 ` Maxime Ripard
2022-11-04 18:10 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018-clk-range-checks-fixes-v1-3-f3ef80518140@cerno.tech \
--to=maxime@cerno.tech \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).