From: Maxime Ripard <maxime@cerno.tech>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/4] clk: Warn if we register a mux without determine_rate
Date: Thu, 3 Nov 2022 13:39:30 +0100 [thread overview]
Message-ID: <20221103123930.koc22wtbch56ql4y@houat> (raw)
In-Reply-To: <20221027214509.8EC66C433C1@smtp.kernel.org>
On Thu, Oct 27, 2022 at 02:45:07PM -0700, Stephen Boyd wrote:
> Quoting maxime@cerno.tech (2022-10-26 06:52:15)
> > On Tue, Oct 25, 2022 at 07:07:58PM -0700, Stephen Boyd wrote:
> > > but I'm fairly certain a coccinelle script can detect most of these
> > > because clk_ops are usually statically defined (although not always).
> > >
> > > Either way I already see that 'owl_comp_div_ops' will trigger this
> > > warning. And 'at91sam9x5_smd_ops' looks even more likely. Given that I'm
> > > not super keen on applying this patch.
> >
> > It's the reason why I didn't return an error at first, I wanted to
> > report that it's invalid and let to drivers the chance to be fixed
> > still.
> >
> > Should I take your above comment as you'd rather have the affected
> > drivers fixed in this patch and we then return an error, or is it that
> > you don't want that patch at all?
>
> You can try fixing all the drivers that are failing to meet this
> requirement (found with grep) and if they are fixed we can start
> printing the warning. That seems to be the practical approach to
> getting this patch accepted. The TODO irks me to be honest. I'd rather
> we fix everything and make it an error and be done with it.
ACK. I had a look this morning and there's indeed a good number of
clocks in that case. I'll work on it.
Maxime
next prev parent reply other threads:[~2022-11-03 12:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:52 [PATCH 0/4] clk: Rate range improvements Maxime Ripard
2022-10-18 13:52 ` [PATCH 1/4] clk: Remove WARN_ON NULL parent in clk_core_init_rate_req() Maxime Ripard
2022-10-18 14:35 ` AngeloGioacchino Del Regno
2022-10-28 0:06 ` Stephen Boyd
2022-10-18 13:52 ` [PATCH 2/4] clk: Initialize the clk_rate_request even if clk_core is NULL Maxime Ripard
2022-10-18 14:35 ` AngeloGioacchino Del Regno
2022-10-28 0:09 ` Stephen Boyd
2022-10-18 13:52 ` [PATCH 3/4] clk: Initialize max_rate in struct clk_rate_request Maxime Ripard
2022-10-18 14:35 ` AngeloGioacchino Del Regno
2022-10-28 0:09 ` Stephen Boyd
2022-10-18 13:52 ` [PATCH 4/4] clk: Warn if we register a mux without determine_rate Maxime Ripard
2022-10-18 14:34 ` AngeloGioacchino Del Regno
2022-10-26 2:07 ` Stephen Boyd
2022-10-26 13:52 ` maxime
2022-10-27 21:45 ` Stephen Boyd
2022-11-03 12:39 ` Maxime Ripard [this message]
2022-11-03 12:33 ` Maxime Ripard
2022-11-04 18:10 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103123930.koc22wtbch56ql4y@houat \
--to=maxime@cerno.tech \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).