* [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME
@ 2022-10-25 23:52 Douglas Anderson
2022-10-26 14:48 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Douglas Anderson @ 2022-10-25 23:52 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, Douglas Anderson, Andy Gross, Konrad Dybcio,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm,
linux-kernel
The sc7280-herobrine-villager derivative doesn't have NVME enabled so
we shouldn't mark the PCIe nodes as "okay" since they're just for
boards that have NVME.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
.../arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
index 3dff610fb946..17553e0fd6fd 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
@@ -78,16 +78,6 @@ &mdss_edp_phy {
status = "okay";
};
-/* For nvme */
-&pcie1 {
- status = "okay";
-};
-
-/* For nvme */
-&pcie1_phy {
- status = "okay";
-};
-
&pwmleds {
status = "okay";
};
--
2.38.0.135.g90850a2211-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME
2022-10-25 23:52 [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME Douglas Anderson
@ 2022-10-26 14:48 ` Krzysztof Kozlowski
2022-10-26 19:48 ` Stephen Boyd
2022-11-08 1:27 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-26 14:48 UTC (permalink / raw)
To: Douglas Anderson, Bjorn Andersson
Cc: Stephen Boyd, Andy Gross, Konrad Dybcio, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
On 25/10/2022 19:52, Douglas Anderson wrote:
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME
2022-10-25 23:52 [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME Douglas Anderson
2022-10-26 14:48 ` Krzysztof Kozlowski
@ 2022-10-26 19:48 ` Stephen Boyd
2022-11-08 1:27 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2022-10-26 19:48 UTC (permalink / raw)
To: Bjorn Andersson, Douglas Anderson
Cc: Andy Gross, Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-msm, linux-kernel
Quoting Douglas Anderson (2022-10-25 16:52:39)
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME
2022-10-25 23:52 [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME Douglas Anderson
2022-10-26 14:48 ` Krzysztof Kozlowski
2022-10-26 19:48 ` Stephen Boyd
@ 2022-11-08 1:27 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-11-08 1:27 UTC (permalink / raw)
To: dianders
Cc: devicetree, robh+dt, konrad.dybcio, krzysztof.kozlowski+dt,
agross, swboyd, linux-kernel, linux-arm-msm
On Tue, 25 Oct 2022 16:52:39 -0700, Douglas Anderson wrote:
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc7280: Villager doesn't have NVME
commit: bcfefc98c5781ee97f1b7a8063870830d9e42b30
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-08 1:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25 23:52 [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME Douglas Anderson
2022-10-26 14:48 ` Krzysztof Kozlowski
2022-10-26 19:48 ` Stephen Boyd
2022-11-08 1:27 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).