* [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
@ 2022-10-31 15:56 Colin Ian King
2022-11-01 0:22 ` Ping-Ke Shih
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Colin Ian King @ 2022-10-31 15:56 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
Variable stop_report_cnt is being set or incremented but is never
being used for anything meaningful. The variable and code relating
to it's use is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
index 8043d819fb85..a182cdeb58e2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
@@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
struct rtl_priv *rtlpriv = rtl_priv(hw);
u16 read_point, write_point;
bool ret = false;
- static u8 stop_report_cnt;
struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
{
@@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS)
ret = true;
- if (hw_queue < BEACON_QUEUE) {
- if (!ret)
- stop_report_cnt++;
- else
- stop_report_cnt = 0;
- }
-
return ret;
}
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
2022-10-31 15:56 [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt Colin Ian King
@ 2022-11-01 0:22 ` Ping-Ke Shih
2022-11-01 6:41 ` Ping-Ke Shih
2022-11-04 11:00 ` wifi: " Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Ping-Ke Shih @ 2022-11-01 0:22 UTC (permalink / raw)
To: Colin Ian King, Kalle Valo, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
> -----Original Message-----
> From: Colin Ian King <colin.i.king@gmail.com>
> Sent: Monday, October 31, 2022 11:57 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>
> Variable stop_report_cnt is being set or incremented but is never
> being used for anything meaningful. The variable and code relating
> to it's use is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> index 8043d819fb85..a182cdeb58e2 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> @@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> u16 read_point, write_point;
> bool ret = false;
> - static u8 stop_report_cnt;
> struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
>
> {
> @@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS)
> ret = true;
>
> - if (hw_queue < BEACON_QUEUE) {
> - if (!ret)
> - stop_report_cnt++;
> - else
> - stop_report_cnt = 0;
> - }
> -
> return ret;
> }
>
> --
> 2.37.3
>
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
2022-10-31 15:56 [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt Colin Ian King
2022-11-01 0:22 ` Ping-Ke Shih
@ 2022-11-01 6:41 ` Ping-Ke Shih
2022-11-01 7:36 ` Kalle Valo
2022-11-04 11:00 ` wifi: " Kalle Valo
2 siblings, 1 reply; 5+ messages in thread
From: Ping-Ke Shih @ 2022-11-01 6:41 UTC (permalink / raw)
To: Colin Ian King, Kalle Valo, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
> -----Original Message-----
> From: Ping-Ke Shih
> Sent: Tuesday, November 1, 2022 8:22 AM
> To: 'Colin Ian King' <colin.i.king@gmail.com>; Kalle Valo <kvalo@kernel.org>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>
>
> > -----Original Message-----
> > From: Colin Ian King <colin.i.king@gmail.com>
> > Sent: Monday, October 31, 2022 11:57 PM
> > To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; David S . Miller
> > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> > <pabeni@redhat.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
> > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
Subject prefix should be "wifi: rtlwifi: ..."
I'm not sure if Kalle can help this, or you can send v2 to add prefix.
> >
> > Variable stop_report_cnt is being set or incremented but is never
> > being used for anything meaningful. The variable and code relating
> > to it's use is redundant and can be removed.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> > ---
> > drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > index 8043d819fb85..a182cdeb58e2 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
> > @@ -997,7 +997,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> > struct rtl_priv *rtlpriv = rtl_priv(hw);
> > u16 read_point, write_point;
> > bool ret = false;
> > - static u8 stop_report_cnt;
> > struct rtl8192_tx_ring *ring = &rtlpci->tx_ring[hw_queue];
> >
> > {
> > @@ -1038,13 +1037,6 @@ bool rtl92ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
> > rtlpriv->psc.rfoff_reason > RF_CHANGE_BY_PS)
> > ret = true;
> >
> > - if (hw_queue < BEACON_QUEUE) {
> > - if (!ret)
> > - stop_report_cnt++;
> > - else
> > - stop_report_cnt = 0;
> > - }
> > -
> > return ret;
> > }
> >
> > --
> > 2.37.3
> >
> >
> > ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
2022-11-01 6:41 ` Ping-Ke Shih
@ 2022-11-01 7:36 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2022-11-01 7:36 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Colin Ian King, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-wireless, netdev, kernel-janitors,
linux-kernel
Ping-Ke Shih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: Ping-Ke Shih
>> Sent: Tuesday, November 1, 2022 8:22 AM
>> To: 'Colin Ian King' <colin.i.king@gmail.com>; Kalle Valo
>> <kvalo@kernel.org>; David S . Miller
>> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
>> Kicinski <kuba@kernel.org>; Paolo Abeni
>> <pabeni@redhat.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
>> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: RE: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>>
>>
>> > -----Original Message-----
>> > From: Colin Ian King <colin.i.king@gmail.com>
>> > Sent: Monday, October 31, 2022 11:57 PM
>> > To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo
>> > <kvalo@kernel.org>; David S . Miller
>> > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
>> > Kicinski <kuba@kernel.org>; Paolo Abeni
>> > <pabeni@redhat.com>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org
>> > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
>> > Subject: [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt
>
> Subject prefix should be "wifi: rtlwifi: ..."
>
> I'm not sure if Kalle can help this, or you can send v2 to add prefix.
Yeah, I can fix that during commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: wifi: rtlwifi: rtl8192ee: remove static variable stop_report_cnt
2022-10-31 15:56 [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt Colin Ian King
2022-11-01 0:22 ` Ping-Ke Shih
2022-11-01 6:41 ` Ping-Ke Shih
@ 2022-11-04 11:00 ` Kalle Valo
2 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2022-11-04 11:00 UTC (permalink / raw)
To: Colin Ian King
Cc: Ping-Ke Shih, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-wireless, netdev, kernel-janitors,
linux-kernel
Colin Ian King <colin.i.king@gmail.com> wrote:
> Variable stop_report_cnt is being set or incremented but is never
> being used for anything meaningful. The variable and code relating
> to it's use is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
cdeee8540952 wifi: rtlwifi: rtl8192ee: remove static variable stop_report_cnt
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221031155637.871164-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-04 11:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-31 15:56 [PATCH] rtlwifi: rtl8192ee: remove static variable stop_report_cnt Colin Ian King
2022-11-01 0:22 ` Ping-Ke Shih
2022-11-01 6:41 ` Ping-Ke Shih
2022-11-01 7:36 ` Kalle Valo
2022-11-04 11:00 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).