* Re: ECRC configuration if AER is owned by the firmware
[not found] <d1b3b790-dbad-0cee-bf45-fb2eefb947ab@nvidia.com>
@ 2022-10-31 17:23 ` Bjorn Helgaas
0 siblings, 0 replies; only message in thread
From: Bjorn Helgaas @ 2022-10-31 17:23 UTC (permalink / raw)
To: Vidya Sagar; +Cc: sr, linux-pci, linux-kernel
On Mon, Oct 31, 2022 at 10:35:40PM +0530, Vidya Sagar wrote:
> Hi,
> With the top of the tree codebase, pcie_set_ecrc_checking() is called from
> pci_aer_init().
> This flow doesn't really take into account the ownership of the AER
> registers, and it makes sense in the case of the Linux kernel owning the
> AER.
> But, if the owner of AER is firmware and not OS, then, ideally, any
> register/fields (including ECRC bits) are not supposed to be touched by the
> OS.
> Is my understanding correct?
> If so, then, isn't the current code violating that rule?
> Could you please comment on it?
I think you are correct and the current code violates the rule.
Bjorn
P.S. Your message was a multi-part message that will likely be
rejected by the vger mailing lists:
http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread