[PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Luca Weiss]

As in other bindings, let's use specific compatibles together with the
fallback compatible. Adjust the bindings for it.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Changes in v2:
* New patch

 .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml        | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml
index 2a94db688830..fa855baa368c 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml
@@ -18,7 +18,10 @@ description: |
 
 properties:
   compatible:
-    const: qcom,spmi-iadc
+    items:
+      - enum:
+          - qcom,pm8941-iadc
+      - const: qcom,spmi-iadc
 
   reg:
     description: IADC base address and length in the SPMI PMIC register map
@@ -50,7 +53,7 @@ examples:
         #address-cells = <1>;
         #size-cells = <0>;
         pmic_iadc: adc@3600 {
-            compatible = "qcom,spmi-iadc";
+            compatible = "qcom,pm8941-iadc", "qcom,spmi-iadc";
             reg = <0x3600>;
             interrupts = <0x0 0x36 0x0 IRQ_TYPE_EDGE_RISING>;
             qcom,external-resistor-micro-ohms = <10000>;
-- 
2.38.1

[PATCH v2 2/2] ARM: dts: qcom: pm8941: fix iadc node

[Luca Weiss]

The spmi-pmic bindings require the iadc node to be named just 'adc'.

Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Changes in v2:
* Drop changing double compatible, now bindings are adjusted
* Pick up tags

 arch/arm/boot/dts/qcom-pm8941.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
index a9e83836bf86..cd957a1e7cdf 100644
--- a/arch/arm/boot/dts/qcom-pm8941.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
@@ -131,7 +131,7 @@ adc-chan@30 {
 			};
 		};
 
-		pm8941_iadc: iadc@3600 {
+		pm8941_iadc: adc@3600 {
 			compatible = "qcom,pm8941-iadc", "qcom,spmi-iadc";
 			reg = <0x3600>;
 			interrupts = <0x0 0x36 0x0 IRQ_TYPE_EDGE_RISING>;
-- 
2.38.1

Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Rob Herring]

On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote:
> As in other bindings, let's use specific compatibles together with the
> fallback compatible. Adjust the bindings for it.

You should state users are already doing this.

> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> * New patch
> 
>  .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml        | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/2] ARM: dts: qcom: pm8941: fix iadc node

[Krzysztof Kozlowski]

On 31/10/2022 14:24, Luca Weiss wrote:
> The spmi-pmic bindings require the iadc node to be named just 'adc'.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> * Drop changing double compatible, now bindings are adjusted
> * Pick up tags
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Krzysztof Kozlowski]

On 31/10/2022 14:24, Luca Weiss wrote:
> As in other bindings, let's use specific compatibles together with the
> fallback compatible. Adjust the bindings for it.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> * New patch

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Jonathan Cameron]

On Wed, 2 Nov 2022 11:31:36 -0500
Rob Herring <robh@kernel.org> wrote:

> On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote:
> > As in other bindings, let's use specific compatibles together with the
> > fallback compatible. Adjust the bindings for it.  
> 
> You should state users are already doing this.
> 
I can fix that up whilst applying.  However it raises the question:
Should I treat this as a fix, or a tidy up (that can wait for next merge window)?

I'm also fine with this going with the other patch in the series (that lore
found for me as it didn't go to linux-iio) if that makes more sense.

If that happens

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Jonathan

> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > Changes in v2:
> > * New patch
> > 
> >  .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml        | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)  
> 
> Acked-by: Rob Herring <robh@kernel.org>

Re: (subset) [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Bjorn Andersson]

On Mon, 31 Oct 2022 19:24:54 +0100, Luca Weiss wrote:
> As in other bindings, let's use specific compatibles together with the
> fallback compatible. Adjust the bindings for it.
> 
> 

Applied, thanks!

[2/2] ARM: dts: qcom: pm8941: fix iadc node
      commit: f659cd2770767c5ceabadace1b334df9de468eae

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Luca Weiss]

Hi Jonathan,

On Sonntag, 6. November 2022 13:13:10 CET Jonathan Cameron wrote:
> On Wed, 2 Nov 2022 11:31:36 -0500
> 
> Rob Herring <robh@kernel.org> wrote:
> > On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote:
> > > As in other bindings, let's use specific compatibles together with the
> > > fallback compatible. Adjust the bindings for it.
> > 
> > You should state users are already doing this.
> 
> I can fix that up whilst applying.  However it raises the question:
> Should I treat this as a fix, or a tidy up (that can wait for next merge
> window)?
> 
> I'm also fine with this going with the other patch in the series (that lore
> found for me as it didn't go to linux-iio) if that makes more sense.
> 

Sorry for the delay in answering.
The dts patch (2/2) has already been picked up through qcom tree, so I think 
you can apply this one to your tree.
It's definitely not urgent, so next merge window would be perfect.

Regards
Luca

> If that happens
> 
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Jonathan
> 
> > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > > ---
> > > Changes in v2:
> > > * New patch
> > > 
> > >  .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml        | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles

[Jonathan Cameron]

On Fri, 18 Nov 2022 18:10:17 +0100
Luca Weiss <luca@z3ntu.xyz> wrote:

> Hi Jonathan,
> 
> On Sonntag, 6. November 2022 13:13:10 CET Jonathan Cameron wrote:
> > On Wed, 2 Nov 2022 11:31:36 -0500
> > 
> > Rob Herring <robh@kernel.org> wrote:  
> > > On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote:  
> > > > As in other bindings, let's use specific compatibles together with the
> > > > fallback compatible. Adjust the bindings for it.  
> > > 
> > > You should state users are already doing this.  
> > 
> > I can fix that up whilst applying.  However it raises the question:
> > Should I treat this as a fix, or a tidy up (that can wait for next merge
> > window)?
> > 
> > I'm also fine with this going with the other patch in the series (that lore
> > found for me as it didn't go to linux-iio) if that makes more sense.
> >   
> 
> Sorry for the delay in answering.
> The dts patch (2/2) has already been picked up through qcom tree, so I think 
> you can apply this one to your tree.
> It's definitely not urgent, so next merge window would be perfect.

Applied
> 
> Regards
> Luca
> 
> > If that happens
> > 
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Jonathan
> >   
> > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > > > ---
> > > > Changes in v2:
> > > > * New patch
> > > > 
> > > >  .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml        | 7 +++++--
> > > >  1 file changed, 5 insertions(+), 2 deletions(-)  
> > > 
> > > Acked-by: Rob Herring <robh@kernel.org>  
> 
> 
> 
>