From: Prabhakar <prabhakar.csengg@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shawn Tu <shawnx.tu@intel.com>, Jacopo Mondi <jacopo@jmondi.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: [PATCH v4 9/9] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev
Date: Mon, 31 Oct 2022 23:22:02 +0000 [thread overview]
Message-ID: <20221031232202.131945-10-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20221031232202.131945-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Make sure we call ov5645_entity_init_cfg() before registering the subdev
to make sure default formats are set up.
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v3->v4
* No change
v2->v3
* Included RB tag from Laurent.
v1->v2
* New patch
---
drivers/media/i2c/ov5645.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
index 0a889283da36..c8999fc4f26f 100644
--- a/drivers/media/i2c/ov5645.c
+++ b/drivers/media/i2c/ov5645.c
@@ -1220,6 +1220,8 @@ static int ov5645_probe(struct i2c_client *client)
pm_runtime_get_noresume(dev);
pm_runtime_enable(dev);
+ ov5645_entity_init_cfg(&ov5645->sd, NULL);
+
ret = v4l2_async_register_subdev(&ov5645->sd);
if (ret < 0) {
dev_err(dev, "could not register v4l2 device\n");
@@ -1231,8 +1233,6 @@ static int ov5645_probe(struct i2c_client *client)
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
- ov5645_entity_init_cfg(&ov5645->sd, NULL);
-
return 0;
err_pm_runtime:
--
2.25.1
prev parent reply other threads:[~2022-10-31 23:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 23:21 [PATCH v4 0/9] media: i2c: ov5645 driver enhancements Prabhakar
2022-10-31 23:21 ` [PATCH v4 1/9] media: i2c: ov5645: Drop fetching the clk reference by name Prabhakar
2022-10-31 23:21 ` [PATCH v4 2/9] ARM: dts: imx6qdl-pico: Drop clock-names property Prabhakar
2022-10-31 23:21 ` [PATCH v4 3/9] ARM: dts: imx6qdl-wandboard: " Prabhakar
2022-10-31 23:21 ` [PATCH v4 4/9] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: " Prabhakar
2022-10-31 23:21 ` [PATCH v4 5/9] media: dt-bindings: ov5645: Convert OV5645 binding to a schema Prabhakar
2022-11-02 16:38 ` Rob Herring
2022-10-31 23:21 ` [PATCH v4 6/9] media: i2c: ov5645: Use runtime PM Prabhakar
2022-11-28 13:49 ` Hans Verkuil
2022-11-28 13:53 ` Lad, Prabhakar
2022-11-29 0:02 ` Lad, Prabhakar
2022-10-31 23:22 ` [PATCH v4 7/9] media: i2c: ov5645: Drop empty comment Prabhakar
2022-10-31 23:22 ` [PATCH v4 8/9] media: i2c: ov5645: Make sure to call PM functions Prabhakar
2022-10-31 23:22 ` Prabhakar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031232202.131945-10-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=prabhakar.csengg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).