From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Shawn Tu <shawnx.tu@intel.com>, Jacopo Mondi <jacopo@jmondi.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v4 6/9] media: i2c: ov5645: Use runtime PM
Date: Mon, 28 Nov 2022 13:53:08 +0000 [thread overview]
Message-ID: <CA+V-a8smCQ0+Gz7Fo-P0H6j_4OmEqS5dLOVhWWQz8hPKHbazpA@mail.gmail.com> (raw)
In-Reply-To: <738a2461-7a6a-286b-89e8-d46a26ec6506@xs4all.nl>
Hi Hans,
On Mon, Nov 28, 2022 at 1:49 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
<snip>
> > +exit:
> > + ov5645_set_power_off(dev);
> > return ret;
>
> smatch gives this warning:
>
> drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
>
> Can you take a look?
>
Sure I'll have a look at it.
Cheers,
Prabhakar
next prev parent reply other threads:[~2022-11-28 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 23:21 [PATCH v4 0/9] media: i2c: ov5645 driver enhancements Prabhakar
2022-10-31 23:21 ` [PATCH v4 1/9] media: i2c: ov5645: Drop fetching the clk reference by name Prabhakar
2022-10-31 23:21 ` [PATCH v4 2/9] ARM: dts: imx6qdl-pico: Drop clock-names property Prabhakar
2022-10-31 23:21 ` [PATCH v4 3/9] ARM: dts: imx6qdl-wandboard: " Prabhakar
2022-10-31 23:21 ` [PATCH v4 4/9] arm64: dts: renesas: aistarvision-mipi-adapter-2.1: " Prabhakar
2022-10-31 23:21 ` [PATCH v4 5/9] media: dt-bindings: ov5645: Convert OV5645 binding to a schema Prabhakar
2022-11-02 16:38 ` Rob Herring
2022-10-31 23:21 ` [PATCH v4 6/9] media: i2c: ov5645: Use runtime PM Prabhakar
2022-11-28 13:49 ` Hans Verkuil
2022-11-28 13:53 ` Lad, Prabhakar [this message]
2022-11-29 0:02 ` Lad, Prabhakar
2022-10-31 23:22 ` [PATCH v4 7/9] media: i2c: ov5645: Drop empty comment Prabhakar
2022-10-31 23:22 ` [PATCH v4 8/9] media: i2c: ov5645: Make sure to call PM functions Prabhakar
2022-10-31 23:22 ` [PATCH v4 9/9] media: i2c: ov5645: Call ov5645_entity_init_cfg() before registering the subdev Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8smCQ0+Gz7Fo-P0H6j_4OmEqS5dLOVhWWQz8hPKHbazpA@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).