linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs
@ 2022-11-01 17:33 Manivannan Sadhasivam
  2022-11-01 18:22 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Manivannan Sadhasivam @ 2022-11-01 17:33 UTC (permalink / raw)
  To: andersson
  Cc: konrad.dybcio, mturquette, sboyd, linux-arm-msm, linux-clk,
	linux-kernel, Manivannan Sadhasivam

USB controllers on SM8250 doesn't work after coming back from suspend.
This can be fixed by keeping the USB GDSCs in retention mode so that
hardware can keep them ON and put into rentention mode once the parent
domain goes to a low power state.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/clk/qcom/gcc-sm8250.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
index 9755ef4888c1..a0ba37656b07 100644
--- a/drivers/clk/qcom/gcc-sm8250.c
+++ b/drivers/clk/qcom/gcc-sm8250.c
@@ -3267,7 +3267,7 @@ static struct gdsc usb30_prim_gdsc = {
 	.pd = {
 		.name = "usb30_prim_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	.pwrsts = PWRSTS_RET_ON,
 };
 
 static struct gdsc usb30_sec_gdsc = {
@@ -3275,7 +3275,7 @@ static struct gdsc usb30_sec_gdsc = {
 	.pd = {
 		.name = "usb30_sec_gdsc",
 	},
-	.pwrsts = PWRSTS_OFF_ON,
+	.pwrsts = PWRSTS_RET_ON,
 };
 
 static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc = {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs
  2022-11-01 17:33 [PATCH] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs Manivannan Sadhasivam
@ 2022-11-01 18:22 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2022-11-01 18:22 UTC (permalink / raw)
  To: Manivannan Sadhasivam, andersson
  Cc: konrad.dybcio, mturquette, linux-arm-msm, linux-clk,
	linux-kernel, Manivannan Sadhasivam

Quoting Manivannan Sadhasivam (2022-11-01 10:33:55)
> USB controllers on SM8250 doesn't work after coming back from suspend.
> This can be fixed by keeping the USB GDSCs in retention mode so that
> hardware can keep them ON and put into rentention mode once the parent
> domain goes to a low power state.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---

Any fixes tag?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-01 18:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 17:33 [PATCH] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs Manivannan Sadhasivam
2022-11-01 18:22 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).