From: Bjorn Andersson <andersson@kernel.org>
To: Shazad Hussain <quic_shazhuss@quicinc.com>
Cc: bmasney@redhat.com, Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref_clk
Date: Wed, 2 Nov 2022 21:54:15 -0500 [thread overview]
Message-ID: <20221103025415.qchtpnoxssudch6q@builder.lan> (raw)
In-Reply-To: <20221030142333.31019-1-quic_shazhuss@quicinc.com>
On Sun, Oct 30, 2022 at 07:53:33PM +0530, Shazad Hussain wrote:
> Since 'commit f3aa975e230e ("arm64: dts: qcom: sc8280xp: correct ref
> clock for ufs_mem_phy")' we need to explicitly make cxo as parent to
> gcc_ufs_ref_clkref_clk to have an independent vote from ufs_mem_phy.
>
Prior to that change we relied on both cxo and gcc_ufs_ref_clkref_clk
being voted for. So I think the reasoning for this patch should simply
be to express the fact that the clkref is fed from CXO.
Regards,
Bjorn
> Signed-off-by: Shazad Hussain <quic_shazhuss@quicinc.com>
> ---
> drivers/clk/qcom/gcc-sc8280xp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index a18ed88f3b82..72b545121c57 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -5848,6 +5848,8 @@ static struct clk_branch gcc_ufs_ref_clkref_clk = {
> .enable_mask = BIT(0),
> .hw.init = &(const struct clk_init_data) {
> .name = "gcc_ufs_ref_clkref_clk",
> + .parent_data = &gcc_parent_data_tcxo,
> + .num_parents = 1,
> .ops = &clk_branch2_ops,
> },
> },
> --
> 2.38.0
>
prev parent reply other threads:[~2022-11-03 2:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 14:23 [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref_clk Shazad Hussain
2022-10-31 11:22 ` Brian Masney
2022-11-01 18:23 ` Stephen Boyd
2022-11-02 7:16 ` Johan Hovold
2022-11-02 7:58 ` Shazad Hussain
2022-11-02 8:13 ` Johan Hovold
2022-11-02 8:45 ` Shazad Hussain
2022-11-02 9:26 ` Johan Hovold
2022-11-03 2:49 ` Bjorn Andersson
2022-11-03 9:06 ` Johan Hovold
2022-11-03 15:23 ` Bjorn Andersson
2022-11-04 9:29 ` Johan Hovold
2022-11-03 2:54 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103025415.qchtpnoxssudch6q@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bmasney@redhat.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_shazhuss@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).