From: Johan Hovold <johan@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Shazad Hussain <quic_shazhuss@quicinc.com>,
andersson@kernel.org, bmasney@redhat.com,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref_clk
Date: Wed, 2 Nov 2022 08:16:59 +0100 [thread overview]
Message-ID: <Y2IZaxukERXNcPGR@hovoldconsulting.com> (raw)
In-Reply-To: <20221101182402.32CE5C433C1@smtp.kernel.org>
On Tue, Nov 01, 2022 at 11:23:59AM -0700, Stephen Boyd wrote:
> Quoting Shazad Hussain (2022-10-30 07:23:33)
> > Since 'commit f3aa975e230e ("arm64: dts: qcom: sc8280xp: correct ref
>
> So we should have a Fixes tag for this commit? Or really back to the
> beginning of the driver?
>
> > clock for ufs_mem_phy")' we need to explicitly make cxo as parent to
> > gcc_ufs_ref_clkref_clk to have an independent vote from ufs_mem_phy.
The commit message is slightly misleading as this affects the other UFS
PHY as well.
If CX is indeed a parent of this clock then the issue has been there
since the clock driver was added. (And otherwise, the PHY binding may
need to be amended instead.)
Johan
next prev parent reply other threads:[~2022-11-02 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 14:23 [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref_clk Shazad Hussain
2022-10-31 11:22 ` Brian Masney
2022-11-01 18:23 ` Stephen Boyd
2022-11-02 7:16 ` Johan Hovold [this message]
2022-11-02 7:58 ` Shazad Hussain
2022-11-02 8:13 ` Johan Hovold
2022-11-02 8:45 ` Shazad Hussain
2022-11-02 9:26 ` Johan Hovold
2022-11-03 2:49 ` Bjorn Andersson
2022-11-03 9:06 ` Johan Hovold
2022-11-03 15:23 ` Bjorn Andersson
2022-11-04 9:29 ` Johan Hovold
2022-11-03 2:54 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2IZaxukERXNcPGR@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_shazhuss@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).