From: Guenter Roeck <linux@roeck-us.net>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>,
"garnermic@meta.com" <garnermic@meta.com>
Subject: Re: [v2 3/3] hwmon: Add Aspeed ast2600 TACH support
Date: Wed, 2 Nov 2022 21:30:34 -0700 [thread overview]
Message-ID: <20221103043034.GA2113834@roeck-us.net> (raw)
In-Reply-To: <F1166366-99CC-4A36-A0A2-4965C787E60B@aspeedtech.com>
On Thu, Nov 03, 2022 at 03:52:59AM +0000, Billy Tsai wrote:
>
> Can't I use a min/max RPM to let the driver know a reasonable timeout/polling period when
> the driver is trying to get RPM?
> Beacause that our tach controller have the falg to indicates the hardware detected the change
> in the input signal. I need the proper timout to rule out slow RPMs.
>
If the chip measures the fan speed continuously, why would that ever be a
problem, and why wait in the first place instead of just taking the most
recent result ?
Pretty much every other driver is doing that, so I really don't understand
why that would not work here.
Guenter
next prev parent reply other threads:[~2022-11-03 4:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 9:51 [v2 0/3] upport pwm/tach driver for aspeed ast26xx Billy Tsai
2022-11-01 9:51 ` [v2 1/3] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2022-11-01 18:40 ` Rob Herring
2022-11-02 3:21 ` Billy Tsai
2022-11-02 18:19 ` Rob Herring
2022-11-03 7:39 ` Billy Tsai
2022-11-14 8:26 ` Billy Tsai
2022-11-01 9:51 ` [v2 2/3] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2022-11-01 10:03 ` Christophe JAILLET
2022-11-01 9:51 ` [v2 3/3] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2022-11-01 10:16 ` Christophe JAILLET
2022-11-01 13:14 ` Guenter Roeck
2022-11-02 6:54 ` Billy Tsai
2022-11-02 17:01 ` Guenter Roeck
2022-11-03 3:52 ` Billy Tsai
2022-11-03 4:30 ` Guenter Roeck [this message]
2022-11-03 5:40 ` Billy Tsai
2022-11-03 14:30 ` Guenter Roeck
2022-11-08 7:17 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103043034.GA2113834@roeck-us.net \
--to=linux@roeck-us.net \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=garnermic@meta.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).