From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
joel@jms.id.au, andrew@aj.id.au, lee.jones@linaro.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com,
garnermic@meta.com
Subject: Re: [v2 3/3] hwmon: Add Aspeed ast2600 TACH support
Date: Tue, 1 Nov 2022 11:16:45 +0100 [thread overview]
Message-ID: <4e7beec4-9b77-a125-6715-2699c453f5fe@wanadoo.fr> (raw)
In-Reply-To: <20221101095156.30591-4-billy_tsai@aspeedtech.com>
Le 01/11/2022 à 10:51, Billy Tsai a écrit :
> This patch add the support of Tachometer which can use to monitor the
> frequency of the input. The tach supports up to 16 channels and it's part
> function of multi-function device "pwm-tach controller".
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Hi,
a few nits below,
[...]
> +
> + if (ret) {
> + /* return 0 if we didn't get an answer because of timeout*/
Missing space at the end of the comment
> + if (ret == -ETIMEDOUT)
> + return 0;
> + else
> + return ret;
[...]
> +static int aspeed_tach_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct device_node *np, *child;
> + struct aspeed_tach_data *priv;
> + struct device *hwmon;
> + struct platform_device *parent_dev;
> + int ret;
> +
> + np = dev->parent->of_node;
> + if (!of_device_is_compatible(np, "aspeed,ast2600-pwm-tach"))
> + return dev_err_probe(dev, -ENODEV,
> + "Unsupported tach device binding\n");
> +
> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> + priv->dev = &pdev->dev;
> + priv->tach_channel =
> + devm_kzalloc(dev,
> + TACH_ASPEED_NR_TACHS * sizeof(*priv->tach_channel),
> + GFP_KERNEL);
use devm_kcalloc() instead of devm_kzalloc()?
Error handling?
> +
> + priv->regmap = syscon_node_to_regmap(np);
> + if (IS_ERR(priv->regmap)) {
> + dev_err(priv->dev, "Couldn't get regmap\n");
In order to be conistent with the other error handling paths:
return dev_err_probe()?
> + return -ENODEV;
> + }
[...]
next prev parent reply other threads:[~2022-11-01 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 9:51 [v2 0/3] upport pwm/tach driver for aspeed ast26xx Billy Tsai
2022-11-01 9:51 ` [v2 1/3] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2022-11-01 18:40 ` Rob Herring
2022-11-02 3:21 ` Billy Tsai
2022-11-02 18:19 ` Rob Herring
2022-11-03 7:39 ` Billy Tsai
2022-11-14 8:26 ` Billy Tsai
2022-11-01 9:51 ` [v2 2/3] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2022-11-01 10:03 ` Christophe JAILLET
2022-11-01 9:51 ` [v2 3/3] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2022-11-01 10:16 ` Christophe JAILLET [this message]
2022-11-01 13:14 ` Guenter Roeck
2022-11-02 6:54 ` Billy Tsai
2022-11-02 17:01 ` Guenter Roeck
2022-11-03 3:52 ` Billy Tsai
2022-11-03 4:30 ` Guenter Roeck
2022-11-03 5:40 ` Billy Tsai
2022-11-03 14:30 ` Guenter Roeck
2022-11-08 7:17 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7beec4-9b77-a125-6715-2699c453f5fe@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=garnermic@meta.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).