* [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property
@ 2022-11-03 4:12 Radhey Shyam Pandey
2022-11-03 7:02 ` Peter Korsgaard
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Radhey Shyam Pandey @ 2022-11-03 4:12 UTC (permalink / raw)
To: vkoul, robh+dt, krzysztof.kozlowski+dt
Cc: michal.simek, m.tretter, harini.katakam, dmaengine, devicetree,
linux-kernel, git, Radhey Shyam Pandey
xlnx,bus-width is a required property. In yaml conversion somehow
it got missed out. Bring it back and mention it in required list.
Also add Harini and myself to the maintainer list.
Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
.../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
index c0a1408b12ec..a10019d3a650 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
+++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
@@ -13,6 +13,8 @@ description: |
maintainers:
- Michael Tretter <m.tretter@pengutronix.de>
+ - Harini Katakam <harini.katakam@amd.com>
+ - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
allOf:
- $ref: "../dma-controller.yaml#"
@@ -65,6 +67,7 @@ required:
- interrupts
- clocks
- clock-names
+ - xlnx,bus-width
additionalProperties: false
base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property
2022-11-03 4:12 [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property Radhey Shyam Pandey
@ 2022-11-03 7:02 ` Peter Korsgaard
2022-11-03 13:20 ` Krzysztof Kozlowski
2022-11-03 13:39 ` Michael Tretter
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-11-03 7:02 UTC (permalink / raw)
To: Radhey Shyam Pandey
Cc: vkoul, robh+dt, krzysztof.kozlowski+dt, michal.simek, m.tretter,
harini.katakam, dmaengine, devicetree, linux-kernel, git
>>>>> "Radhey" == Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> writes:
> xlnx,bus-width is a required property. In yaml conversion somehow
> it got missed out. Bring it back and mention it in required list.
> Also add Harini and myself to the maintainer list.
> Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> index c0a1408b12ec..a10019d3a650 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> @@ -13,6 +13,8 @@ description: |
> maintainers:
> - Michael Tretter <m.tretter@pengutronix.de>
> + - Harini Katakam <harini.katakam@amd.com>
> + - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
That should ideally be in a separate patch.
> allOf:
> - $ref: "../dma-controller.yaml#"
> @@ -65,6 +67,7 @@ required:
> - interrupts
> - clocks
> - clock-names
> + - xlnx,bus-width
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property
2022-11-03 4:12 [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property Radhey Shyam Pandey
2022-11-03 7:02 ` Peter Korsgaard
@ 2022-11-03 13:20 ` Krzysztof Kozlowski
2022-11-03 13:39 ` Michael Tretter
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-03 13:20 UTC (permalink / raw)
To: Radhey Shyam Pandey, vkoul, robh+dt, krzysztof.kozlowski+dt
Cc: michal.simek, m.tretter, harini.katakam, dmaengine, devicetree,
linux-kernel, git
On 03/11/2022 00:12, Radhey Shyam Pandey wrote:
> xlnx,bus-width is a required property. In yaml conversion somehow
> it got missed out. Bring it back and mention it in required list.
> Also add Harini and myself to the maintainer list.
>
> Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property
2022-11-03 4:12 [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property Radhey Shyam Pandey
2022-11-03 7:02 ` Peter Korsgaard
2022-11-03 13:20 ` Krzysztof Kozlowski
@ 2022-11-03 13:39 ` Michael Tretter
2 siblings, 0 replies; 4+ messages in thread
From: Michael Tretter @ 2022-11-03 13:39 UTC (permalink / raw)
To: Radhey Shyam Pandey
Cc: vkoul, robh+dt, krzysztof.kozlowski+dt, michal.simek,
harini.katakam, dmaengine, devicetree, linux-kernel, git, kernel
On Thu, 03 Nov 2022 09:42:37 +0530, Radhey Shyam Pandey wrote:
> xlnx,bus-width is a required property. In yaml conversion somehow
> it got missed out. Bring it back and mention it in required list.
> Also add Harini and myself to the maintainer list.
>
> Fixes: 5a04982df8da ("dt-bindings: dmaengine: zynqmp_dma: convert to yaml")
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> index c0a1408b12ec..a10019d3a650 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> @@ -13,6 +13,8 @@ description: |
>
> maintainers:
> - Michael Tretter <m.tretter@pengutronix.de>
> + - Harini Katakam <harini.katakam@amd.com>
> + - Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>
> allOf:
> - $ref: "../dma-controller.yaml#"
> @@ -65,6 +67,7 @@ required:
> - interrupts
> - clocks
> - clock-names
> + - xlnx,bus-width
>
> additionalProperties: false
>
>
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-03 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 4:12 [PATCH] dt-bindings: dmaengine: zynqmp_dma: add xlnx,bus-width required property Radhey Shyam Pandey
2022-11-03 7:02 ` Peter Korsgaard
2022-11-03 13:20 ` Krzysztof Kozlowski
2022-11-03 13:39 ` Michael Tretter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).