* [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
[not found] <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcas5p2.samsung.com>
@ 2022-11-04 9:00 ` Inbaraj
2022-11-04 13:55 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Inbaraj @ 2022-11-04 9:00 UTC (permalink / raw)
To: krzysztof.kozlowski, s.nawrocki, tomasz.figa, cw00.choi,
alim.akhtar, mturquette, sboyd, robh+dt, chanho61.park
Cc: linux-samsung-soc, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, pankaj.dubey, Inbaraj
Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
This fixes make dtbs_check warning as shown below:
arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
bindings/clock/samsung,exynosautov9-clock.yaml
Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
Signed-off-by: Inbaraj <inbaraj.e@samsung.com>
---
.../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
index 2ab4642679c0..55c4f94a14d1 100644
--- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
@@ -148,7 +148,7 @@ allOf:
items:
- const: oscclk
- const: dout_clkcmu_fsys1_bus
- - const: dout_clkcmu_fsys1_mmc_card
+ - const: gout_clkcmu_fsys1_mmc_card
- const: dout_clkcmu_fsys1_usbdrd
- if:
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
2022-11-04 9:00 ` [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock Inbaraj
@ 2022-11-04 13:55 ` Krzysztof Kozlowski
2022-11-04 19:23 ` Krzysztof Kozlowski
[not found] ` <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-04 13:55 UTC (permalink / raw)
To: Inbaraj, s.nawrocki, tomasz.figa, cw00.choi, alim.akhtar,
mturquette, sboyd, robh+dt, chanho61.park
Cc: linux-samsung-soc, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, pankaj.dubey
On 04/11/2022 05:00, Inbaraj wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>
> This fixes make dtbs_check warning as shown below:
>
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
> From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
> bindings/clock/samsung,exynosautov9-clock.yaml
I don't understand:
1. Why bindings are wrong not DTSI?
2. What is "gout"? "dout" had a meaning as clock divider output.
>
> Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
> Signed-off-by: Inbaraj <inbaraj.e@samsung.com>
> ---
> .../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> index 2ab4642679c0..55c4f94a14d1 100644
> --- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> @@ -148,7 +148,7 @@ allOf:
> items:
> - const: oscclk
> - const: dout_clkcmu_fsys1_bus
> - - const: dout_clkcmu_fsys1_mmc_card
> + - const: gout_clkcmu_fsys1_mmc_card
> - const: dout_clkcmu_fsys1_usbdrd
>
> - if:
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
2022-11-04 9:00 ` [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock Inbaraj
2022-11-04 13:55 ` Krzysztof Kozlowski
@ 2022-11-04 19:23 ` Krzysztof Kozlowski
[not found] ` <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-04 19:23 UTC (permalink / raw)
To: Inbaraj, krzysztof.kozlowski, s.nawrocki, tomasz.figa, cw00.choi,
alim.akhtar, mturquette, sboyd, robh+dt, chanho61.park
Cc: linux-samsung-soc, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, pankaj.dubey
On 04/11/2022 05:00, Inbaraj wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>
> This fixes make dtbs_check warning as shown below:
>
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
> From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
> bindings/clock/samsung,exynosautov9-clock.yaml
>
> Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
> Signed-off-by: Inbaraj <inbaraj.e@samsung.com>
One more comment - is Inbaraj your full legal name? Full name must be
used in From and Sob. Your email address has some additional "e", so I
wonder.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
[not found] ` <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
@ 2022-11-07 0:04 ` CHANHO PARK
2022-11-07 9:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: CHANHO PARK @ 2022-11-07 0:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Inbaraj E, Sylwester Nawrocki, tomasz.figa,
Chanwoo Choi, ALIM AKHTAR, mturquette, sboyd, robh+dt,
CHANHO PARK
Cc: linux-samsung-soc, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, PANKAJ KUMAR DUBEY
> > Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> >
> > This fixes make dtbs_check warning as shown below:
> >
> > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> controller@17040000:
> > clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
> > /home/inbaraj/mainline/linux/Documentation/devicetree/
> > bindings/clock/samsung,exynosautov9-clock.yaml
>
> I don't understand:
> 1. Why bindings are wrong not DTSI?
> 2. What is "gout"? "dout" had a meaning as clock divider output.
"gout" is output of a gate clock, AFAIK.
Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".
>
> >
> > Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for
> > cmu_fsys0/1")
> > Signed-off-by: Inbaraj <inbaraj.e@samsung.com>
Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Best Regards,
Chanho Park
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
2022-11-07 0:04 ` CHANHO PARK
@ 2022-11-07 9:12 ` Krzysztof Kozlowski
2022-11-07 12:37 ` Inbaraj E
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-07 9:12 UTC (permalink / raw)
To: chanho61.park, Inbaraj E, Sylwester Nawrocki, tomasz.figa,
Chanwoo Choi, ALIM AKHTAR, mturquette, sboyd, robh+dt
Cc: linux-samsung-soc, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, PANKAJ KUMAR DUBEY
On 07/11/2022 01:04, CHANHO PARK wrote:
>>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>>>
>>> This fixes make dtbs_check warning as shown below:
>>>
>>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
>> controller@17040000:
>>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
>>> /home/inbaraj/mainline/linux/Documentation/devicetree/
>>> bindings/clock/samsung,exynosautov9-clock.yaml
>>
>> I don't understand:
>> 1. Why bindings are wrong not DTSI?
>> 2. What is "gout"? "dout" had a meaning as clock divider output.
>
> "gout" is output of a gate clock, AFAIK.
> Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".
OK, then this should be in commit msg.
My question about full legal name remains, as here in replies I see
"Inbaraj E".
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock
2022-11-07 9:12 ` Krzysztof Kozlowski
@ 2022-11-07 12:37 ` Inbaraj E
0 siblings, 0 replies; 6+ messages in thread
From: Inbaraj E @ 2022-11-07 12:37 UTC (permalink / raw)
To: 'Krzysztof Kozlowski',
chanho61.park, 'Sylwester Nawrocki',
tomasz.figa, 'Chanwoo Choi', 'ALIM AKHTAR',
mturquette, sboyd, robh+dt
Cc: linux-samsung-soc, linux-clk, devicetree, linux-arm-kernel,
linux-kernel, 'PANKAJ KUMAR DUBEY'
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 07 November 2022 14:42
> To: chanho61.park@samsung.com; Inbaraj E <inbaraj.e@samsung.com>;
> Sylwester Nawrocki <s.nawrocki@samsung.com>; tomasz.figa@gmail.com;
> Chanwoo Choi <cw00.choi@samsung.com>; ALIM AKHTAR
> <alim.akhtar@samsung.com>; mturquette@baylibre.com;
> sboyd@kernel.org; robh+dt@kernel.org
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; PANKAJ KUMAR DUBEY
> <pankaj.dubey@samsung.com>
> Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
> CMU_FSYS1 mmc card clock
>
> On 07/11/2022 01:04, CHANHO PARK wrote:
> >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of
> dout.
> >>>
> >>> This fixes make dtbs_check warning as shown below:
> >>>
> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> >> controller@17040000:
> >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From
> schema:
> >>> /home/inbaraj/mainline/linux/Documentation/devicetree/
> >>> bindings/clock/samsung,exynosautov9-clock.yaml
> >>
> >> I don't understand:
> >> 1. Why bindings are wrong not DTSI?
> >> 2. What is "gout"? "dout" had a meaning as clock divider output.
> >
> > "gout" is output of a gate clock, AFAIK.
> > Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
> So, it should be "mout -> gout" instead of "mout -> gout -> dout".
>
> OK, then this should be in commit msg.
>
> My question about full legal name remains, as here in replies I see "Inbaraj
> E".
>
I have address your review comment, and posted v2.
Thanks for review.
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-07 14:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcas5p2.samsung.com>
2022-11-04 9:00 ` [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock Inbaraj
2022-11-04 13:55 ` Krzysztof Kozlowski
2022-11-04 19:23 ` Krzysztof Kozlowski
[not found] ` <CGME20221104085410epcas5p24d88f59001b739075e9e190e2c47841e@epcms2p3>
2022-11-07 0:04 ` CHANHO PARK
2022-11-07 9:12 ` Krzysztof Kozlowski
2022-11-07 12:37 ` Inbaraj E
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).