From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, minchan@kernel.org,
ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com,
ddstreet@ieee.org, vitaly.wool@konsulko.com
Subject: [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order
Date: Tue, 8 Nov 2022 11:32:05 -0800 [thread overview]
Message-ID: <20221108193207.3297327-4-nphamcs@gmail.com> (raw)
In-Reply-To: <20221108193207.3297327-1-nphamcs@gmail.com>
This helps determines the coldest zspages as candidates for writeback.
Signed-off-by: Nhat Pham <nphamcs@gmail.com>
---
mm/zsmalloc.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 326faa751f0a..600c40121544 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -239,6 +239,9 @@ struct zs_pool {
/* Compact classes */
struct shrinker shrinker;
+ /* List tracking the zspages in LRU order by most recently added object */
+ struct list_head lru;
+
#ifdef CONFIG_ZSMALLOC_STAT
struct dentry *stat_dentry;
#endif
@@ -260,6 +263,10 @@ struct zspage {
unsigned int freeobj;
struct page *first_page;
struct list_head list; /* fullness list */
+
+ /* links the zspage to the lru list in the pool */
+ struct list_head lru;
+
struct zs_pool *pool;
#ifdef CONFIG_COMPACTION
rwlock_t lock;
@@ -352,6 +359,16 @@ static void cache_free_zspage(struct zs_pool *pool, struct zspage *zspage)
kmem_cache_free(pool->zspage_cachep, zspage);
}
+/* Moves the zspage to the front of the zspool's LRU */
+static void move_to_front(struct zs_pool *pool, struct zspage *zspage)
+{
+ assert_spin_locked(&pool->lock);
+
+ if (!list_empty(&zspage->lru))
+ list_del(&zspage->lru);
+ list_add(&zspage->lru, &pool->lru);
+}
+
/* pool->lock(which owns the handle) synchronizes races */
static void record_obj(unsigned long handle, unsigned long obj)
{
@@ -953,6 +970,7 @@ static void free_zspage(struct zs_pool *pool, struct size_class *class,
}
remove_zspage(class, zspage, ZS_EMPTY);
+ list_del(&zspage->lru);
__free_zspage(pool, class, zspage);
}
@@ -998,6 +1016,8 @@ static void init_zspage(struct size_class *class, struct zspage *zspage)
off %= PAGE_SIZE;
}
+ INIT_LIST_HEAD(&zspage->lru);
+
set_freeobj(zspage, 0);
}
@@ -1418,6 +1438,8 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp)
fix_fullness_group(class, zspage);
record_obj(handle, obj);
class_stat_inc(class, OBJ_USED, 1);
+ /* Move the zspage to front of pool's LRU */
+ move_to_front(pool, zspage);
spin_unlock(&pool->lock);
return handle;
@@ -1444,6 +1466,8 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp)
/* We completely set up zspage so mark them as movable */
SetZsPageMovable(pool, zspage);
+ /* Move the zspage to front of pool's LRU */
+ move_to_front(pool, zspage);
spin_unlock(&pool->lock);
return handle;
@@ -1967,6 +1991,7 @@ static void async_free_zspage(struct work_struct *work)
VM_BUG_ON(fullness != ZS_EMPTY);
class = pool->size_class[class_idx];
spin_lock(&pool->lock);
+ list_del(&zspage->lru);
__free_zspage(pool, class, zspage);
spin_unlock(&pool->lock);
}
@@ -2278,6 +2303,8 @@ struct zs_pool *zs_create_pool(const char *name)
*/
zs_register_shrinker(pool);
+ INIT_LIST_HEAD(&pool->lru);
+
return pool;
err:
--
2.30.2
next prev parent reply other threads:[~2022-11-08 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 19:32 [PATCH v3 0/5] Implement writeback for zsmalloc Nhat Pham
2022-11-08 19:32 ` [PATCH v3 1/5] zswap: fix writeback lock ordering " Nhat Pham
2022-11-08 19:32 ` [PATCH v3 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-11-08 19:32 ` Nhat Pham [this message]
2022-11-09 21:55 ` [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Minchan Kim
2022-11-10 17:18 ` Nhat Pham
2022-11-10 22:48 ` Minchan Kim
2022-11-16 22:02 ` Johannes Weiner
2022-11-16 23:49 ` Minchan Kim
2022-11-17 0:37 ` Sergey Senozhatsky
2022-11-08 19:32 ` [PATCH v3 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Nhat Pham
2022-11-08 19:32 ` [PATCH v3 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-11-08 20:45 ` [PATCH v3 0/5] Implement writeback " Johannes Weiner
2022-11-09 4:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108193207.3297327-4-nphamcs@gmail.com \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).