From: Minchan Kim <minchan@kernel.org>
To: Nhat Pham <nphamcs@gmail.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com,
ddstreet@ieee.org, vitaly.wool@konsulko.com
Subject: Re: [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order
Date: Wed, 9 Nov 2022 13:55:45 -0800 [thread overview]
Message-ID: <Y2wh4b3oMaknNqGP@google.com> (raw)
In-Reply-To: <20221108193207.3297327-4-nphamcs@gmail.com>
On Tue, Nov 08, 2022 at 11:32:05AM -0800, Nhat Pham wrote:
> This helps determines the coldest zspages as candidates for writeback.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
> mm/zsmalloc.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 326faa751f0a..600c40121544 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -239,6 +239,9 @@ struct zs_pool {
> /* Compact classes */
> struct shrinker shrinker;
>
> + /* List tracking the zspages in LRU order by most recently added object */
> + struct list_head lru;
> +
> #ifdef CONFIG_ZSMALLOC_STAT
> struct dentry *stat_dentry;
> #endif
> @@ -260,6 +263,10 @@ struct zspage {
> unsigned int freeobj;
> struct page *first_page;
> struct list_head list; /* fullness list */
> +
> + /* links the zspage to the lru list in the pool */
> + struct list_head lru;
Please put the LRU logic under config ZSMALLOC_LRU since we don't need
the additional logic to others.
next prev parent reply other threads:[~2022-11-09 21:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 19:32 [PATCH v3 0/5] Implement writeback for zsmalloc Nhat Pham
2022-11-08 19:32 ` [PATCH v3 1/5] zswap: fix writeback lock ordering " Nhat Pham
2022-11-08 19:32 ` [PATCH v3 2/5] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-11-08 19:32 ` [PATCH v3 3/5] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-11-09 21:55 ` Minchan Kim [this message]
2022-11-10 17:18 ` Nhat Pham
2022-11-10 22:48 ` Minchan Kim
2022-11-16 22:02 ` Johannes Weiner
2022-11-16 23:49 ` Minchan Kim
2022-11-17 0:37 ` Sergey Senozhatsky
2022-11-08 19:32 ` [PATCH v3 4/5] zsmalloc: Add ops fields to zs_pool to store evict handlers Nhat Pham
2022-11-08 19:32 ` [PATCH v3 5/5] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-11-08 20:45 ` [PATCH v3 0/5] Implement writeback " Johannes Weiner
2022-11-09 4:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2wh4b3oMaknNqGP@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).