* linux-next: build failure after merge of the mhi tree
@ 2022-11-09 4:16 Stephen Rothwell
2022-11-09 7:42 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2022-11-09 4:16 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Jeff Johnson, Manivannan Sadhasivam, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/bus/mhi/host/pci_generic.c: In function 'mhi_pci_get_irqs':
drivers/bus/mhi/host/pci_generic.c:743:60: error: assignment of member 'irq' in read-only object
743 | mhi_cntrl_config->event_cfg[i].irq = 0;
| ^
Caused by commit
c970e67d64a5 ("bus: mhi: host: make mhi_controller_config::event_cfg const")
I have used the mhi tree from next-20221108 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2022-11-09 4:16 linux-next: build failure after merge of the mhi tree Stephen Rothwell
@ 2022-11-09 7:42 ` Manivannan Sadhasivam
0 siblings, 0 replies; 29+ messages in thread
From: Manivannan Sadhasivam @ 2022-11-09 7:42 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Jeff Johnson, Manivannan Sadhasivam, Linux Kernel Mailing List,
Linux Next Mailing List
On Wed, Nov 09, 2022 at 03:16:37PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/bus/mhi/host/pci_generic.c: In function 'mhi_pci_get_irqs':
> drivers/bus/mhi/host/pci_generic.c:743:60: error: assignment of member 'irq' in read-only object
> 743 | mhi_cntrl_config->event_cfg[i].irq = 0;
> | ^
>
> Caused by commit
>
> c970e67d64a5 ("bus: mhi: host: make mhi_controller_config::event_cfg const")
>
Dropped it now.
Thanks,
Mani
> I have used the mhi tree from next-20221108 for today.
>
> --
> Cheers,
> Stephen Rothwell
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 29+ messages in thread
* linux-next: build failure after merge of the mhi tree
@ 2022-03-02 6:37 Stephen Rothwell
2022-03-02 6:48 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2022-03-02 6:37 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Manivannan Sadhasivam, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/bus/mhi/ep/main.c: In function 'mhi_ep_register_controller':
drivers/bus/mhi/ep/main.c:1426:9: error: implicit declaration of function 'irq_set_status_flags' [-Werror=implicit-function-declaration]
1426 | irq_set_status_flags(mhi_cntrl->irq, IRQ_NOAUTOEN);
| ^~~~~~~~~~~~~~~~~~~~
drivers/bus/mhi/ep/main.c:1426:46: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'?
1426 | irq_set_status_flags(mhi_cntrl->irq, IRQ_NOAUTOEN);
| ^~~~~~~~~~~~
| IRQF_NO_AUTOEN
drivers/bus/mhi/ep/main.c:1426:46: note: each undeclared identifier is reported only once for each function it appears in
Caused by commit
6cb3bc57b0c5 ("bus: mhi: ep: Add support for processing MHI endpoint interrupts")
Presumably a missing include.
I have used the mhi tree from next-20220301 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2022-03-02 6:37 Stephen Rothwell
@ 2022-03-02 6:48 ` Manivannan Sadhasivam
0 siblings, 0 replies; 29+ messages in thread
From: Manivannan Sadhasivam @ 2022-03-02 6:48 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
On Wed, Mar 02, 2022 at 05:37:14PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/bus/mhi/ep/main.c: In function 'mhi_ep_register_controller':
> drivers/bus/mhi/ep/main.c:1426:9: error: implicit declaration of function 'irq_set_status_flags' [-Werror=implicit-function-declaration]
> 1426 | irq_set_status_flags(mhi_cntrl->irq, IRQ_NOAUTOEN);
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/bus/mhi/ep/main.c:1426:46: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'?
> 1426 | irq_set_status_flags(mhi_cntrl->irq, IRQ_NOAUTOEN);
> | ^~~~~~~~~~~~
> | IRQF_NO_AUTOEN
> drivers/bus/mhi/ep/main.c:1426:46: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> 6cb3bc57b0c5 ("bus: mhi: ep: Add support for processing MHI endpoint interrupts")
>
> Presumably a missing include.
>
Yes, it seems I was missing "#include <linux/irq.h>" for irq APIs. Fixed
now!
But somehow this header got included in ARM cross compilation and I
failed to catch it.
Thanks,
Mani
> I have used the mhi tree from next-20220301 for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread
* linux-next: build failure after merge of the mhi tree
@ 2021-08-09 9:38 Stephen Rothwell
2021-08-09 9:55 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2021-08-09 9:38 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Greg KH, Arnd Bergmann, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/bus/mhi/pci_generic.c:406:40: error: redefinition of 'mhi_mv31_channels'
406 | static const struct mhi_channel_config mhi_mv31_channels[] = {
| ^~~~~~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:372:40: note: previous definition of 'mhi_mv31_channels' was here
372 | static const struct mhi_channel_config mhi_mv31_channels[] = {
| ^~~~~~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:417:32: error: redefinition of 'mhi_mv31_events'
417 | static struct mhi_event_config mhi_mv31_events[] = {
| ^~~~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:383:32: note: previous definition of 'mhi_mv31_events' was here
383 | static struct mhi_event_config mhi_mv31_events[] = {
| ^~~~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:424:43: error: redefinition of 'modem_mv31_config'
424 | static const struct mhi_controller_config modem_mv31_config = {
| ^~~~~~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:390:43: note: previous definition of 'modem_mv31_config' was here
390 | static const struct mhi_controller_config modem_mv31_config = {
| ^~~~~~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:433:38: error: redefinition of 'mhi_mv31_info'
433 | static const struct mhi_pci_dev_info mhi_mv31_info = {
| ^~~~~~~~~~~~~
drivers/bus/mhi/pci_generic.c:399:38: note: previous definition of 'mhi_mv31_info' was here
399 | static const struct mhi_pci_dev_info mhi_mv31_info = {
| ^~~~~~~~~~~~~
Caused by an newer version (but almost identical) of all the mhi tree
commits are also now in the char-misc tree (almos identical patches,
but different commits.
I have dropped the mhi tree for today (please clean it up).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2021-08-09 9:38 Stephen Rothwell
@ 2021-08-09 9:55 ` Manivannan Sadhasivam
0 siblings, 0 replies; 29+ messages in thread
From: Manivannan Sadhasivam @ 2021-08-09 9:55 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, Arnd Bergmann, Linux Kernel Mailing List,
Linux Next Mailing List
Hi Stephen,
On Mon, Aug 09, 2021 at 07:38:37PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/bus/mhi/pci_generic.c:406:40: error: redefinition of 'mhi_mv31_channels'
> 406 | static const struct mhi_channel_config mhi_mv31_channels[] = {
> | ^~~~~~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:372:40: note: previous definition of 'mhi_mv31_channels' was here
> 372 | static const struct mhi_channel_config mhi_mv31_channels[] = {
> | ^~~~~~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:417:32: error: redefinition of 'mhi_mv31_events'
> 417 | static struct mhi_event_config mhi_mv31_events[] = {
> | ^~~~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:383:32: note: previous definition of 'mhi_mv31_events' was here
> 383 | static struct mhi_event_config mhi_mv31_events[] = {
> | ^~~~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:424:43: error: redefinition of 'modem_mv31_config'
> 424 | static const struct mhi_controller_config modem_mv31_config = {
> | ^~~~~~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:390:43: note: previous definition of 'modem_mv31_config' was here
> 390 | static const struct mhi_controller_config modem_mv31_config = {
> | ^~~~~~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:433:38: error: redefinition of 'mhi_mv31_info'
> 433 | static const struct mhi_pci_dev_info mhi_mv31_info = {
> | ^~~~~~~~~~~~~
> drivers/bus/mhi/pci_generic.c:399:38: note: previous definition of 'mhi_mv31_info' was here
> 399 | static const struct mhi_pci_dev_info mhi_mv31_info = {
> | ^~~~~~~~~~~~~
>
> Caused by an newer version (but almost identical) of all the mhi tree
> commits are also now in the char-misc tree (almos identical patches,
> but different commits.
>
That's due to sending the patches as a series to Greg instead of pull
request.
> I have dropped the mhi tree for today (please clean it up).
>
Done!
Thanks,
Mani
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread
* linux-next: build failure after merge of the mhi tree
@ 2020-11-17 4:12 Stephen Rothwell
2020-11-17 4:23 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2020-11-17 4:12 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
27 | .auto_start = false,
| ^~~~~~~~~~
drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
42 | .auto_start = false,
| ^~~~~~~~~~
drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
57 | .auto_start = true,
| ^~~~~~~~~~
drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
72 | .auto_start = true,
| ^~~~~~~~~~
Caused by commit
0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
I have used the mhi tree from next-20201116 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-11-17 4:12 Stephen Rothwell
@ 2020-11-17 4:23 ` Manivannan Sadhasivam
2020-11-17 4:28 ` Manivannan Sadhasivam
2020-11-18 4:39 ` Stephen Rothwell
0 siblings, 2 replies; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-17 4:23 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
+ath11k list, kalle
On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 27 | .auto_start = false,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 42 | .auto_start = false,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 57 | .auto_start = true,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 72 | .auto_start = true,
> | ^~~~~~~~~~
>
> Caused by commit
>
> 0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
>
The fixing patch [1] should've landed in ath-next. Kalle can you please
apply the patch on top of immutable branch?
Stephen, feel free to pick it up in the meantime.
Thanks,
Mani
[1] https://lore.kernel.org/netdev/1601369799-22328-1-git-send-email-kvalo@codeaurora.org/
> I have used the mhi tree from next-20201116 for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-11-17 4:23 ` Manivannan Sadhasivam
@ 2020-11-17 4:28 ` Manivannan Sadhasivam
2020-11-17 9:15 ` Kalle Valo
2020-11-18 4:39 ` Stephen Rothwell
1 sibling, 1 reply; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-17 4:28 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List,
kvalo, ath11k
On Tue, Nov 17, 2020 at 09:53:59AM +0530, Manivannan Sadhasivam wrote:
> +ath11k list, kalle
>
Oops... adding now
> On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 27 | .auto_start = false,
> > | ^~~~~~~~~~
> > drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 42 | .auto_start = false,
> > | ^~~~~~~~~~
> > drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 57 | .auto_start = true,
> > | ^~~~~~~~~~
> > drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 72 | .auto_start = true,
> > | ^~~~~~~~~~
> >
> > Caused by commit
> >
> > 0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
> >
>
> The fixing patch [1] should've landed in ath-next. Kalle can you please
> apply the patch on top of immutable branch?
>
> Stephen, feel free to pick it up in the meantime.
>
> Thanks,
> Mani
>
> [1] https://lore.kernel.org/netdev/1601369799-22328-1-git-send-email-kvalo@codeaurora.org/
>
>
> > I have used the mhi tree from next-20201116 for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-11-17 4:28 ` Manivannan Sadhasivam
@ 2020-11-17 9:15 ` Kalle Valo
0 siblings, 0 replies; 29+ messages in thread
From: Kalle Valo @ 2020-11-17 9:15 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Stephen Rothwell, Linux Next Mailing List, Loic Poulain,
Linux Kernel Mailing List, ath11k, linux-wireless
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> On Tue, Nov 17, 2020 at 09:53:59AM +0530, Manivannan Sadhasivam wrote:
>> +ath11k list, kalle
>>
>
> Oops... adding now
>
>> On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
>> > failed like this:
>> >
>> > drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 27 | .auto_start = false,
>> > | ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 42 | .auto_start = false,
>> > | ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 57 | .auto_start = true,
>> > | ^~~~~~~~~~
>> > drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
>> > mhi_channel_config' has no member named 'auto_start'
>> > 72 | .auto_start = true,
>> > | ^~~~~~~~~~
>> >
>> > Caused by commit
>> >
>> > 0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
>> >
>>
>> The fixing patch [1] should've landed in ath-next. Kalle can you please
>> apply the patch on top of immutable branch?
>>
>> Stephen, feel free to pick it up in the meantime.
I think this fix should be included in commit 0cc1f3a385b2 ("bus: mhi:
Remove auto-start option"), otherwise the build will always fail. I can
then pull this commmit from the MHI immutable branch to my ath.git tree
and from there it will go to wireless-drivers-next.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-11-17 4:23 ` Manivannan Sadhasivam
2020-11-17 4:28 ` Manivannan Sadhasivam
@ 2020-11-18 4:39 ` Stephen Rothwell
2020-11-18 4:45 ` Stephen Rothwell
1 sibling, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2020-11-18 4:39 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
Hi Manivannan,
On Tue, 17 Nov 2020 09:53:59 +0530 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>
> +ath11k list, kalle
>
> On Tue, Nov 17, 2020 at 03:12:25PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 27 | .auto_start = false,
> > | ^~~~~~~~~~
> > drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 42 | .auto_start = false,
> > | ^~~~~~~~~~
> > drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 57 | .auto_start = true,
> > | ^~~~~~~~~~
> > drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> > 72 | .auto_start = true,
> > | ^~~~~~~~~~
> >
> > Caused by commit
> >
> > 0cc1f3a385b2 ("bus: mhi: Remove auto-start option")
>
> The fixing patch [1] should've landed in ath-next. Kalle can you please
> apply the patch on top of immutable branch?
>
> Stephen, feel free to pick it up in the meantime.
Why isn't that "fix patch" in the mhi tree (with necessary Acked-bys)?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-11-18 4:39 ` Stephen Rothwell
@ 2020-11-18 4:45 ` Stephen Rothwell
2020-11-18 4:51 ` Stephen Rothwell
0 siblings, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2020-11-18 4:45 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
Hi all,
On Wed, 18 Nov 2020 15:39:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Why isn't that "fix patch" in the mhi tree (with necessary Acked-bys)?
Ignore that, I missed its appearance :-)
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-11-18 4:45 ` Stephen Rothwell
@ 2020-11-18 4:51 ` Stephen Rothwell
2020-11-18 5:06 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Stephen Rothwell @ 2020-11-18 4:51 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hi all,
On Wed, 18 Nov 2020 15:45:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 18 Nov 2020 15:39:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Why isn't that "fix patch" in the mhi tree (with necessary Acked-bys)?
>
> Ignore that, I missed its appearance :-)
Ignore that, my question stands (git confused me a lot :-().
I have applied the fix patch to the mhi tree merge today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-11-18 4:51 ` Stephen Rothwell
@ 2020-11-18 5:06 ` Manivannan Sadhasivam
2020-11-18 9:39 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-18 5:06 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
On Wed, Nov 18, 2020 at 03:51:28PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Wed, 18 Nov 2020 15:45:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Wed, 18 Nov 2020 15:39:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Why isn't that "fix patch" in the mhi tree (with necessary Acked-bys)?
> >
> > Ignore that, I missed its appearance :-)
>
> Ignore that, my question stands (git confused me a lot :-().
>
> I have applied the fix patch to the mhi tree merge today.
After discussing with Kalle, we decided to have a single patch which
changes MHI and ath11k (fix patch) to avoid issues. I'll send it today and
get it applied to mhi-next soon (via immutable branch).
Thanks,
Mani
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-11-18 5:06 ` Manivannan Sadhasivam
@ 2020-11-18 9:39 ` Manivannan Sadhasivam
2020-11-18 10:41 ` Stephen Rothwell
0 siblings, 1 reply; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-18 9:39 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Loic Poulain, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, Nov 18, 2020 at 10:36:40AM +0530, Manivannan Sadhasivam wrote:
> Hi Stephen,
>
> On Wed, Nov 18, 2020 at 03:51:28PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > On Wed, 18 Nov 2020 15:45:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Wed, 18 Nov 2020 15:39:12 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > Why isn't that "fix patch" in the mhi tree (with necessary Acked-bys)?
> > >
> > > Ignore that, I missed its appearance :-)
> >
> > Ignore that, my question stands (git confused me a lot :-().
> >
> > I have applied the fix patch to the mhi tree merge today.
>
> After discussing with Kalle, we decided to have a single patch which
> changes MHI and ath11k (fix patch) to avoid issues. I'll send it today and
> get it applied to mhi-next soon (via immutable branch).
>
Patch applied to immutable branch and merged into mhi-next. Now you can
remove the fix patch.
Thanks,
Mani
> Thanks,
> Mani
>
> > --
> > Cheers,
> > Stephen Rothwell
>
>
^ permalink raw reply [flat|nested] 29+ messages in thread
* linux-next: build failure after merge of the mhi tree
@ 2020-09-28 8:42 Stephen Rothwell
2020-09-28 9:10 ` Manivannan Sadhasivam
2020-09-29 15:35 ` Manivannan Sadhasivam
0 siblings, 2 replies; 29+ messages in thread
From: Stephen Rothwell @ 2020-09-28 8:42 UTC (permalink / raw)
To: Manivannan Sadhasivam, David Miller, Networking
Cc: Govind Singh, Kalle Valo, Loic Poulain, Linux Next Mailing List,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 2560 bytes --]
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
27 | .auto_start = false,
| ^~~~~~~~~~
drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
42 | .auto_start = false,
| ^~~~~~~~~~
drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
57 | .auto_start = true,
| ^~~~~~~~~~
drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
72 | .auto_start = true,
| ^~~~~~~~~~
Caused by commit
ed39d7816885 ("bus: mhi: Remove auto-start option")
interacting with commit
1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
from the net-next tree.
I applied the following merge fix patch, but maybe more is required.
Even if so, this could be fixed now in the net-next tree.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 28 Sep 2020 18:39:41 +1000
Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/net/wireless/ath/ath11k/mhi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
index aded9a719d51..47a1ce1bee4f 100644
--- a/drivers/net/wireless/ath/ath11k/mhi.c
+++ b/drivers/net/wireless/ath/ath11k/mhi.c
@@ -24,7 +24,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
.offload_channel = false,
.doorbell_mode_switch = false,
.auto_queue = false,
- .auto_start = false,
},
{
.num = 1,
@@ -39,7 +38,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
.offload_channel = false,
.doorbell_mode_switch = false,
.auto_queue = false,
- .auto_start = false,
},
{
.num = 20,
@@ -54,7 +52,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
.offload_channel = false,
.doorbell_mode_switch = false,
.auto_queue = false,
- .auto_start = true,
},
{
.num = 21,
@@ -69,7 +66,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
.offload_channel = false,
.doorbell_mode_switch = false,
.auto_queue = true,
- .auto_start = true,
},
};
--
2.28.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 8:42 Stephen Rothwell
@ 2020-09-28 9:10 ` Manivannan Sadhasivam
2020-09-28 9:28 ` Stephen Rothwell
2020-09-28 9:34 ` Kalle Valo
2020-09-29 15:35 ` Manivannan Sadhasivam
1 sibling, 2 replies; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-28 9:10 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Miller, Networking, Govind Singh, Kalle Valo, Loic Poulain,
Linux Next Mailing List, Linux Kernel Mailing List
Hi,
On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 27 | .auto_start = false,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 42 | .auto_start = false,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 57 | .auto_start = true,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 72 | .auto_start = true,
> | ^~~~~~~~~~
>
> Caused by commit
>
> ed39d7816885 ("bus: mhi: Remove auto-start option")
>
> interacting with commit
>
> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
>
> from the net-next tree.
>
> I applied the following merge fix patch, but maybe more is required.
> Even if so, this could be fixed now in the net-next tree.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 28 Sep 2020 18:39:41 +1000
> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Sorry, I forgot to submit a patch against net-next for fixing this while merging
the MHI change.
But your change looks good and I can just modify the subject/description and
resubmit. Or if Dave prefers to fix the original commit itself in net-next,
I'm fine!
Thanks,
Mani
> ---
> drivers/net/wireless/ath/ath11k/mhi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
> index aded9a719d51..47a1ce1bee4f 100644
> --- a/drivers/net/wireless/ath/ath11k/mhi.c
> +++ b/drivers/net/wireless/ath/ath11k/mhi.c
> @@ -24,7 +24,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = false,
> - .auto_start = false,
> },
> {
> .num = 1,
> @@ -39,7 +38,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = false,
> - .auto_start = false,
> },
> {
> .num = 20,
> @@ -54,7 +52,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = false,
> - .auto_start = true,
> },
> {
> .num = 21,
> @@ -69,7 +66,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = true,
> - .auto_start = true,
> },
> };
>
> --
> 2.28.0
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 9:10 ` Manivannan Sadhasivam
@ 2020-09-28 9:28 ` Stephen Rothwell
2020-09-28 9:34 ` Kalle Valo
1 sibling, 0 replies; 29+ messages in thread
From: Stephen Rothwell @ 2020-09-28 9:28 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: David Miller, Networking, Govind Singh, Kalle Valo, Loic Poulain,
Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
Hi Manivannan,
On Mon, 28 Sep 2020 14:40:35 +0530 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>
> But your change looks good and I can just modify the subject/description and
> resubmit. Or if Dave prefers to fix the original commit itself in net-next,
> I'm fine!
Dave never rebase the net-next tree, so a new fix patch is required.
Thanks for taking case of it.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 9:10 ` Manivannan Sadhasivam
2020-09-28 9:28 ` Stephen Rothwell
@ 2020-09-28 9:34 ` Kalle Valo
2020-09-28 9:47 ` Manivannan Sadhasivam
1 sibling, 1 reply; 29+ messages in thread
From: Kalle Valo @ 2020-09-28 9:34 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Stephen Rothwell, David Miller, Networking, Govind Singh,
Loic Poulain, Linux Next Mailing List, Linux Kernel Mailing List,
ath11k
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
>> mhi_channel_config' has no member named 'auto_start'
>> 27 | .auto_start = false,
>> | ^~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
>> mhi_channel_config' has no member named 'auto_start'
>> 42 | .auto_start = false,
>> | ^~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
>> mhi_channel_config' has no member named 'auto_start'
>> 57 | .auto_start = true,
>> | ^~~~~~~~~~
>> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
>> mhi_channel_config' has no member named 'auto_start'
>> 72 | .auto_start = true,
>> | ^~~~~~~~~~
>>
>> Caused by commit
>>
>> ed39d7816885 ("bus: mhi: Remove auto-start option")
>>
>> interacting with commit
>>
>> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
>>
>> from the net-next tree.
>>
>> I applied the following merge fix patch, but maybe more is required.
>> Even if so, this could be fixed now in the net-next tree.
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Mon, 28 Sep 2020 18:39:41 +1000
>> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Sorry, I forgot to submit a patch against net-next for fixing this while merging
> the MHI change.
Try to notify the ath11k list (CCed) whenever changing MHI API so that
we (ath11k folks) can be prepared for any major changes.
> But your change looks good and I can just modify the subject/description and
> resubmit. Or if Dave prefers to fix the original commit itself in net-next,
> I'm fine!
Actually I prefer to apply the fix to my ath.git tree, less conflicts
that way (I have still quite a lot of ath11k patches pending for -next).
I'll then send a pull request to Dave end of this week.
So please submit the patch like a normal ath11k patch documented here:
https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 9:34 ` Kalle Valo
@ 2020-09-28 9:47 ` Manivannan Sadhasivam
2020-09-28 16:45 ` Kalle Valo
0 siblings, 1 reply; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-28 9:47 UTC (permalink / raw)
To: Kalle Valo
Cc: Stephen Rothwell, David Miller, Networking, Govind Singh,
Loic Poulain, Linux Next Mailing List, Linux Kernel Mailing List,
ath11k
On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote:
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
>
> > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
> >> mhi_channel_config' has no member named 'auto_start'
> >> 27 | .auto_start = false,
> >> | ^~~~~~~~~~
> >> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
> >> mhi_channel_config' has no member named 'auto_start'
> >> 42 | .auto_start = false,
> >> | ^~~~~~~~~~
> >> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
> >> mhi_channel_config' has no member named 'auto_start'
> >> 57 | .auto_start = true,
> >> | ^~~~~~~~~~
> >> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
> >> mhi_channel_config' has no member named 'auto_start'
> >> 72 | .auto_start = true,
> >> | ^~~~~~~~~~
> >>
> >> Caused by commit
> >>
> >> ed39d7816885 ("bus: mhi: Remove auto-start option")
> >>
> >> interacting with commit
> >>
> >> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
> >>
> >> from the net-next tree.
> >>
> >> I applied the following merge fix patch, but maybe more is required.
> >> Even if so, this could be fixed now in the net-next tree.
> >>
> >> From: Stephen Rothwell <sfr@canb.auug.org.au>
> >> Date: Mon, 28 Sep 2020 18:39:41 +1000
> >> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
> >>
> >> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >
> > Sorry, I forgot to submit a patch against net-next for fixing this while merging
> > the MHI change.
>
> Try to notify the ath11k list (CCed) whenever changing MHI API so that
> we (ath11k folks) can be prepared for any major changes.
>
Okay sure, will do!
> > But your change looks good and I can just modify the subject/description and
> > resubmit. Or if Dave prefers to fix the original commit itself in net-next,
> > I'm fine!
>
> Actually I prefer to apply the fix to my ath.git tree, less conflicts
> that way (I have still quite a lot of ath11k patches pending for -next).
> I'll then send a pull request to Dave end of this week.
>
> So please submit the patch like a normal ath11k patch documented here:
>
Okay.
Thanks,
Mani
> https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 9:47 ` Manivannan Sadhasivam
@ 2020-09-28 16:45 ` Kalle Valo
2020-09-28 17:04 ` Manivannan Sadhasivam
0 siblings, 1 reply; 29+ messages in thread
From: Kalle Valo @ 2020-09-28 16:45 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Stephen Rothwell, Loic Poulain, Networking,
Linux Kernel Mailing List, ath11k, Linux Next Mailing List,
Govind Singh, David Miller
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote:
>> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
>>
>> > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
>> >> Hi all,
>> >>
>> >> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
>> >> failed like this:
>> >>
>> >> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
>> >> mhi_channel_config' has no member named 'auto_start'
>> >> 27 | .auto_start = false,
>> >> | ^~~~~~~~~~
>> >> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
>> >> mhi_channel_config' has no member named 'auto_start'
>> >> 42 | .auto_start = false,
>> >> | ^~~~~~~~~~
>> >> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
>> >> mhi_channel_config' has no member named 'auto_start'
>> >> 57 | .auto_start = true,
>> >> | ^~~~~~~~~~
>> >> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
>> >> mhi_channel_config' has no member named 'auto_start'
>> >> 72 | .auto_start = true,
>> >> | ^~~~~~~~~~
>> >>
>> >> Caused by commit
>> >>
>> >> ed39d7816885 ("bus: mhi: Remove auto-start option")
>> >>
>> >> interacting with commit
>> >>
>> >> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
>> >>
>> >> from the net-next tree.
>> >>
>> >> I applied the following merge fix patch, but maybe more is required.
>> >> Even if so, this could be fixed now in the net-next tree.
>> >>
>> >> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> >> Date: Mon, 28 Sep 2020 18:39:41 +1000
>> >> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
>> >>
>> >> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> >
>> > Sorry, I forgot to submit a patch against net-next for fixing this while merging
>> > the MHI change.
>>
>> Try to notify the ath11k list (CCed) whenever changing MHI API so that
>> we (ath11k folks) can be prepared for any major changes.
>>
>
> Okay sure, will do!
Thanks. It's important that ath11k is taken into account while making
changes to MHI, otherwise there can easily be regressions.
I was looking at commit ed39d7816885 ("bus: mhi: Remove auto-start
option") and noticed this in the commit log:
This is really up to the MHI device(channel) driver to manage the state
of its channels.
So does this mean we have to make changes in ath11k to accomodate this?
I haven't tested linux-next yet.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 16:45 ` Kalle Valo
@ 2020-09-28 17:04 ` Manivannan Sadhasivam
2020-09-29 6:18 ` Kalle Valo
0 siblings, 1 reply; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-28 17:04 UTC (permalink / raw)
To: Kalle Valo
Cc: Stephen Rothwell, Loic Poulain, Networking,
Linux Kernel Mailing List, ath11k, Linux Next Mailing List,
Govind Singh, David Miller
On Mon, Sep 28, 2020 at 07:45:37PM +0300, Kalle Valo wrote:
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
>
> > On Mon, Sep 28, 2020 at 12:34:40PM +0300, Kalle Valo wrote:
> >> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> >>
> >> > On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> >> >> Hi all,
> >> >>
> >> >> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> >> >> failed like this:
> >> >>
> >> >> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct
> >> >> mhi_channel_config' has no member named 'auto_start'
> >> >> 27 | .auto_start = false,
> >> >> | ^~~~~~~~~~
> >> >> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct
> >> >> mhi_channel_config' has no member named 'auto_start'
> >> >> 42 | .auto_start = false,
> >> >> | ^~~~~~~~~~
> >> >> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct
> >> >> mhi_channel_config' has no member named 'auto_start'
> >> >> 57 | .auto_start = true,
> >> >> | ^~~~~~~~~~
> >> >> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct
> >> >> mhi_channel_config' has no member named 'auto_start'
> >> >> 72 | .auto_start = true,
> >> >> | ^~~~~~~~~~
> >> >>
> >> >> Caused by commit
> >> >>
> >> >> ed39d7816885 ("bus: mhi: Remove auto-start option")
> >> >>
> >> >> interacting with commit
> >> >>
> >> >> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
> >> >>
> >> >> from the net-next tree.
> >> >>
> >> >> I applied the following merge fix patch, but maybe more is required.
> >> >> Even if so, this could be fixed now in the net-next tree.
> >> >>
> >> >> From: Stephen Rothwell <sfr@canb.auug.org.au>
> >> >> Date: Mon, 28 Sep 2020 18:39:41 +1000
> >> >> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
> >> >>
> >> >> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> >> >
> >> > Sorry, I forgot to submit a patch against net-next for fixing this while merging
> >> > the MHI change.
> >>
> >> Try to notify the ath11k list (CCed) whenever changing MHI API so that
> >> we (ath11k folks) can be prepared for any major changes.
> >>
> >
> > Okay sure, will do!
>
> Thanks. It's important that ath11k is taken into account while making
> changes to MHI, otherwise there can easily be regressions.
>
I completely agree. Actually I thought about holding that patch till next
release and making the ath11k change together but somehow I applied that
patch blindly, my bad :(
> I was looking at commit ed39d7816885 ("bus: mhi: Remove auto-start
> option") and noticed this in the commit log:
>
> This is really up to the MHI device(channel) driver to manage the state
> of its channels.
>
> So does this mean we have to make changes in ath11k to accomodate this?
Nope. The change is needed in the MHI client driver like qrtr which is already
taken care: https://lkml.org/lkml/2020/9/28/30
Will make sure to include ath11k list for any future API changes.
Thanks,
Mani
> I haven't tested linux-next yet.
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-09-28 8:42 Stephen Rothwell
2020-09-28 9:10 ` Manivannan Sadhasivam
@ 2020-09-29 15:35 ` Manivannan Sadhasivam
1 sibling, 0 replies; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-29 15:35 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Miller, Networking, Govind Singh, Kalle Valo, Loic Poulain,
Linux Next Mailing List, Linux Kernel Mailing List, ath11k
Hi,
On Mon, Sep 28, 2020 at 06:42:30PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/net/wireless/ath/ath11k/mhi.c:27:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 27 | .auto_start = false,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:42:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 42 | .auto_start = false,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:57:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 57 | .auto_start = true,
> | ^~~~~~~~~~
> drivers/net/wireless/ath/ath11k/mhi.c:72:4: error: 'struct mhi_channel_config' has no member named 'auto_start'
> 72 | .auto_start = true,
> | ^~~~~~~~~~
>
> Caused by commit
>
> ed39d7816885 ("bus: mhi: Remove auto-start option")
>
After having the discussion with Kalle, we decided to drop these offending
patches from mhi-next (reason is net-next will be broken without these patches).
So we'll deal with this in next merge window.
Thanks,
Mani
> interacting with commit
>
> 1399fb87ea3e ("ath11k: register MHI controller device for QCA6390")
>
> from the net-next tree.
>
> I applied the following merge fix patch, but maybe more is required.
> Even if so, this could be fixed now in the net-next tree.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 28 Sep 2020 18:39:41 +1000
> Subject: [PATCH] fix up for "ath11k: register MHI controller device for QCA6390"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/net/wireless/ath/ath11k/mhi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
> index aded9a719d51..47a1ce1bee4f 100644
> --- a/drivers/net/wireless/ath/ath11k/mhi.c
> +++ b/drivers/net/wireless/ath/ath11k/mhi.c
> @@ -24,7 +24,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = false,
> - .auto_start = false,
> },
> {
> .num = 1,
> @@ -39,7 +38,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = false,
> - .auto_start = false,
> },
> {
> .num = 20,
> @@ -54,7 +52,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = false,
> - .auto_start = true,
> },
> {
> .num = 21,
> @@ -69,7 +66,6 @@ static struct mhi_channel_config ath11k_mhi_channels[] = {
> .offload_channel = false,
> .doorbell_mode_switch = false,
> .auto_queue = true,
> - .auto_start = true,
> },
> };
>
> --
> 2.28.0
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread
* linux-next: build failure after merge of the mhi tree
@ 2020-08-19 3:48 Stephen Rothwell
2020-08-19 3:49 ` Stephen Rothwell
2020-08-19 4:04 ` Manivannan Sadhasivam
0 siblings, 2 replies; 29+ messages in thread
From: Stephen Rothwell @ 2020-08-19 3:48 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Bhaumik Bhatt, Jeffrey Hugo
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
Hi all,
After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
I am not sure which commit(s) caused this.
I have used the mhi tree from next-20200818 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-08-19 3:48 Stephen Rothwell
@ 2020-08-19 3:49 ` Stephen Rothwell
2020-08-19 4:04 ` Manivannan Sadhasivam
1 sibling, 0 replies; 29+ messages in thread
From: Stephen Rothwell @ 2020-08-19 3:49 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Bhaumik Bhatt, Jeffrey Hugo
[-- Attachment #1: Type: text/plain, Size: 6243 bytes --]
Hi all,
On Wed, 19 Aug 2020 13:48:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/main.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/pm.o
WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/boot.o
ERROR: modpost: "mhi_read_reg_field" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_state_str" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_read_reg" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_ee_str" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_write_reg_field" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_write_reg" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_get_exec_env" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_set_mhi_state" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_ready_state_transition" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "to_mhi_pm_state_str" [drivers/bus/mhi/core/boot.ko] undefined!
ERROR: modpost: "mhi_read_reg_field" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_deinit_free_irq" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_ring_er_db" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_state_str" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_read_reg" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_fw_load_handler" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_destroy_device" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_get_mhi_state" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_init_irq_setup" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_ring_cmd_db" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_deinit_dev_ctxt" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_init_mmio" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_write_reg_field" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_free_bhie_table" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_write_reg" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_write_db" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_ring_chan_db" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_get_exec_env" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_init_dev_ctxt" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "to_mhi_pm_state_str" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_create_devices" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "dev_state_tran_str" [drivers/bus/mhi/core/pm.ko] undefined!
ERROR: modpost: "mhi_tryset_pm_state" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_state_str" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_pm_m0_transition" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_pm_m3_transition" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_queue_state_transition" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_alloc_device" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_init_chan_ctxt" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_ee_str" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_deinit_chan_ctxt" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_pm_sys_err_handler" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_pm_m1_transition" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_bus_type" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "to_mhi_pm_state_str" [drivers/bus/mhi/core/main.ko] undefined!
ERROR: modpost: "mhi_read_reg_field" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_db_brstmode_disable" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_process_data_event_ring" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_db_brstmode" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_rddm_prepare" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_intvec_threaded_handler" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_debugfs_init" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_read_reg" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_process_ctrl_ev_ring" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_ev_task" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_map_single_use_bb" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_ctrl_ev_task" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_unmap_single_use_bb" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_prepare_channel" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_alloc_bhie_table" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_unmap_single_no_bb" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_write_reg_field" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_intvec_handler" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_free_bhie_table" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_debugfs_exit" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_write_reg" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_map_single_no_bb" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_reset_chan" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_pm_st_worker" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_create_debugfs" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_irq_handler" [drivers/bus/mhi/core/init.ko] undefined!
ERROR: modpost: "mhi_destroy_debugfs" [drivers/bus/mhi/core/init.ko] undefined!
> I am not sure which commit(s) caused this.
>
> I have used the mhi tree from next-20200818 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-08-19 3:48 Stephen Rothwell
2020-08-19 3:49 ` Stephen Rothwell
@ 2020-08-19 4:04 ` Manivannan Sadhasivam
2020-08-19 5:14 ` Stephen Rothwell
1 sibling, 1 reply; 29+ messages in thread
From: Manivannan Sadhasivam @ 2020-08-19 4:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Bhaumik Bhatt, Jeffrey Hugo
Hi Stephen,
On Wed, Aug 19, 2020 at 01:48:00PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
>
> I am not sure which commit(s) caused this.
>
Probably the below commit which built fine with gcc but failing with clang:
92ce39feb722 bus: mhi: core: Introduce debugfs entries for MHI
I've dropped this and also one dependent commit from mhi-next branch.
Bhaumik: Please fix the issue and resubmit debugfs and sysfs patches.
Thanks,
Mani
> I have used the mhi tree from next-20200818 for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: linux-next: build failure after merge of the mhi tree
2020-08-19 4:04 ` Manivannan Sadhasivam
@ 2020-08-19 5:14 ` Stephen Rothwell
0 siblings, 0 replies; 29+ messages in thread
From: Stephen Rothwell @ 2020-08-19 5:14 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Bhaumik Bhatt, Jeffrey Hugo
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
Hi all,
On Wed, 19 Aug 2020 09:34:55 +0530 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>
> On Wed, Aug 19, 2020 at 01:48:00PM +1000, Stephen Rothwell wrote:
> >
> > After merging the mhi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > I am not sure which commit(s) caused this.
>
> Probably the below commit which built fine with gcc but failing with clang:
In case it matters, I build with gcc ...
> 92ce39feb722 bus: mhi: core: Introduce debugfs entries for MHI
>
> I've dropped this and also one dependent commit from mhi-next branch.
We'll see tomorrow is that helps.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 29+ messages in thread
end of thread, other threads:[~2022-11-09 7:42 UTC | newest]
Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-09 4:16 linux-next: build failure after merge of the mhi tree Stephen Rothwell
2022-11-09 7:42 ` Manivannan Sadhasivam
-- strict thread matches above, loose matches on Subject: below --
2022-03-02 6:37 Stephen Rothwell
2022-03-02 6:48 ` Manivannan Sadhasivam
2021-08-09 9:38 Stephen Rothwell
2021-08-09 9:55 ` Manivannan Sadhasivam
2020-11-17 4:12 Stephen Rothwell
2020-11-17 4:23 ` Manivannan Sadhasivam
2020-11-17 4:28 ` Manivannan Sadhasivam
2020-11-17 9:15 ` Kalle Valo
2020-11-18 4:39 ` Stephen Rothwell
2020-11-18 4:45 ` Stephen Rothwell
2020-11-18 4:51 ` Stephen Rothwell
2020-11-18 5:06 ` Manivannan Sadhasivam
2020-11-18 9:39 ` Manivannan Sadhasivam
2020-11-18 10:41 ` Stephen Rothwell
2020-09-28 8:42 Stephen Rothwell
2020-09-28 9:10 ` Manivannan Sadhasivam
2020-09-28 9:28 ` Stephen Rothwell
2020-09-28 9:34 ` Kalle Valo
2020-09-28 9:47 ` Manivannan Sadhasivam
2020-09-28 16:45 ` Kalle Valo
2020-09-28 17:04 ` Manivannan Sadhasivam
2020-09-29 6:18 ` Kalle Valo
2020-09-29 15:35 ` Manivannan Sadhasivam
2020-08-19 3:48 Stephen Rothwell
2020-08-19 3:49 ` Stephen Rothwell
2020-08-19 4:04 ` Manivannan Sadhasivam
2020-08-19 5:14 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).