[PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[José Expósito]

Hi everyone,

About 3 months ago, Torge Matthies sent a patch fixing an issue with
his XP-Pen Star G640 [1].

His patch changes the IS_INPUT_APPLICATION() macro to accept
HID_DG_DIGITIZER. However, it looks like it is not being merged because
of the possible side effects that changing that macro could generate.

This patch aims to fix the same issue but using a more conservative
approach hoping that the bug can be fixed.

Torge, Alexander, could you test it and confirm that it fixes your
issues, please?

Thanks a lot in advance,
José Expósito

[1] https://lore.kernel.org/linux-input/20220804151832.30373-1-openglfreak@googlemail.com/

José Expósito (1):
  HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

 drivers/hid/hid-uclogic-core.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1

[PATCH 1/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[José Expósito]

Commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for
styluses") changed the usage used in UCLogic from "Pen" to "Digitizer".

However, the IS_INPUT_APPLICATION() macro evaluates to false for
HID_DG_DIGITIZER causing issues with the XP-Pen Star G640 tablet.

Add the HID_QUIRK_HIDINPUT_FORCE quirk to bypass the
IS_INPUT_APPLICATION() check.

Reported-by: Torge Matthies <openglfreak@googlemail.com>
Reported-by: Alexander Zhang <alex@alexyzhang.dev>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
 drivers/hid/hid-uclogic-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-uclogic-core.c b/drivers/hid/hid-uclogic-core.c
index 0fbc408c2607..7fa6fe04f1b2 100644
--- a/drivers/hid/hid-uclogic-core.c
+++ b/drivers/hid/hid-uclogic-core.c
@@ -192,6 +192,7 @@ static int uclogic_probe(struct hid_device *hdev,
 	 * than the pen, so use QUIRK_MULTI_INPUT for all tablets.
 	 */
 	hdev->quirks |= HID_QUIRK_MULTI_INPUT;
+	hdev->quirks |= HID_QUIRK_HIDINPUT_FORCE;
 
 	/* Allocate and assign driver data */
 	drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
-- 
2.25.1

Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[Alexander Zhang]

Hi José,

On 11/10/22 9:40 AM, José Expósito wrote:
> Hi everyone,
> 
> About 3 months ago, Torge Matthies sent a patch fixing an issue with
> his XP-Pen Star G640 [1].
> 
> His patch changes the IS_INPUT_APPLICATION() macro to accept
> HID_DG_DIGITIZER. However, it looks like it is not being merged because
> of the possible side effects that changing that macro could generate.
> 
> This patch aims to fix the same issue but using a more conservative
> approach hoping that the bug can be fixed.
> 
> Torge, Alexander, could you test it and confirm that it fixes your
> issues, please?

I tested the patch on commit 4bbf3422df78 and it fixes the issue.

Thank you,
Alexander Zhang

> Thanks a lot in advance,
> José Expósito
> 
> [1] https://lore.kernel.org/linux-input/20220804151832.30373-1-openglfreak@googlemail.com/
> 
> José Expósito (1):
>    HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk
> 
>   drivers/hid/hid-uclogic-core.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[Jiri Kosina]

On Thu, 10 Nov 2022, Alexander Zhang wrote:

> Hi José,
> 
> On 11/10/22 9:40 AM, José Expósito wrote:
> > Hi everyone,
> > 
> > About 3 months ago, Torge Matthies sent a patch fixing an issue with
> > his XP-Pen Star G640 [1].
> > 
> > His patch changes the IS_INPUT_APPLICATION() macro to accept
> > HID_DG_DIGITIZER. However, it looks like it is not being merged because
> > of the possible side effects that changing that macro could generate.
> > 
> > This patch aims to fix the same issue but using a more conservative
> > approach hoping that the bug can be fixed.
> > 
> > Torge, Alexander, could you test it and confirm that it fixes your
> > issues, please?
> 
> I tested the patch on commit 4bbf3422df78 and it fixes the issue.

I will add

	Tested-by: Alexander Zhang <alex@alexyzhang.dev>

to the commit; please speak up if you disagree.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[Alexander Zhang]

On 11/14/22 6:10 AM, Jiri Kosina wrote:
> On Thu, 10 Nov 2022, Alexander Zhang wrote:
> 
>> Hi José,
>>
>> On 11/10/22 9:40 AM, José Expósito wrote:
>>> Hi everyone,
>>>
>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with
>>> his XP-Pen Star G640 [1].
>>>
>>> His patch changes the IS_INPUT_APPLICATION() macro to accept
>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because
>>> of the possible side effects that changing that macro could generate.
>>>
>>> This patch aims to fix the same issue but using a more conservative
>>> approach hoping that the bug can be fixed.
>>>
>>> Torge, Alexander, could you test it and confirm that it fixes your
>>> issues, please?
>>
>> I tested the patch on commit 4bbf3422df78 and it fixes the issue.
> 
> I will add
> 
> 	Tested-by: Alexander Zhang <alex@alexyzhang.dev>
> 
> to the commit; please speak up if you disagree.

I'm not sure if you're still waiting for a response from me but I'm fine 
with that.

Thanks,
Alexander Zhang

Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[Alexander Zhang]

Hello,

On 11/19/22 11:01 PM, Alexander Zhang wrote:
> On 11/14/22 6:10 AM, Jiri Kosina wrote:
>> On Thu, 10 Nov 2022, Alexander Zhang wrote:
>>
>>> Hi José,
>>>
>>> On 11/10/22 9:40 AM, José Expósito wrote:
>>>> Hi everyone,
>>>>
>>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with
>>>> his XP-Pen Star G640 [1].
>>>>
>>>> His patch changes the IS_INPUT_APPLICATION() macro to accept
>>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because
>>>> of the possible side effects that changing that macro could generate.
>>>>
>>>> This patch aims to fix the same issue but using a more conservative
>>>> approach hoping that the bug can be fixed.
>>>>
>>>> Torge, Alexander, could you test it and confirm that it fixes your
>>>> issues, please?
>>>
>>> I tested the patch on commit 4bbf3422df78 and it fixes the issue.
>>
>> I will add
>>
>>     Tested-by: Alexander Zhang <alex@alexyzhang.dev>
>>
>> to the commit; please speak up if you disagree.
> 
> I'm not sure if you're still waiting for a response from me but I'm fine 
> with that.

Is there something preventing this patch from being merged? I'm not very 
familiar with the kernel development process.

Best,
Alexander Zhang

Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[José Expósito]

Hi Alexander,

On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote:
> Hello,
> 
> On 11/19/22 11:01 PM, Alexander Zhang wrote:
> > On 11/14/22 6:10 AM, Jiri Kosina wrote:
> > > On Thu, 10 Nov 2022, Alexander Zhang wrote:
> > > 
> > > > Hi José,
> > > > 
> > > > On 11/10/22 9:40 AM, José Expósito wrote:
> > > > > Hi everyone,
> > > > > 
> > > > > About 3 months ago, Torge Matthies sent a patch fixing an issue with
> > > > > his XP-Pen Star G640 [1].
> > > > > 
> > > > > His patch changes the IS_INPUT_APPLICATION() macro to accept
> > > > > HID_DG_DIGITIZER. However, it looks like it is not being merged because
> > > > > of the possible side effects that changing that macro could generate.
> > > > > 
> > > > > This patch aims to fix the same issue but using a more conservative
> > > > > approach hoping that the bug can be fixed.
> > > > > 
> > > > > Torge, Alexander, could you test it and confirm that it fixes your
> > > > > issues, please?
> > > > 
> > > > I tested the patch on commit 4bbf3422df78 and it fixes the issue.
> > > 
> > > I will add
> > > 
> > >     Tested-by: Alexander Zhang <alex@alexyzhang.dev>
> > > 
> > > to the commit; please speak up if you disagree.
> > 
> > I'm not sure if you're still waiting for a response from me but I'm fine
> > with that.
> 
> Is there something preventing this patch from being merged? I'm not very
> familiar with the kernel development process.

The patch is already applied in the for-next branch, you can find it here:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8

Jose

> Best,
> Alexander Zhang

Re: [PATCH 0/1] HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk

[Alexander Zhang]

On 12/7/22 3:09 AM, José Expósito wrote:
> Hi Alexander,
> 
> On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote:
>> Hello,
>>
>> On 11/19/22 11:01 PM, Alexander Zhang wrote:
>>> On 11/14/22 6:10 AM, Jiri Kosina wrote:
>>>> On Thu, 10 Nov 2022, Alexander Zhang wrote:
>>>>
>>>>> Hi José,
>>>>>
>>>>> On 11/10/22 9:40 AM, José Expósito wrote:
>>>>>> Hi everyone,
>>>>>>
>>>>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with
>>>>>> his XP-Pen Star G640 [1].
>>>>>>
>>>>>> His patch changes the IS_INPUT_APPLICATION() macro to accept
>>>>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because
>>>>>> of the possible side effects that changing that macro could generate.
>>>>>>
>>>>>> This patch aims to fix the same issue but using a more conservative
>>>>>> approach hoping that the bug can be fixed.
>>>>>>
>>>>>> Torge, Alexander, could you test it and confirm that it fixes your
>>>>>> issues, please?
>>>>>
>>>>> I tested the patch on commit 4bbf3422df78 and it fixes the issue.
>>>>
>>>> I will add
>>>>
>>>>      Tested-by: Alexander Zhang <alex@alexyzhang.dev>
>>>>
>>>> to the commit; please speak up if you disagree.
>>>
>>> I'm not sure if you're still waiting for a response from me but I'm fine
>>> with that.
>>
>> Is there something preventing this patch from being merged? I'm not very
>> familiar with the kernel development process.
> 
> The patch is already applied in the for-next branch, you can find it here:
> https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8

I see, thank you very much!

Best,
Alexander Zhang