* [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment
@ 2022-11-11 9:04 xu.xin.sc
2022-11-14 11:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: xu.xin.sc @ 2022-11-11 9:04 UTC (permalink / raw)
To: edumazet, davem
Cc: yoshfuji, dsahern, kuba, pabeni, netdev, linux-kernel, xu xin
From: xu xin <xu.xin16@zte.com.cn>
The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING",
it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it.
Signed-off-by: xu xin <xu.xin16@zte.com.cn>
---
net/ipv4/tcp_ipv4.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 7a250ef9d1b7..0180f3cefa9c 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2478,7 +2478,6 @@ static void *tcp_seek_last_pos(struct seq_file *seq)
case TCP_SEQ_STATE_LISTENING:
if (st->bucket > hinfo->lhash2_mask)
break;
- st->state = TCP_SEQ_STATE_LISTENING;
rc = listening_get_first(seq);
while (offset-- && rc && bucket == st->bucket)
rc = listening_get_next(seq, rc);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment
2022-11-11 9:04 [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment xu.xin.sc
@ 2022-11-14 11:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-14 11:30 UTC (permalink / raw)
To: xu xin
Cc: edumazet, davem, yoshfuji, dsahern, kuba, pabeni, netdev,
linux-kernel, xu.xin16
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 11 Nov 2022 09:04:20 +0000 you wrote:
> From: xu xin <xu.xin16@zte.com.cn>
>
> The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING",
> it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it.
>
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
>
> [...]
Here is the summary with links:
- [linux-next] ipasdv4/tcp_ipv4: remove redundant assignment
https://git.kernel.org/netdev/net-next/c/2fd450cd83e3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-14 11:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 9:04 [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment xu.xin.sc
2022-11-14 11:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).