linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: shrinkers: Add missing includes for undeclared types
@ 2022-11-14 23:59 T.J. Mercier
  0 siblings, 0 replies; only message in thread
From: T.J. Mercier @ 2022-11-14 23:59 UTC (permalink / raw)
  To: android-mm, Konstantin Khlebnikov, Andrew Morton, Dave Chinner, Al Viro
  Cc: T.J. Mercier, linux-kernel

The shrinker.h header depends on a user including other headers before
it for types used by shrinker.h. Fix this by including the appropriate
headers in shrinker.h.

./include/linux/shrinker.h:13:9: error: unknown type name ‘gfp_t’
   13 |         gfp_t gfp_mask;
      |         ^~~~~
./include/linux/shrinker.h:71:26: error: field ‘list’ has incomplete type
   71 |         struct list_head list;
      |                          ^~~~
./include/linux/shrinker.h:82:9: error: unknown type name ‘atomic_long_t’
   82 |         atomic_long_t *nr_deferred;
      |

Fixes: 83aeeada7c69 ("vmscan: use atomic-long for shrinker batching")
Fixes: b0d40c92adaf ("superblock: introduce per-sb cache shrinker infrastructure")
Signed-off-by: T.J. Mercier <tjmercier@google.com>
---
 include/linux/shrinker.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
index 08e6054e061f..71310efe2fab 100644
--- a/include/linux/shrinker.h
+++ b/include/linux/shrinker.h
@@ -2,6 +2,9 @@
 #ifndef _LINUX_SHRINKER_H
 #define _LINUX_SHRINKER_H
 
+#include <linux/atomic.h>
+#include <linux/types.h>
+
 /*
  * This struct is used to pass information from page reclaim to the shrinkers.
  * We consolidate the values for easier extension later.
-- 
2.38.1.493.g58b659f92b-goog


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-15  0:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 23:59 [PATCH] mm: shrinkers: Add missing includes for undeclared types T.J. Mercier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).