* [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
@ 2022-11-16 10:20 Johan Hovold
2022-11-16 10:20 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation Johan Hovold
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Johan Hovold @ 2022-11-16 10:20 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Douglas Anderson, Parikshit Pareek,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold
When reviewing a new devicetree for sa8540p-ride I noticed that the
indentation for the 'regulator-allowed-modes' properties was off and
realised that this had been copied from the recent patches adding the
missing modes properties.
Let's clean up the binding example and current devicetree sources to
avoid this pattern being reproduced further.
Note that the patches adding the missing properties have not yet made it
into 6.1-rc.
Johan
Johan Hovold (2):
regulator: dt-bindings: qcom,rpmh: clean up example indentation
arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
.../regulator/qcom,rpmh-regulator.yaml | 10 ++++------
arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 20 ++++++++-----------
arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 20 ++++++++-----------
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 ++++------
.../qcom/sm6350-sony-xperia-lena-pdx213.dts | 10 ++++------
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 10 ++++------
.../dts/qcom/sm8150-sony-xperia-kumano.dtsi | 10 ++++------
.../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 20 ++++++++-----------
9 files changed, 48 insertions(+), 72 deletions(-)
--
2.37.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation
2022-11-16 10:20 [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
@ 2022-11-16 10:20 ` Johan Hovold
2022-11-16 12:38 ` Krzysztof Kozlowski
2022-11-16 10:20 ` [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Johan Hovold @ 2022-11-16 10:20 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Douglas Anderson, Parikshit Pareek,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold
Remove a line break and increase indentation of the continuation line
to avoid having the 'regulator-allowed-modes' example be reproduced
verbatim with four-spaces indentation (instead of a tab, which is still
too little) in devicetree sources.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../bindings/regulator/qcom,rpmh-regulator.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index 90c3bda31c23..7ff51b558702 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -412,9 +412,8 @@ examples:
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
};
@@ -431,9 +430,8 @@ examples:
bob {
regulator-min-microvolt = <3312000>;
regulator-max-microvolt = <3600000>;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_AUTO
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_AUTO
+ RPMH_REGULATOR_MODE_HPM>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
};
};
--
2.37.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
2022-11-16 10:20 [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
2022-11-16 10:20 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation Johan Hovold
@ 2022-11-16 10:20 ` Johan Hovold
2022-11-16 10:43 ` Konrad Dybcio
2022-11-16 15:01 ` (subset) [PATCH 0/2] " Mark Brown
2022-12-06 18:18 ` Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Johan Hovold @ 2022-11-16 10:20 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Douglas Anderson, Parikshit Pareek,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold
When recently adding the missing 'regulator-allowed-modes' properties it
appears that the binding example with its four-spaces indentation
(corresponding to a single tab, which is still to little) was copied
verbatim.
Drop the unnecessary first line break after 'regulator-allowed-modes'
properties and indent the single remaining continuation line properly.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 20 ++++++++-----------
arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 20 ++++++++-----------
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 ++++------
.../qcom/sm6350-sony-xperia-lena-pdx213.dts | 10 ++++------
.../boot/dts/qcom/sm7225-fairphone-fp4.dts | 10 ++++------
.../dts/qcom/sm8150-sony-xperia-kumano.dtsi | 10 ++++------
.../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 20 ++++++++-----------
8 files changed, 44 insertions(+), 66 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index 01ac460d910e..952acfc04adc 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -136,9 +136,8 @@ vreg_l5a_0p88: ldo5 {
regulator-max-microvolt = <880000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7a_1p8: ldo7 {
@@ -154,9 +153,8 @@ vreg_l10a_2p96: ldo10 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l11a_0p8: ldo11 {
@@ -263,9 +261,8 @@ vreg_l5c_1p2: ldo5 {
regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7c_1p8: ldo7 {
@@ -281,9 +278,8 @@ vreg_l8c_1p2: ldo8 {
regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l10c_3p3: ldo10 {
diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
index 6c29d7d757e0..51805106f542 100644
--- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
@@ -90,9 +90,8 @@ vreg_l3c: ldo3 {
regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l4c: ldo4 {
@@ -108,9 +107,8 @@ vreg_l6c: ldo6 {
regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7c: ldo7 {
@@ -126,9 +124,8 @@ vreg_l10c: ldo10 {
regulator-max-microvolt = <2504000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l17c: ldo17 {
@@ -137,9 +134,8 @@ vreg_l17c: ldo17 {
regulator-max-microvolt = <2504000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index f09810e3d956..551768f97729 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -170,9 +170,8 @@ vreg_l7c: ldo7 {
regulator-max-microvolt = <2504000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l13c: ldo13 {
@@ -195,9 +194,8 @@ vreg_l3d: ldo3 {
regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l4d: ldo4 {
diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
index 20f35623d1ef..94f77d376662 100644
--- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
+++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
@@ -231,9 +231,8 @@ pm6150l_l6: ldo6 {
regulator-max-microvolt = <2950000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
@@ -254,9 +253,8 @@ pm6150l_l9: ldo9 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
index 1cb14051ab1b..c456e9594ea5 100644
--- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
+++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
@@ -282,9 +282,8 @@ vreg_l6e: ldo6 {
regulator-max-microvolt = <2950000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7e: ldo7 {
@@ -304,9 +303,8 @@ vreg_l9e: ldo9 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l10e: ldo10 {
diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
index fb6e5a140c9f..c958a8b16730 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
@@ -348,9 +348,8 @@ vreg_l6c_2p9: ldo6 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7c_3p0: ldo7 {
@@ -370,9 +369,8 @@ vreg_l9c_2p9: ldo9 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l10c_3p3: ldo10 {
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index 2a223ed50102..38746f248969 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -317,9 +317,8 @@ vreg_l6c_2p9: ldo6 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7c_2p85: ldo7 {
@@ -342,9 +341,8 @@ vreg_l9c_2p9: ldo9 {
regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l10c_3p3: ldo10 {
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index 69ae6503c2f6..26a608144886 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -107,9 +107,8 @@ vreg_l5b_0p88: ldo5 {
regulator-max-microvolt = <888000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l6b_1p2: ldo6 {
@@ -118,9 +117,8 @@ vreg_l6b_1p2: ldo6 {
regulator-max-microvolt = <1208000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l7b_2p96: ldo7 {
@@ -129,9 +127,8 @@ vreg_l7b_2p96: ldo7 {
regulator-max-microvolt = <2504000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
vreg_l9b_1p2: ldo9 {
@@ -140,9 +137,8 @@ vreg_l9b_1p2: ldo9 {
regulator-max-microvolt = <1200000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
regulator-allow-set-load;
- regulator-allowed-modes =
- <RPMH_REGULATOR_MODE_LPM
- RPMH_REGULATOR_MODE_HPM>;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
};
};
--
2.37.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
2022-11-16 10:20 ` [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
@ 2022-11-16 10:43 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2022-11-16 10:43 UTC (permalink / raw)
To: Johan Hovold, Mark Brown, Bjorn Andersson
Cc: Andy Gross, Liam Girdwood, Rob Herring, Krzysztof Kozlowski,
Douglas Anderson, Parikshit Pareek, linux-arm-msm, devicetree,
linux-kernel
On 16/11/2022 11:20, Johan Hovold wrote:
> When recently adding the missing 'regulator-allowed-modes' properties it
> appears that the binding example with its four-spaces indentation
> (corresponding to a single tab, which is still to little) was copied
> verbatim.
>
> Drop the unnecessary first line break after 'regulator-allowed-modes'
> properties and indent the single remaining continuation line properly.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 20 ++++++++-----------
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 20 ++++++++-----------
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 ++++------
> .../qcom/sm6350-sony-xperia-lena-pdx213.dts | 10 ++++------
> .../boot/dts/qcom/sm7225-fairphone-fp4.dts | 10 ++++------
> .../dts/qcom/sm8150-sony-xperia-kumano.dtsi | 10 ++++------
> .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 20 ++++++++-----------
> 8 files changed, 44 insertions(+), 66 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index 01ac460d910e..952acfc04adc 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -136,9 +136,8 @@ vreg_l5a_0p88: ldo5 {
> regulator-max-microvolt = <880000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7a_1p8: ldo7 {
> @@ -154,9 +153,8 @@ vreg_l10a_2p96: ldo10 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l11a_0p8: ldo11 {
> @@ -263,9 +261,8 @@ vreg_l5c_1p2: ldo5 {
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7c_1p8: ldo7 {
> @@ -281,9 +278,8 @@ vreg_l8c_1p2: ldo8 {
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l10c_3p3: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> index 6c29d7d757e0..51805106f542 100644
> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> @@ -90,9 +90,8 @@ vreg_l3c: ldo3 {
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l4c: ldo4 {
> @@ -108,9 +107,8 @@ vreg_l6c: ldo6 {
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7c: ldo7 {
> @@ -126,9 +124,8 @@ vreg_l10c: ldo10 {
> regulator-max-microvolt = <2504000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l17c: ldo17 {
> @@ -137,9 +134,8 @@ vreg_l17c: ldo17 {
> regulator-max-microvolt = <2504000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index f09810e3d956..551768f97729 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -170,9 +170,8 @@ vreg_l7c: ldo7 {
> regulator-max-microvolt = <2504000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l13c: ldo13 {
> @@ -195,9 +194,8 @@ vreg_l3d: ldo3 {
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l4d: ldo4 {
> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 20f35623d1ef..94f77d376662 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> @@ -231,9 +231,8 @@ pm6150l_l6: ldo6 {
> regulator-max-microvolt = <2950000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
>
> };
>
> @@ -254,9 +253,8 @@ pm6150l_l9: ldo9 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
>
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 1cb14051ab1b..c456e9594ea5 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -282,9 +282,8 @@ vreg_l6e: ldo6 {
> regulator-max-microvolt = <2950000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7e: ldo7 {
> @@ -304,9 +303,8 @@ vreg_l9e: ldo9 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l10e: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> index fb6e5a140c9f..c958a8b16730 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
> @@ -348,9 +348,8 @@ vreg_l6c_2p9: ldo6 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7c_3p0: ldo7 {
> @@ -370,9 +369,8 @@ vreg_l9c_2p9: ldo9 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l10c_3p3: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index 2a223ed50102..38746f248969 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -317,9 +317,8 @@ vreg_l6c_2p9: ldo6 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7c_2p85: ldo7 {
> @@ -342,9 +341,8 @@ vreg_l9c_2p9: ldo9 {
> regulator-max-microvolt = <2960000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l10c_3p3: ldo10 {
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index 69ae6503c2f6..26a608144886 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -107,9 +107,8 @@ vreg_l5b_0p88: ldo5 {
> regulator-max-microvolt = <888000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l6b_1p2: ldo6 {
> @@ -118,9 +117,8 @@ vreg_l6b_1p2: ldo6 {
> regulator-max-microvolt = <1208000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l7b_2p96: ldo7 {
> @@ -129,9 +127,8 @@ vreg_l7b_2p96: ldo7 {
> regulator-max-microvolt = <2504000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
>
> vreg_l9b_1p2: ldo9 {
> @@ -140,9 +137,8 @@ vreg_l9b_1p2: ldo9 {
> regulator-max-microvolt = <1200000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> regulator-allow-set-load;
> - regulator-allowed-modes =
> - <RPMH_REGULATOR_MODE_LPM
> - RPMH_REGULATOR_MODE_HPM>;
> + regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> + RPMH_REGULATOR_MODE_HPM>;
> };
> };
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation
2022-11-16 10:20 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation Johan Hovold
@ 2022-11-16 12:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-16 12:38 UTC (permalink / raw)
To: Johan Hovold, Mark Brown, Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Liam Girdwood, Rob Herring,
Krzysztof Kozlowski, Douglas Anderson, Parikshit Pareek,
linux-arm-msm, devicetree, linux-kernel
On 16/11/2022 11:20, Johan Hovold wrote:
> Remove a line break and increase indentation of the continuation line
> to avoid having the 'regulator-allowed-modes' example be reproduced
> verbatim with four-spaces indentation (instead of a tab, which is still
> too little) in devicetree sources.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
2022-11-16 10:20 [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
2022-11-16 10:20 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation Johan Hovold
2022-11-16 10:20 ` [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
@ 2022-11-16 15:01 ` Mark Brown
2022-12-06 18:18 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2022-11-16 15:01 UTC (permalink / raw)
To: Bjorn Andersson, Johan Hovold
Cc: linux-kernel, Douglas Anderson, devicetree, Liam Girdwood,
linux-arm-msm, Krzysztof Kozlowski, Rob Herring,
Parikshit Pareek, Konrad Dybcio, Andy Gross
On Wed, 16 Nov 2022 11:20:52 +0100, Johan Hovold wrote:
> When reviewing a new devicetree for sa8540p-ride I noticed that the
> indentation for the 'regulator-allowed-modes' properties was off and
> realised that this had been copied from the recent patches adding the
> missing modes properties.
>
> Let's clean up the binding example and current devicetree sources to
> avoid this pattern being reproduced further.
>
> [...]
Applied to
broonie/regulator.git for-next
Thanks!
[1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation
commit: b8dfb3bed5524589052dafa0e4d6c4e25ae11544
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
2022-11-16 10:20 [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
` (2 preceding siblings ...)
2022-11-16 15:01 ` (subset) [PATCH 0/2] " Mark Brown
@ 2022-12-06 18:18 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-12-06 18:18 UTC (permalink / raw)
To: broonie, johan+linaro
Cc: robh+dt, lgirdwood, krzysztof.kozlowski+dt, Douglas Anderson,
quic_ppareek, linux-arm-msm, linux-kernel, devicetree,
Andy Gross, konrad.dybcio
On Wed, 16 Nov 2022 11:20:52 +0100, Johan Hovold wrote:
> When reviewing a new devicetree for sa8540p-ride I noticed that the
> indentation for the 'regulator-allowed-modes' properties was off and
> realised that this had been copied from the recent patches adding the
> missing modes properties.
>
> Let's clean up the binding example and current devicetree sources to
> avoid this pattern being reproduced further.
>
> [...]
Applied, thanks!
[2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation
commit: 25f08f02f47d0f83f39308359bad06719ad9a55c
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-06 18:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 10:20 [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
2022-11-16 10:20 ` [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation Johan Hovold
2022-11-16 12:38 ` Krzysztof Kozlowski
2022-11-16 10:20 ` [PATCH 2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation Johan Hovold
2022-11-16 10:43 ` Konrad Dybcio
2022-11-16 15:01 ` (subset) [PATCH 0/2] " Mark Brown
2022-12-06 18:18 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).