* [PATCH v4 0/2] Add pinctrl support for QDU1000/QRU1000 SoCs
@ 2022-11-18 18:20 Melody Olvera
2022-11-18 18:20 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl Melody Olvera
2022-11-18 18:20 ` [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver Melody Olvera
0 siblings, 2 replies; 11+ messages in thread
From: Melody Olvera @ 2022-11-18 18:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel, Melody Olvera
This patchset adds pinctrl support for the Qualcomm QDU1000 and QRU1000
SoCs.
The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
1000 are new SoCs meant for enabling Open RAN solutions. See more at
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
Changes from v3:
- Revised commit messages and dt-bindings
Changes from v2:
- Revised dt-bindings
- Added extra depends on for Kconfig
Melody Olvera (2):
dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver
.../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++
drivers/pinctrl/qcom/Kconfig | 10 +
drivers/pinctrl/qcom/Makefile | 1 +
drivers/pinctrl/qcom/pinctrl-qdu1000.c | 1273 +++++++++++++++++
4 files changed, 1418 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
create mode 100644 drivers/pinctrl/qcom/pinctrl-qdu1000.c
base-commit: 147307c69ba4441ee90c1f8ce8edf5df4ea60f67
--
2.38.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-18 18:20 [PATCH v4 0/2] Add pinctrl support for QDU1000/QRU1000 SoCs Melody Olvera
@ 2022-11-18 18:20 ` Melody Olvera
2022-11-20 10:58 ` Krzysztof Kozlowski
2022-11-18 18:20 ` [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver Melody Olvera
1 sibling, 1 reply; 11+ messages in thread
From: Melody Olvera @ 2022-11-18 18:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel, Melody Olvera
Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
.../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
1 file changed, 134 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
new file mode 100644
index 000000000000..cb0c496d8666
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
@@ -0,0 +1,134 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
+
+maintainers:
+ - Melody Olvera <quic_molvera@quicinc.com>
+
+description: |
+ This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
+ QRU1000 platforms.
+
+allOf:
+ - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,qdu1000-tlmm
+
+ reg:
+ maxItems: 1
+
+ interrupts: true
+ interrupt-controller: true
+ "#interrupt-cells": true
+ gpio-controller: true
+
+ gpio-reserved-ranges:
+ minItems: 1
+ maxItems: 75
+
+ gpio-line-names:
+ maxItems: 151
+
+ "#gpio-cells": true
+ gpio-ranges: true
+ wakeup-parent: true
+
+patternProperties:
+ "-state$":
+ oneOf:
+ - $ref: "#/$defs/qcom-qdu1000-tlmm-state"
+ - patternProperties:
+ "-pins$":
+ $ref: "#/$defs/qcom-qdu1000-tlmm-state"
+ additionalProperties: false
+
+$defs:
+ qcom-qdu1000-tlmm-state:
+ type: object
+ description:
+ Pinctrl node's client devices use subnodes for desired pin configuration.
+ Client device subnodes use below standard properties.
+ $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
+
+ properties:
+ pins:
+ description:
+ List of gpio pins affected by the properties specified in this
+ subnode.
+ items:
+ oneOf:
+ - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|150)$"
+ - enum: [ sdc1_rclk, sdc1_clk, sdc1_cmd, sdc1_data ]
+ minItems: 1
+ maxItems: 36
+
+ function:
+ description:
+ Specify the alternative function to be configured for the specified
+ pins.
+ enum: [ atest_char, atest_usb, char_exec, CMO_PRI, cmu_rng,
+ dbg_out_clk, ddr_bist, ddr_pxi1, ddr_pxi2, ddr_pxi3, ddr_pxi4,
+ ddr_pxi5, ddr_pxi6, ddr_pxi7, eth012_int_n, eth345_int_n,
+ gcc_gp1, gcc_gp2, gcc_gp3, gpio, gps_pps_in, hardsync_pps_in,
+ intr_c, jitter_bist_ref, pcie_clkreqn, phase_flag, pll_bist,
+ pll_clk, prng_rosc, qdss_cti, qdss_gpio, qlink0_enable,
+ qlink0_request, qlink0_wmss, qlink1_enable, qlink1_request,
+ qlink1_wmss, qlink2_enable, qlink2_request, qlink2_wmss,
+ qlink3_enable, qlink3_request, qlink3_wmss, qlink4_enable,
+ qlink4_request, qlink4_wmss, qlink5_enable, qlink5_request,
+ qlink5_wmss, qlink6_enable, qlink6_request, qlink6_wmss,
+ qlink7_enable, qlink7_request, qlink7_wmss, qspi_clk, qspi_cs,
+ qspi0, qspi1, qspi2, qspi3, qup00, qup01, qup02, qup03, qup04,
+ qup05, qup06, qup07, qup08, qup10, qup11, qup12, qup13, qup14,
+ qup15, qup16, qup17, qup20, qup21, qup22, SI5518_INT, smb_alert,
+ smb_clk, smb_dat, tb_trig, tgu_ch0, tgu_ch1, tgu_ch2, tgu_ch3,
+ tgu_ch4, tgu_ch5, tgu_ch6, tgu_ch7, tmess_prng0, tmess_prng1,
+ tmess_prng2, tmess_prng3, tod_pps_in, tsense_pwm1, tsense_pwm2,
+ usb2phy_ac, usb_con_det, usb_dfp_en, usb_phy, vfr_0, vfr_1,
+ vsense_trigger ]
+
+ bias-disable: true
+ bias-pull-down: true
+ bias-pull-up: true
+ drive-strength: true
+ input-enable: true
+ output-high: true
+ output-low: true
+
+ required:
+ - pins
+
+ additionalProperties: false
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ pinctrl@f000000 {
+ compatible = "qcom,qdu1000-tlmm";
+ reg = <0xf000000 0x1000000>;
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 151>;
+ wakeup-parent = <&pdc>;
+
+ uart0-default-state {
+ pins = "gpio6", "gpio7", "gpio8", "gpio9";
+ function = "qup00";
+ };
+ };
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver
2022-11-18 18:20 [PATCH v4 0/2] Add pinctrl support for QDU1000/QRU1000 SoCs Melody Olvera
2022-11-18 18:20 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl Melody Olvera
@ 2022-11-18 18:20 ` Melody Olvera
2022-11-21 11:09 ` Konrad Dybcio
1 sibling, 1 reply; 11+ messages in thread
From: Melody Olvera @ 2022-11-18 18:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel, Melody Olvera
Add pin control driver for the TLMM block found in the QDU1000
and QRU1000 SoC.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
drivers/pinctrl/qcom/Kconfig | 10 +
drivers/pinctrl/qcom/Makefile | 1 +
drivers/pinctrl/qcom/pinctrl-qdu1000.c | 1273 ++++++++++++++++++++++++
3 files changed, 1284 insertions(+)
create mode 100644 drivers/pinctrl/qcom/pinctrl-qdu1000.c
diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
index 1378ddca084f..9ff4145646a3 100644
--- a/drivers/pinctrl/qcom/Kconfig
+++ b/drivers/pinctrl/qcom/Kconfig
@@ -248,6 +248,16 @@ config PINCTRL_QCOM_SSBI_PMIC
which are using SSBI for communication with SoC. Example PMIC's
devices are pm8058 and pm8921.
+config PINCTRL_QDU1000
+ tristate "Qualcomm Tehcnologies Inc QDU1000/QRU1000 pin controller driver"
+ depends on GPIOLIB && OF
+ depends on ARM64 || COMPILE_TEST
+ depends on PINCTRL_MSM
+ help
+ This is the pinctrl, pinmux, pinconf, and gpiolib driver for the
+ Qualcomm Technologies Inc TLMM block found on the Qualcomm
+ Technologies Inc QDU1000 and QRU1000 platforms.
+
config PINCTRL_SC7180
tristate "Qualcomm Technologies Inc SC7180 pin controller driver"
depends on OF
diff --git a/drivers/pinctrl/qcom/Makefile b/drivers/pinctrl/qcom/Makefile
index a5c40f552e5c..aca888bc7865 100644
--- a/drivers/pinctrl/qcom/Makefile
+++ b/drivers/pinctrl/qcom/Makefile
@@ -27,6 +27,7 @@ obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-gpio.o
obj-$(CONFIG_PINCTRL_QCOM_SPMI_PMIC) += pinctrl-spmi-mpp.o
obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-gpio.o
obj-$(CONFIG_PINCTRL_QCOM_SSBI_PMIC) += pinctrl-ssbi-mpp.o
+obj-$(CONFIG_PINCTRL_QDU1000) += pinctrl-qdu1000.o
obj-$(CONFIG_PINCTRL_SC7180) += pinctrl-sc7180.o
obj-$(CONFIG_PINCTRL_SC7280) += pinctrl-sc7280.o
obj-$(CONFIG_PINCTRL_SC7280_LPASS_LPI) += pinctrl-sc7280-lpass-lpi.o
diff --git a/drivers/pinctrl/qcom/pinctrl-qdu1000.c b/drivers/pinctrl/qcom/pinctrl-qdu1000.c
new file mode 100644
index 000000000000..ce5e4d53d316
--- /dev/null
+++ b/drivers/pinctrl/qcom/pinctrl-qdu1000.c
@@ -0,0 +1,1273 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pinctrl/pinctrl.h>
+
+#include "pinctrl-msm.h"
+
+#define FUNCTION(fname) \
+ [msm_mux_##fname] = { \
+ .name = #fname, \
+ .groups = fname##_groups, \
+ .ngroups = ARRAY_SIZE(fname##_groups), \
+ }
+
+#define REG_BASE 0x100000
+#define REG_SIZE 0x1000
+#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9) \
+ { \
+ .name = "gpio" #id, \
+ .pins = gpio##id##_pins, \
+ .npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins), \
+ .funcs = (int[]){ \
+ msm_mux_gpio, /* gpio mode */ \
+ msm_mux_##f1, \
+ msm_mux_##f2, \
+ msm_mux_##f3, \
+ msm_mux_##f4, \
+ msm_mux_##f5, \
+ msm_mux_##f6, \
+ msm_mux_##f7, \
+ msm_mux_##f8, \
+ msm_mux_##f9 \
+ }, \
+ .nfuncs = 10, \
+ .ctl_reg = REG_BASE + REG_SIZE * id, \
+ .io_reg = REG_BASE + 0x4 + REG_SIZE * id, \
+ .intr_cfg_reg = REG_BASE + 0x8 + REG_SIZE * id, \
+ .intr_status_reg = REG_BASE + 0xc + REG_SIZE * id, \
+ .intr_target_reg = REG_BASE + 0x8 + REG_SIZE * id, \
+ .mux_bit = 2, \
+ .pull_bit = 0, \
+ .drv_bit = 6, \
+ .oe_bit = 9, \
+ .in_bit = 0, \
+ .out_bit = 1, \
+ .intr_enable_bit = 0, \
+ .intr_status_bit = 0, \
+ .intr_target_bit = 5, \
+ .intr_target_kpss_val = 3, \
+ .intr_raw_status_bit = 4, \
+ .intr_polarity_bit = 1, \
+ .intr_detection_bit = 2, \
+ .intr_detection_width = 2, \
+ }
+
+#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv) \
+ { \
+ .name = #pg_name, \
+ .pins = pg_name##_pins, \
+ .npins = (unsigned int)ARRAY_SIZE(pg_name##_pins), \
+ .ctl_reg = REG_BASE + ctl, \
+ .io_reg = 0, \
+ .intr_cfg_reg = 0, \
+ .intr_status_reg = 0, \
+ .intr_target_reg = 0, \
+ .mux_bit = -1, \
+ .pull_bit = pull, \
+ .drv_bit = drv, \
+ .oe_bit = -1, \
+ .in_bit = -1, \
+ .out_bit = -1, \
+ .intr_enable_bit = -1, \
+ .intr_status_bit = -1, \
+ .intr_target_bit = -1, \
+ .intr_raw_status_bit = -1, \
+ .intr_polarity_bit = -1, \
+ .intr_detection_bit = -1, \
+ .intr_detection_width = -1, \
+ }
+
+#define UFS_RESET(pg_name, offset) \
+ { \
+ .name = #pg_name, \
+ .pins = pg_name##_pins, \
+ .npins = (unsigned int)ARRAY_SIZE(pg_name##_pins), \
+ .ctl_reg = offset, \
+ .io_reg = offset + 0x4, \
+ .intr_cfg_reg = 0, \
+ .intr_status_reg = 0, \
+ .intr_target_reg = 0, \
+ .mux_bit = -1, \
+ .pull_bit = 3, \
+ .drv_bit = 0, \
+ .oe_bit = -1, \
+ .in_bit = -1, \
+ .out_bit = 0, \
+ .intr_enable_bit = -1, \
+ .intr_status_bit = -1, \
+ .intr_target_bit = -1, \
+ .intr_raw_status_bit = -1, \
+ .intr_polarity_bit = -1, \
+ .intr_detection_bit = -1, \
+ .intr_detection_width = -1, \
+ }
+
+#define QUP_I3C(qup_mode, qup_offset) \
+ { \
+ .mode = qup_mode, \
+ .offset = qup_offset, \
+ }
+
+static const struct pinctrl_pin_desc qdu1000_pins[] = {
+ PINCTRL_PIN(0, "GPIO_0"),
+ PINCTRL_PIN(1, "GPIO_1"),
+ PINCTRL_PIN(2, "GPIO_2"),
+ PINCTRL_PIN(3, "GPIO_3"),
+ PINCTRL_PIN(4, "GPIO_4"),
+ PINCTRL_PIN(5, "GPIO_5"),
+ PINCTRL_PIN(6, "GPIO_6"),
+ PINCTRL_PIN(7, "GPIO_7"),
+ PINCTRL_PIN(8, "GPIO_8"),
+ PINCTRL_PIN(9, "GPIO_9"),
+ PINCTRL_PIN(10, "GPIO_10"),
+ PINCTRL_PIN(11, "GPIO_11"),
+ PINCTRL_PIN(12, "GPIO_12"),
+ PINCTRL_PIN(13, "GPIO_13"),
+ PINCTRL_PIN(14, "GPIO_14"),
+ PINCTRL_PIN(15, "GPIO_15"),
+ PINCTRL_PIN(16, "GPIO_16"),
+ PINCTRL_PIN(17, "GPIO_17"),
+ PINCTRL_PIN(18, "GPIO_18"),
+ PINCTRL_PIN(19, "GPIO_19"),
+ PINCTRL_PIN(20, "GPIO_20"),
+ PINCTRL_PIN(21, "GPIO_21"),
+ PINCTRL_PIN(22, "GPIO_22"),
+ PINCTRL_PIN(23, "GPIO_23"),
+ PINCTRL_PIN(24, "GPIO_24"),
+ PINCTRL_PIN(25, "GPIO_25"),
+ PINCTRL_PIN(26, "GPIO_26"),
+ PINCTRL_PIN(27, "GPIO_27"),
+ PINCTRL_PIN(28, "GPIO_28"),
+ PINCTRL_PIN(29, "GPIO_29"),
+ PINCTRL_PIN(30, "GPIO_30"),
+ PINCTRL_PIN(31, "GPIO_31"),
+ PINCTRL_PIN(32, "GPIO_32"),
+ PINCTRL_PIN(33, "GPIO_33"),
+ PINCTRL_PIN(34, "GPIO_34"),
+ PINCTRL_PIN(35, "GPIO_35"),
+ PINCTRL_PIN(36, "GPIO_36"),
+ PINCTRL_PIN(37, "GPIO_37"),
+ PINCTRL_PIN(38, "GPIO_38"),
+ PINCTRL_PIN(39, "GPIO_39"),
+ PINCTRL_PIN(40, "GPIO_40"),
+ PINCTRL_PIN(41, "GPIO_41"),
+ PINCTRL_PIN(42, "GPIO_42"),
+ PINCTRL_PIN(43, "GPIO_43"),
+ PINCTRL_PIN(44, "GPIO_44"),
+ PINCTRL_PIN(45, "GPIO_45"),
+ PINCTRL_PIN(46, "GPIO_46"),
+ PINCTRL_PIN(47, "GPIO_47"),
+ PINCTRL_PIN(48, "GPIO_48"),
+ PINCTRL_PIN(49, "GPIO_49"),
+ PINCTRL_PIN(50, "GPIO_50"),
+ PINCTRL_PIN(51, "GPIO_51"),
+ PINCTRL_PIN(52, "GPIO_52"),
+ PINCTRL_PIN(53, "GPIO_53"),
+ PINCTRL_PIN(54, "GPIO_54"),
+ PINCTRL_PIN(55, "GPIO_55"),
+ PINCTRL_PIN(56, "GPIO_56"),
+ PINCTRL_PIN(57, "GPIO_57"),
+ PINCTRL_PIN(58, "GPIO_58"),
+ PINCTRL_PIN(59, "GPIO_59"),
+ PINCTRL_PIN(60, "GPIO_60"),
+ PINCTRL_PIN(61, "GPIO_61"),
+ PINCTRL_PIN(62, "GPIO_62"),
+ PINCTRL_PIN(63, "GPIO_63"),
+ PINCTRL_PIN(64, "GPIO_64"),
+ PINCTRL_PIN(65, "GPIO_65"),
+ PINCTRL_PIN(66, "GPIO_66"),
+ PINCTRL_PIN(67, "GPIO_67"),
+ PINCTRL_PIN(68, "GPIO_68"),
+ PINCTRL_PIN(69, "GPIO_69"),
+ PINCTRL_PIN(70, "GPIO_70"),
+ PINCTRL_PIN(71, "GPIO_71"),
+ PINCTRL_PIN(72, "GPIO_72"),
+ PINCTRL_PIN(73, "GPIO_73"),
+ PINCTRL_PIN(74, "GPIO_74"),
+ PINCTRL_PIN(75, "GPIO_75"),
+ PINCTRL_PIN(76, "GPIO_76"),
+ PINCTRL_PIN(77, "GPIO_77"),
+ PINCTRL_PIN(78, "GPIO_78"),
+ PINCTRL_PIN(79, "GPIO_79"),
+ PINCTRL_PIN(80, "GPIO_80"),
+ PINCTRL_PIN(81, "GPIO_81"),
+ PINCTRL_PIN(82, "GPIO_82"),
+ PINCTRL_PIN(83, "GPIO_83"),
+ PINCTRL_PIN(84, "GPIO_84"),
+ PINCTRL_PIN(85, "GPIO_85"),
+ PINCTRL_PIN(86, "GPIO_86"),
+ PINCTRL_PIN(87, "GPIO_87"),
+ PINCTRL_PIN(88, "GPIO_88"),
+ PINCTRL_PIN(89, "GPIO_89"),
+ PINCTRL_PIN(90, "GPIO_90"),
+ PINCTRL_PIN(91, "GPIO_91"),
+ PINCTRL_PIN(92, "GPIO_92"),
+ PINCTRL_PIN(93, "GPIO_93"),
+ PINCTRL_PIN(94, "GPIO_94"),
+ PINCTRL_PIN(95, "GPIO_95"),
+ PINCTRL_PIN(96, "GPIO_96"),
+ PINCTRL_PIN(97, "GPIO_97"),
+ PINCTRL_PIN(98, "GPIO_98"),
+ PINCTRL_PIN(99, "GPIO_99"),
+ PINCTRL_PIN(100, "GPIO_100"),
+ PINCTRL_PIN(101, "GPIO_101"),
+ PINCTRL_PIN(102, "GPIO_102"),
+ PINCTRL_PIN(103, "GPIO_103"),
+ PINCTRL_PIN(104, "GPIO_104"),
+ PINCTRL_PIN(105, "GPIO_105"),
+ PINCTRL_PIN(106, "GPIO_106"),
+ PINCTRL_PIN(107, "GPIO_107"),
+ PINCTRL_PIN(108, "GPIO_108"),
+ PINCTRL_PIN(109, "GPIO_109"),
+ PINCTRL_PIN(110, "GPIO_110"),
+ PINCTRL_PIN(111, "GPIO_111"),
+ PINCTRL_PIN(112, "GPIO_112"),
+ PINCTRL_PIN(113, "GPIO_113"),
+ PINCTRL_PIN(114, "GPIO_114"),
+ PINCTRL_PIN(115, "GPIO_115"),
+ PINCTRL_PIN(116, "GPIO_116"),
+ PINCTRL_PIN(117, "GPIO_117"),
+ PINCTRL_PIN(118, "GPIO_118"),
+ PINCTRL_PIN(119, "GPIO_119"),
+ PINCTRL_PIN(120, "GPIO_120"),
+ PINCTRL_PIN(121, "GPIO_121"),
+ PINCTRL_PIN(122, "GPIO_122"),
+ PINCTRL_PIN(123, "GPIO_123"),
+ PINCTRL_PIN(124, "GPIO_124"),
+ PINCTRL_PIN(125, "GPIO_125"),
+ PINCTRL_PIN(126, "GPIO_126"),
+ PINCTRL_PIN(127, "GPIO_127"),
+ PINCTRL_PIN(128, "GPIO_128"),
+ PINCTRL_PIN(129, "GPIO_129"),
+ PINCTRL_PIN(130, "GPIO_130"),
+ PINCTRL_PIN(131, "GPIO_131"),
+ PINCTRL_PIN(132, "GPIO_132"),
+ PINCTRL_PIN(133, "GPIO_133"),
+ PINCTRL_PIN(134, "GPIO_134"),
+ PINCTRL_PIN(135, "GPIO_135"),
+ PINCTRL_PIN(136, "GPIO_136"),
+ PINCTRL_PIN(137, "GPIO_137"),
+ PINCTRL_PIN(138, "GPIO_138"),
+ PINCTRL_PIN(139, "GPIO_139"),
+ PINCTRL_PIN(140, "GPIO_140"),
+ PINCTRL_PIN(141, "GPIO_141"),
+ PINCTRL_PIN(142, "GPIO_142"),
+ PINCTRL_PIN(143, "GPIO_143"),
+ PINCTRL_PIN(144, "GPIO_144"),
+ PINCTRL_PIN(145, "GPIO_145"),
+ PINCTRL_PIN(146, "GPIO_146"),
+ PINCTRL_PIN(147, "GPIO_147"),
+ PINCTRL_PIN(148, "GPIO_148"),
+ PINCTRL_PIN(149, "GPIO_149"),
+ PINCTRL_PIN(150, "GPIO_150"),
+ PINCTRL_PIN(151, "SDC1_RCLK"),
+ PINCTRL_PIN(152, "SDC1_CLK"),
+ PINCTRL_PIN(153, "SDC1_CMD"),
+ PINCTRL_PIN(154, "SDC1_DATA"),
+};
+
+#define DECLARE_MSM_GPIO_PINS(pin) \
+ static const unsigned int gpio##pin##_pins[] = { pin }
+DECLARE_MSM_GPIO_PINS(0);
+DECLARE_MSM_GPIO_PINS(1);
+DECLARE_MSM_GPIO_PINS(2);
+DECLARE_MSM_GPIO_PINS(3);
+DECLARE_MSM_GPIO_PINS(4);
+DECLARE_MSM_GPIO_PINS(5);
+DECLARE_MSM_GPIO_PINS(6);
+DECLARE_MSM_GPIO_PINS(7);
+DECLARE_MSM_GPIO_PINS(8);
+DECLARE_MSM_GPIO_PINS(9);
+DECLARE_MSM_GPIO_PINS(10);
+DECLARE_MSM_GPIO_PINS(11);
+DECLARE_MSM_GPIO_PINS(12);
+DECLARE_MSM_GPIO_PINS(13);
+DECLARE_MSM_GPIO_PINS(14);
+DECLARE_MSM_GPIO_PINS(15);
+DECLARE_MSM_GPIO_PINS(16);
+DECLARE_MSM_GPIO_PINS(17);
+DECLARE_MSM_GPIO_PINS(18);
+DECLARE_MSM_GPIO_PINS(19);
+DECLARE_MSM_GPIO_PINS(20);
+DECLARE_MSM_GPIO_PINS(21);
+DECLARE_MSM_GPIO_PINS(22);
+DECLARE_MSM_GPIO_PINS(23);
+DECLARE_MSM_GPIO_PINS(24);
+DECLARE_MSM_GPIO_PINS(25);
+DECLARE_MSM_GPIO_PINS(26);
+DECLARE_MSM_GPIO_PINS(27);
+DECLARE_MSM_GPIO_PINS(28);
+DECLARE_MSM_GPIO_PINS(29);
+DECLARE_MSM_GPIO_PINS(30);
+DECLARE_MSM_GPIO_PINS(31);
+DECLARE_MSM_GPIO_PINS(32);
+DECLARE_MSM_GPIO_PINS(33);
+DECLARE_MSM_GPIO_PINS(34);
+DECLARE_MSM_GPIO_PINS(35);
+DECLARE_MSM_GPIO_PINS(36);
+DECLARE_MSM_GPIO_PINS(37);
+DECLARE_MSM_GPIO_PINS(38);
+DECLARE_MSM_GPIO_PINS(39);
+DECLARE_MSM_GPIO_PINS(40);
+DECLARE_MSM_GPIO_PINS(41);
+DECLARE_MSM_GPIO_PINS(42);
+DECLARE_MSM_GPIO_PINS(43);
+DECLARE_MSM_GPIO_PINS(44);
+DECLARE_MSM_GPIO_PINS(45);
+DECLARE_MSM_GPIO_PINS(46);
+DECLARE_MSM_GPIO_PINS(47);
+DECLARE_MSM_GPIO_PINS(48);
+DECLARE_MSM_GPIO_PINS(49);
+DECLARE_MSM_GPIO_PINS(50);
+DECLARE_MSM_GPIO_PINS(51);
+DECLARE_MSM_GPIO_PINS(52);
+DECLARE_MSM_GPIO_PINS(53);
+DECLARE_MSM_GPIO_PINS(54);
+DECLARE_MSM_GPIO_PINS(55);
+DECLARE_MSM_GPIO_PINS(56);
+DECLARE_MSM_GPIO_PINS(57);
+DECLARE_MSM_GPIO_PINS(58);
+DECLARE_MSM_GPIO_PINS(59);
+DECLARE_MSM_GPIO_PINS(60);
+DECLARE_MSM_GPIO_PINS(61);
+DECLARE_MSM_GPIO_PINS(62);
+DECLARE_MSM_GPIO_PINS(63);
+DECLARE_MSM_GPIO_PINS(64);
+DECLARE_MSM_GPIO_PINS(65);
+DECLARE_MSM_GPIO_PINS(66);
+DECLARE_MSM_GPIO_PINS(67);
+DECLARE_MSM_GPIO_PINS(68);
+DECLARE_MSM_GPIO_PINS(69);
+DECLARE_MSM_GPIO_PINS(70);
+DECLARE_MSM_GPIO_PINS(71);
+DECLARE_MSM_GPIO_PINS(72);
+DECLARE_MSM_GPIO_PINS(73);
+DECLARE_MSM_GPIO_PINS(74);
+DECLARE_MSM_GPIO_PINS(75);
+DECLARE_MSM_GPIO_PINS(76);
+DECLARE_MSM_GPIO_PINS(77);
+DECLARE_MSM_GPIO_PINS(78);
+DECLARE_MSM_GPIO_PINS(79);
+DECLARE_MSM_GPIO_PINS(80);
+DECLARE_MSM_GPIO_PINS(81);
+DECLARE_MSM_GPIO_PINS(82);
+DECLARE_MSM_GPIO_PINS(83);
+DECLARE_MSM_GPIO_PINS(84);
+DECLARE_MSM_GPIO_PINS(85);
+DECLARE_MSM_GPIO_PINS(86);
+DECLARE_MSM_GPIO_PINS(87);
+DECLARE_MSM_GPIO_PINS(88);
+DECLARE_MSM_GPIO_PINS(89);
+DECLARE_MSM_GPIO_PINS(90);
+DECLARE_MSM_GPIO_PINS(91);
+DECLARE_MSM_GPIO_PINS(92);
+DECLARE_MSM_GPIO_PINS(93);
+DECLARE_MSM_GPIO_PINS(94);
+DECLARE_MSM_GPIO_PINS(95);
+DECLARE_MSM_GPIO_PINS(96);
+DECLARE_MSM_GPIO_PINS(97);
+DECLARE_MSM_GPIO_PINS(98);
+DECLARE_MSM_GPIO_PINS(99);
+DECLARE_MSM_GPIO_PINS(100);
+DECLARE_MSM_GPIO_PINS(101);
+DECLARE_MSM_GPIO_PINS(102);
+DECLARE_MSM_GPIO_PINS(103);
+DECLARE_MSM_GPIO_PINS(104);
+DECLARE_MSM_GPIO_PINS(105);
+DECLARE_MSM_GPIO_PINS(106);
+DECLARE_MSM_GPIO_PINS(107);
+DECLARE_MSM_GPIO_PINS(108);
+DECLARE_MSM_GPIO_PINS(109);
+DECLARE_MSM_GPIO_PINS(110);
+DECLARE_MSM_GPIO_PINS(111);
+DECLARE_MSM_GPIO_PINS(112);
+DECLARE_MSM_GPIO_PINS(113);
+DECLARE_MSM_GPIO_PINS(114);
+DECLARE_MSM_GPIO_PINS(115);
+DECLARE_MSM_GPIO_PINS(116);
+DECLARE_MSM_GPIO_PINS(117);
+DECLARE_MSM_GPIO_PINS(118);
+DECLARE_MSM_GPIO_PINS(119);
+DECLARE_MSM_GPIO_PINS(120);
+DECLARE_MSM_GPIO_PINS(121);
+DECLARE_MSM_GPIO_PINS(122);
+DECLARE_MSM_GPIO_PINS(123);
+DECLARE_MSM_GPIO_PINS(124);
+DECLARE_MSM_GPIO_PINS(125);
+DECLARE_MSM_GPIO_PINS(126);
+DECLARE_MSM_GPIO_PINS(127);
+DECLARE_MSM_GPIO_PINS(128);
+DECLARE_MSM_GPIO_PINS(129);
+DECLARE_MSM_GPIO_PINS(130);
+DECLARE_MSM_GPIO_PINS(131);
+DECLARE_MSM_GPIO_PINS(132);
+DECLARE_MSM_GPIO_PINS(133);
+DECLARE_MSM_GPIO_PINS(134);
+DECLARE_MSM_GPIO_PINS(135);
+DECLARE_MSM_GPIO_PINS(136);
+DECLARE_MSM_GPIO_PINS(137);
+DECLARE_MSM_GPIO_PINS(138);
+DECLARE_MSM_GPIO_PINS(139);
+DECLARE_MSM_GPIO_PINS(140);
+DECLARE_MSM_GPIO_PINS(141);
+DECLARE_MSM_GPIO_PINS(142);
+DECLARE_MSM_GPIO_PINS(143);
+DECLARE_MSM_GPIO_PINS(144);
+DECLARE_MSM_GPIO_PINS(145);
+DECLARE_MSM_GPIO_PINS(146);
+DECLARE_MSM_GPIO_PINS(147);
+DECLARE_MSM_GPIO_PINS(148);
+DECLARE_MSM_GPIO_PINS(149);
+DECLARE_MSM_GPIO_PINS(150);
+
+static const unsigned int sdc1_rclk_pins[] = { 151 };
+static const unsigned int sdc1_clk_pins[] = { 152 };
+static const unsigned int sdc1_cmd_pins[] = { 153 };
+static const unsigned int sdc1_data_pins[] = { 154 };
+
+enum qdu1000_functions {
+ msm_mux_gpio,
+ msm_mux_CMO_PRI,
+ msm_mux_SI5518_INT,
+ msm_mux_atest_char,
+ msm_mux_atest_usb,
+ msm_mux_char_exec,
+ msm_mux_cmu_rng,
+ msm_mux_dbg_out_clk,
+ msm_mux_ddr_bist,
+ msm_mux_ddr_pxi0,
+ msm_mux_ddr_pxi1,
+ msm_mux_ddr_pxi2,
+ msm_mux_ddr_pxi3,
+ msm_mux_ddr_pxi4,
+ msm_mux_ddr_pxi5,
+ msm_mux_ddr_pxi6,
+ msm_mux_ddr_pxi7,
+ msm_mux_eth012_int_n,
+ msm_mux_eth345_int_n,
+ msm_mux_eth6_int_n,
+ msm_mux_gcc_gp1,
+ msm_mux_gcc_gp2,
+ msm_mux_gcc_gp3,
+ msm_mux_gps_pps_in,
+ msm_mux_hardsync_pps_in,
+ msm_mux_intr_c,
+ msm_mux_jitter_bist_ref,
+ msm_mux_pcie_clkreqn,
+ msm_mux_phase_flag,
+ msm_mux_pll_bist,
+ msm_mux_pll_clk,
+ msm_mux_prng_rosc,
+ msm_mux_qdss_cti,
+ msm_mux_qdss_gpio,
+ msm_mux_qlink0_enable,
+ msm_mux_qlink0_request,
+ msm_mux_qlink0_wmss,
+ msm_mux_qlink1_enable,
+ msm_mux_qlink1_request,
+ msm_mux_qlink1_wmss,
+ msm_mux_qlink2_enable,
+ msm_mux_qlink2_request,
+ msm_mux_qlink2_wmss,
+ msm_mux_qlink3_enable,
+ msm_mux_qlink3_request,
+ msm_mux_qlink3_wmss,
+ msm_mux_qlink4_enable,
+ msm_mux_qlink4_request,
+ msm_mux_qlink4_wmss,
+ msm_mux_qlink5_enable,
+ msm_mux_qlink5_request,
+ msm_mux_qlink5_wmss,
+ msm_mux_qlink6_enable,
+ msm_mux_qlink6_request,
+ msm_mux_qlink6_wmss,
+ msm_mux_qlink7_enable,
+ msm_mux_qlink7_request,
+ msm_mux_qlink7_wmss,
+ msm_mux_qspi_clk,
+ msm_mux_qspi_cs,
+ msm_mux_qspi0,
+ msm_mux_qspi1,
+ msm_mux_qspi2,
+ msm_mux_qspi3,
+ msm_mux_qup00,
+ msm_mux_qup01,
+ msm_mux_qup02,
+ msm_mux_qup03,
+ msm_mux_qup04,
+ msm_mux_qup05,
+ msm_mux_qup06,
+ msm_mux_qup07,
+ msm_mux_qup08,
+ msm_mux_qup10,
+ msm_mux_qup11,
+ msm_mux_qup12,
+ msm_mux_qup13,
+ msm_mux_qup14,
+ msm_mux_qup15,
+ msm_mux_qup16,
+ msm_mux_qup17,
+ msm_mux_qup20,
+ msm_mux_qup21,
+ msm_mux_qup22,
+ msm_mux_smb_alert,
+ msm_mux_smb_clk,
+ msm_mux_smb_dat,
+ msm_mux_tb_trig,
+ msm_mux_tgu_ch0,
+ msm_mux_tgu_ch1,
+ msm_mux_tgu_ch2,
+ msm_mux_tgu_ch3,
+ msm_mux_tgu_ch4,
+ msm_mux_tgu_ch5,
+ msm_mux_tgu_ch6,
+ msm_mux_tgu_ch7,
+ msm_mux_tmess_prng0,
+ msm_mux_tmess_prng1,
+ msm_mux_tmess_prng2,
+ msm_mux_tmess_prng3,
+ msm_mux_tod_pps_in,
+ msm_mux_tsense_pwm1,
+ msm_mux_tsense_pwm2,
+ msm_mux_usb2phy_ac,
+ msm_mux_usb_con_det,
+ msm_mux_usb_dfp_en,
+ msm_mux_usb_phy,
+ msm_mux_vfr_0,
+ msm_mux_vfr_1,
+ msm_mux_vsense_trigger,
+ msm_mux__,
+};
+
+static const char * const gpio_groups[] = {
+ "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
+ "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
+ "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
+ "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
+ "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
+ "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
+ "gpio43", "gpio44", "gpio45", "gpio46", "gpio47", "gpio48", "gpio49",
+ "gpio50", "gpio51", "gpio52", "gpio53", "gpio54", "gpio55", "gpio56",
+ "gpio57", "gpio58", "gpio59", "gpio60", "gpio61", "gpio62", "gpio63",
+ "gpio64", "gpio65", "gpio66", "gpio67", "gpio68", "gpio69", "gpio70",
+ "gpio71", "gpio72", "gpio73", "gpio74", "gpio75", "gpio76", "gpio77",
+ "gpio78", "gpio79", "gpio80", "gpio81", "gpio82", "gpio83", "gpio84",
+ "gpio85", "gpio86", "gpio87", "gpio88", "gpio89", "gpio90", "gpio91",
+ "gpio92", "gpio93", "gpio94", "gpio95", "gpio96", "gpio97", "gpio98",
+ "gpio99", "gpio100", "gpio101", "gpio102", "gpio103", "gpio104",
+ "gpio105", "gpio106", "gpio107", "gpio108", "gpio109", "gpio110",
+ "gpio111", "gpio112", "gpio113", "gpio114", "gpio115", "gpio116",
+ "gpio117", "gpio118", "gpio119", "gpio120", "gpio121", "gpio122",
+ "gpio123", "gpio124", "gpio125", "gpio126", "gpio127", "gpio128",
+ "gpio129", "gpio130", "gpio131", "gpio132", "gpio133", "gpio134",
+ "gpio135", "gpio136", "gpio137", "gpio138", "gpio139", "gpio140",
+ "gpio141", "gpio142", "gpio143", "gpio144", "gpio145", "gpio146",
+ "gpio147", "gpio148", "gpio149", "gpio150",
+};
+static const char * const CMO_PRI_groups[] = {
+ "gpio103",
+};
+static const char * const SI5518_INT_groups[] = {
+ "gpio44",
+};
+static const char * const atest_char_groups[] = {
+ "gpio89", "gpio90", "gpio91", "gpio92", "gpio95",
+};
+static const char * const atest_usb_groups[] = {
+ "gpio114", "gpio115", "gpio116", "gpio117", "gpio118",
+};
+static const char * const char_exec_groups[] = {
+ "gpio99", "gpio100",
+};
+static const char * const cmu_rng_groups[] = {
+ "gpio89", "gpio90", "gpio91", "gpio92",
+};
+static const char * const dbg_out_clk_groups[] = {
+ "gpio136",
+};
+static const char * const ddr_bist_groups[] = {
+ "gpio0", "gpio1", "gpio2", "gpio3",
+};
+static const char * const ddr_pxi0_groups[] = {
+ "gpio114", "gpio115",
+};
+static const char * const ddr_pxi1_groups[] = {
+ "gpio116", "gpio117",
+};
+static const char * const ddr_pxi2_groups[] = {
+ "gpio118", "gpio119",
+};
+static const char * const ddr_pxi3_groups[] = {
+ "gpio120", "gpio121",
+};
+static const char * const ddr_pxi4_groups[] = {
+ "gpio122", "gpio123",
+};
+static const char * const ddr_pxi5_groups[] = {
+ "gpio124", "gpio125",
+};
+static const char * const ddr_pxi6_groups[] = {
+ "gpio126", "gpio127",
+};
+static const char * const ddr_pxi7_groups[] = {
+ "gpio128", "gpio129",
+};
+static const char * const eth012_int_n_groups[] = {
+ "gpio86",
+};
+static const char * const eth345_int_n_groups[] = {
+ "gpio87",
+};
+static const char * const eth6_int_n_groups[] = {
+ "gpio88",
+};
+static const char * const gcc_gp1_groups[] = {
+ "gpio86", "gpio134",
+};
+static const char * const gcc_gp2_groups[] = {
+ "gpio87", "gpio135",
+};
+static const char * const gcc_gp3_groups[] = {
+ "gpio88", "gpio136",
+};
+static const char * const gps_pps_in_groups[] = {
+ "gpio49",
+};
+static const char * const hardsync_pps_in_groups[] = {
+ "gpio47",
+};
+static const char * const intr_c_groups[] = {
+ "gpio26", "gpio27", "gpio28", "gpio141", "gpio142", "gpio143",
+};
+static const char * const jitter_bist_ref_groups[] = {
+ "gpio130",
+};
+static const char * const pcie_clkreqn_groups[] = {
+ "gpio98", "gpio99", "gpio100",
+};
+static const char * const phase_flag_groups[] = {
+ "gpio6", "gpio7", "gpio8", "gpio9", "gpio16", "gpio17", "gpio18",
+ "gpio19", "gpio20", "gpio22", "gpio21", "gpio23", "gpio24", "gpio25",
+ "gpio26", "gpio27", "gpio28", "gpio29", "gpio30", "gpio31", "gpio32",
+ "gpio33", "gpio42", "gpio43", "gpio89", "gpio90", "gpio91", "gpio92",
+ "gpio95", "gpio96", "gpio97", "gpio102",
+};
+static const char * const pll_bist_groups[] = {
+ "gpio20",
+};
+static const char * const pll_clk_groups[] = {
+ "gpio98",
+};
+static const char * const prng_rosc_groups[] = {
+ "gpio18", "gpio19", "gpio20", "gpio21",
+};
+static const char * const qdss_cti_groups[] = {
+ "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio48",
+ "gpio49", "gpio86", "gpio87", "gpio93", "gpio94", "gpio130", "gpio131",
+ "gpio132", "gpio133", "gpio134", "gpio135", "gpio144", "gpio145",
+};
+static const char * const qdss_gpio_groups[] = {
+ "gpio6", "gpio7", "gpio8", "gpio9", "gpio16", "gpio17", "gpio18",
+ "gpio19", "gpio20", "gpio21", "gpio22", "gpio23", "gpio25", "gpio26",
+ "gpio27", "gpio28", "gpio24", "gpio29", "gpio30", "gpio31", "gpio32",
+ "gpio33", "gpio34", "gpio35", "gpio42", "gpio43", "gpio88", "gpio89",
+ "gpio90", "gpio91", "gpio92", "gpio95", "gpio96", "gpio97", "gpio102",
+ "gpio103",
+};
+static const char * const qlink0_enable_groups[] = {
+ "gpio67",
+};
+static const char * const qlink0_request_groups[] = {
+ "gpio66",
+};
+static const char * const qlink0_wmss_groups[] = {
+ "gpio82",
+};
+static const char * const qlink1_enable_groups[] = {
+ "gpio69",
+};
+static const char * const qlink1_request_groups[] = {
+ "gpio68",
+};
+static const char * const qlink1_wmss_groups[] = {
+ "gpio83",
+};
+static const char * const qlink2_enable_groups[] = {
+ "gpio71",
+};
+static const char * const qlink2_request_groups[] = {
+ "gpio70",
+};
+static const char * const qlink2_wmss_groups[] = {
+ "gpio138",
+};
+static const char * const qlink3_enable_groups[] = {
+ "gpio73",
+};
+static const char * const qlink3_request_groups[] = {
+ "gpio72",
+};
+static const char * const qlink3_wmss_groups[] = {
+ "gpio139",
+};
+static const char * const qlink4_enable_groups[] = {
+ "gpio75",
+};
+static const char * const qlink4_request_groups[] = {
+ "gpio74",
+};
+static const char * const qlink4_wmss_groups[] = {
+ "gpio84",
+};
+static const char * const qlink5_enable_groups[] = {
+ "gpio77",
+};
+static const char * const qlink5_request_groups[] = {
+ "gpio76",
+};
+static const char * const qlink5_wmss_groups[] = {
+ "gpio85",
+};
+static const char * const qlink6_enable_groups[] = {
+ "gpio79",
+};
+static const char * const qlink6_request_groups[] = {
+ "gpio78",
+};
+static const char * const qlink6_wmss_groups[] = {
+ "gpio56",
+};
+static const char * const qlink7_enable_groups[] = {
+ "gpio81",
+};
+static const char * const qlink7_request_groups[] = {
+ "gpio80",
+};
+static const char * const qlink7_wmss_groups[] = {
+ "gpio57",
+};
+static const char * const qspi0_groups[] = {
+ "gpio114",
+};
+static const char * const qspi1_groups[] = {
+ "gpio115",
+};
+static const char * const qspi2_groups[] = {
+ "gpio116",
+};
+static const char * const qspi3_groups[] = {
+ "gpio117",
+};
+static const char * const qspi_clk_groups[] = {
+ "gpio126",
+};
+static const char * const qspi_cs_groups[] = {
+ "gpio125",
+};
+static const char * const qup00_groups[] = {
+ "gpio6", "gpio7", "gpio8", "gpio9",
+};
+static const char * const qup01_groups[] = {
+ "gpio10", "gpio11", "gpio12", "gpio13",
+};
+static const char * const qup02_groups[] = {
+ "gpio10", "gpio11", "gpio12", "gpio13",
+};
+static const char * const qup03_groups[] = {
+ "gpio14", "gpio15", "gpio16", "gpio17",
+};
+static const char * const qup04_groups[] = {
+ "gpio14", "gpio15", "gpio16", "gpio17",
+};
+static const char * const qup05_groups[] = {
+ "gpio130", "gpio131", "gpio132", "gpio133",
+};
+static const char * const qup06_groups[] = {
+ "gpio130", "gpio131", "gpio132", "gpio133",
+};
+static const char * const qup07_groups[] = {
+ "gpio134", "gpio135",
+};
+static const char * const qup08_groups[] = {
+ "gpio134", "gpio135",
+};
+static const char * const qup10_groups[] = {
+ "gpio18", "gpio19", "gpio20", "gpio21",
+};
+static const char * const qup11_groups[] = {
+ "gpio22", "gpio23", "gpio24", "gpio25",
+};
+static const char * const qup12_groups[] = {
+ "gpio22", "gpio23", "gpio24", "gpio25",
+};
+static const char * const qup13_groups[] = {
+ "gpio26", "gpio27", "gpio28", "gpio29",
+};
+static const char * const qup14_groups[] = {
+ "gpio26", "gpio27", "gpio28", "gpio29",
+};
+static const char * const qup15_groups[] = {
+ "gpio30", "gpio31", "gpio32", "gpio33",
+};
+static const char * const qup16_groups[] = {
+ "gpio29", "gpio34", "gpio35", "gpio36", "gpio37", "gpio38", "gpio39",
+};
+static const char * const qup17_groups[] = {
+ "gpio12", "gpio13", "gpio14", "gpio30", "gpio31", "gpio40", "gpio41",
+};
+static const char * const qup20_groups[] = {
+ "gpio0", "gpio1", "gpio2", "gpio3",
+};
+static const char * const qup21_groups[] = {
+ "gpio0", "gpio1", "gpio2", "gpio3",
+};
+static const char * const qup22_groups[] = {
+ "gpio4", "gpio5", "gpio128", "gpio129",
+};
+static const char * const smb_alert_groups[] = {
+ "gpio88", "gpio101",
+};
+static const char * const smb_clk_groups[] = {
+ "gpio133",
+};
+static const char * const smb_dat_groups[] = {
+ "gpio132",
+};
+static const char * const tb_trig_groups[] = {
+ "gpio114",
+};
+static const char * const tgu_ch0_groups[] = {
+ "gpio6",
+};
+static const char * const tgu_ch1_groups[] = {
+ "gpio7",
+};
+static const char * const tgu_ch2_groups[] = {
+ "gpio8",
+};
+static const char * const tgu_ch3_groups[] = {
+ "gpio9",
+};
+static const char * const tgu_ch4_groups[] = {
+ "gpio44",
+};
+static const char * const tgu_ch5_groups[] = {
+ "gpio45",
+};
+static const char * const tgu_ch6_groups[] = {
+ "gpio46",
+};
+static const char * const tgu_ch7_groups[] = {
+ "gpio47",
+};
+static const char * const tmess_prng0_groups[] = {
+ "gpio33",
+};
+static const char * const tmess_prng1_groups[] = {
+ "gpio32",
+};
+static const char * const tmess_prng2_groups[] = {
+ "gpio31",
+};
+static const char * const tmess_prng3_groups[] = {
+ "gpio30",
+};
+static const char * const tod_pps_in_groups[] = {
+ "gpio48",
+};
+static const char * const tsense_pwm1_groups[] = {
+ "gpio2",
+};
+static const char * const tsense_pwm2_groups[] = {
+ "gpio3",
+};
+static const char * const usb2phy_ac_groups[] = {
+ "gpio90",
+};
+static const char * const usb_con_det_groups[] = {
+ "gpio42",
+};
+static const char * const usb_dfp_en_groups[] = {
+ "gpio43",
+};
+static const char * const usb_phy_groups[] = {
+ "gpio91",
+};
+static const char * const vfr_0_groups[] = {
+ "gpio93",
+};
+static const char * const vfr_1_groups[] = {
+ "gpio94",
+};
+static const char * const vsense_trigger_groups[] = {
+ "gpio135",
+};
+
+static const struct msm_function qdu1000_functions[] = {
+ FUNCTION(gpio),
+ FUNCTION(CMO_PRI),
+ FUNCTION(SI5518_INT),
+ FUNCTION(atest_char),
+ FUNCTION(atest_usb),
+ FUNCTION(char_exec),
+ FUNCTION(cmu_rng),
+ FUNCTION(dbg_out_clk),
+ FUNCTION(ddr_bist),
+ FUNCTION(ddr_pxi0),
+ FUNCTION(ddr_pxi1),
+ FUNCTION(ddr_pxi2),
+ FUNCTION(ddr_pxi3),
+ FUNCTION(ddr_pxi4),
+ FUNCTION(ddr_pxi5),
+ FUNCTION(ddr_pxi6),
+ FUNCTION(ddr_pxi7),
+ FUNCTION(eth012_int_n),
+ FUNCTION(eth345_int_n),
+ FUNCTION(eth6_int_n),
+ FUNCTION(gcc_gp1),
+ FUNCTION(gcc_gp2),
+ FUNCTION(gcc_gp3),
+ FUNCTION(gps_pps_in),
+ FUNCTION(hardsync_pps_in),
+ FUNCTION(intr_c),
+ FUNCTION(jitter_bist_ref),
+ FUNCTION(pcie_clkreqn),
+ FUNCTION(phase_flag),
+ FUNCTION(pll_bist),
+ FUNCTION(pll_clk),
+ FUNCTION(prng_rosc),
+ FUNCTION(qdss_cti),
+ FUNCTION(qdss_gpio),
+ FUNCTION(qlink0_enable),
+ FUNCTION(qlink0_request),
+ FUNCTION(qlink0_wmss),
+ FUNCTION(qlink1_enable),
+ FUNCTION(qlink1_request),
+ FUNCTION(qlink1_wmss),
+ FUNCTION(qlink2_enable),
+ FUNCTION(qlink2_request),
+ FUNCTION(qlink2_wmss),
+ FUNCTION(qlink3_enable),
+ FUNCTION(qlink3_request),
+ FUNCTION(qlink3_wmss),
+ FUNCTION(qlink4_enable),
+ FUNCTION(qlink4_request),
+ FUNCTION(qlink4_wmss),
+ FUNCTION(qlink5_enable),
+ FUNCTION(qlink5_request),
+ FUNCTION(qlink5_wmss),
+ FUNCTION(qlink6_enable),
+ FUNCTION(qlink6_request),
+ FUNCTION(qlink6_wmss),
+ FUNCTION(qlink7_enable),
+ FUNCTION(qlink7_request),
+ FUNCTION(qlink7_wmss),
+ FUNCTION(qspi0),
+ FUNCTION(qspi1),
+ FUNCTION(qspi2),
+ FUNCTION(qspi3),
+ FUNCTION(qspi_clk),
+ FUNCTION(qspi_cs),
+ FUNCTION(qup00),
+ FUNCTION(qup01),
+ FUNCTION(qup02),
+ FUNCTION(qup03),
+ FUNCTION(qup04),
+ FUNCTION(qup05),
+ FUNCTION(qup06),
+ FUNCTION(qup07),
+ FUNCTION(qup08),
+ FUNCTION(qup10),
+ FUNCTION(qup11),
+ FUNCTION(qup12),
+ FUNCTION(qup13),
+ FUNCTION(qup14),
+ FUNCTION(qup15),
+ FUNCTION(qup16),
+ FUNCTION(qup17),
+ FUNCTION(qup20),
+ FUNCTION(qup21),
+ FUNCTION(qup22),
+ FUNCTION(smb_alert),
+ FUNCTION(smb_clk),
+ FUNCTION(smb_dat),
+ FUNCTION(tb_trig),
+ FUNCTION(tgu_ch0),
+ FUNCTION(tgu_ch1),
+ FUNCTION(tgu_ch2),
+ FUNCTION(tgu_ch3),
+ FUNCTION(tgu_ch4),
+ FUNCTION(tgu_ch5),
+ FUNCTION(tgu_ch6),
+ FUNCTION(tgu_ch7),
+ FUNCTION(tmess_prng0),
+ FUNCTION(tmess_prng1),
+ FUNCTION(tmess_prng2),
+ FUNCTION(tmess_prng3),
+ FUNCTION(tod_pps_in),
+ FUNCTION(tsense_pwm1),
+ FUNCTION(tsense_pwm2),
+ FUNCTION(usb2phy_ac),
+ FUNCTION(usb_con_det),
+ FUNCTION(usb_dfp_en),
+ FUNCTION(usb_phy),
+ FUNCTION(vfr_0),
+ FUNCTION(vfr_1),
+ FUNCTION(vsense_trigger),
+};
+
+/* Every pin is maintained as a single group, and missing or non-existing pin
+ * would be maintained as dummy group to synchronize pin group index with
+ * pin descriptor registered with pinctrl core.
+ * Clients would not be able to request these dummy pin groups.
+ */
+static const struct msm_pingroup qdu1000_groups[] = {
+ [0] = PINGROUP(0, qup20, qup21, ddr_bist, _, _, _, _, _, _),
+ [1] = PINGROUP(1, qup20, qup21, ddr_bist, _, _, _, _, _, _),
+ [2] = PINGROUP(2, qup21, qup20, ddr_bist, _,
+ tsense_pwm1, _, _, _, _),
+ [3] = PINGROUP(3, qup21, qup20, ddr_bist, _,
+ tsense_pwm2, _, _, _, _),
+ [4] = PINGROUP(4, qup22, _, _, _, _, _, _, _, _),
+ [5] = PINGROUP(5, qup22, _, _, _, _, _, _, _, _),
+ [6] = PINGROUP(6, qup00, tgu_ch0, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [7] = PINGROUP(7, qup00, tgu_ch1, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [8] = PINGROUP(8, qup00, tgu_ch2, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [9] = PINGROUP(9, qup00, tgu_ch3, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [10] = PINGROUP(10, qup01, qup02, _, _, _, _, _, _, _),
+ [11] = PINGROUP(11, qup01, qup02, _, _, _, _, _, _, _),
+ [12] = PINGROUP(12, qup02, qup01, qup17, _, _, _, _, _, _),
+ [13] = PINGROUP(13, qup02, qup01, qup17, _, _, _, _, _, _),
+ [14] = PINGROUP(14, qup03, qup04, qup17, _, _, _, _, _, _),
+ [15] = PINGROUP(15, qup03, qup04, _, _, _, _, _, _, _),
+ [16] = PINGROUP(16, qup04, qup03, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [17] = PINGROUP(17, qup04, qup03, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [18] = PINGROUP(18, qup10, prng_rosc, phase_flag,
+ _, qdss_gpio, _, _, _, _),
+ [19] = PINGROUP(19, qup10, prng_rosc, phase_flag,
+ _, qdss_gpio, _, _, _, _),
+ [20] = PINGROUP(20, qup10, prng_rosc, pll_bist,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [21] = PINGROUP(21, qup10, prng_rosc, phase_flag,
+ _, qdss_gpio, _, _, _, _),
+ [22] = PINGROUP(22, qup11, qup12, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [23] = PINGROUP(23, qup11, qup12, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [24] = PINGROUP(24, qup12, qup11, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [25] = PINGROUP(25, qup12, qup11, phase_flag, _,
+ qdss_gpio, _, _, _, _),
+ [26] = PINGROUP(26, qup13, qup14, intr_c,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [27] = PINGROUP(27, qup13, qup14, intr_c,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [28] = PINGROUP(28, qup14, qup13, intr_c,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [29] = PINGROUP(29, qup14, qup13, qup16,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [30] = PINGROUP(30, qup17, qup15, tmess_prng3,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [31] = PINGROUP(31, qup17, qup15, tmess_prng2,
+ phase_flag, _, qdss_gpio, _, _, _),
+ [32] = PINGROUP(32, qup15, tmess_prng1, phase_flag,
+ _, qdss_gpio, _, _, _, _),
+ [33] = PINGROUP(33, qup15, tmess_prng0, phase_flag,
+ _, qdss_gpio, _, _, _, _),
+ [34] = PINGROUP(34, qup16, qdss_gpio, _, _, _, _, _, _, _),
+ [35] = PINGROUP(35, qup16, qdss_gpio, _, _, _, _, _, _, _),
+ [36] = PINGROUP(36, qup16, qdss_cti, _, _, _, _, _, _, _),
+ [37] = PINGROUP(37, qup16, qdss_cti, _, _, _, _, _, _, _),
+ [38] = PINGROUP(38, qup16, qdss_cti, _, _, _, _, _, _, _),
+ [39] = PINGROUP(39, qup16, qdss_cti, _, _, _, _, _, _, _),
+ [40] = PINGROUP(40, qup17, qdss_cti, _, _, _, _, _, _, _),
+ [41] = PINGROUP(41, qup17, qdss_cti, _, _, _, _, _, _, _),
+ [42] = PINGROUP(42, usb_con_det, phase_flag, _,
+ qdss_gpio, _, _, _, _, _),
+ [43] = PINGROUP(43, usb_dfp_en, phase_flag, _,
+ qdss_gpio, _, _, _, _, _),
+ [44] = PINGROUP(44, SI5518_INT, tgu_ch4, _, _, _, _, _, _, _),
+ [45] = PINGROUP(45, tgu_ch5, _, _, _, _, _, _, _, _),
+ [46] = PINGROUP(46, tgu_ch6, _, _, _, _, _, _, _, _),
+ [47] = PINGROUP(47, hardsync_pps_in, tgu_ch7, _, _, _, _, _, _, _),
+ [48] = PINGROUP(48, tod_pps_in, qdss_cti, _, _, _, _, _, _, _),
+ [49] = PINGROUP(49, gps_pps_in, qdss_cti, _, _, _, _, _, _, _),
+ [50] = PINGROUP(50, _, _, _, _, _, _, _, _, _),
+ [51] = PINGROUP(51, _, _, _, _, _, _, _, _, _),
+ [52] = PINGROUP(52, _, _, _, _, _, _, _, _, _),
+ [53] = PINGROUP(53, _, _, _, _, _, _, _, _, _),
+ [54] = PINGROUP(54, _, _, _, _, _, _, _, _, _),
+ [55] = PINGROUP(55, _, _, _, _, _, _, _, _, _),
+ [56] = PINGROUP(56, _, qlink6_wmss, _, _, _, _, _, _, _),
+ [57] = PINGROUP(57, _, qlink7_wmss, _, _, _, _, _, _, _),
+ [58] = PINGROUP(58, _, _, _, _, _, _, _, _, _),
+ [59] = PINGROUP(59, _, _, _, _, _, _, _, _, _),
+ [60] = PINGROUP(60, _, _, _, _, _, _, _, _, _),
+ [61] = PINGROUP(61, _, _, _, _, _, _, _, _, _),
+ [62] = PINGROUP(62, _, _, _, _, _, _, _, _, _),
+ [63] = PINGROUP(63, _, _, _, _, _, _, _, _, _),
+ [64] = PINGROUP(64, _, _, _, _, _, _, _, _, _),
+ [65] = PINGROUP(65, _, _, _, _, _, _, _, _, _),
+ [66] = PINGROUP(66, qlink0_request, _, _, _, _, _, _, _, _),
+ [67] = PINGROUP(67, qlink0_enable, _, _, _, _, _, _, _, _),
+ [68] = PINGROUP(68, qlink1_request, _, _, _, _, _, _, _, _),
+ [69] = PINGROUP(69, qlink1_enable, _, _, _, _, _, _, _, _),
+ [70] = PINGROUP(70, qlink2_request, _, _, _, _, _, _, _, _),
+ [71] = PINGROUP(71, qlink2_enable, _, _, _, _, _, _, _, _),
+ [72] = PINGROUP(72, qlink3_request, _, _, _, _, _, _, _, _),
+ [73] = PINGROUP(73, qlink3_enable, _, _, _, _, _, _, _, _),
+ [74] = PINGROUP(74, qlink4_request, _, _, _, _, _, _, _, _),
+ [75] = PINGROUP(75, qlink4_enable, _, _, _, _, _, _, _, _),
+ [76] = PINGROUP(76, qlink5_request, _, _, _, _, _, _, _, _),
+ [77] = PINGROUP(77, qlink5_enable, _, _, _, _, _, _, _, _),
+ [78] = PINGROUP(78, qlink6_request, _, _, _, _, _, _, _, _),
+ [79] = PINGROUP(79, qlink6_enable, _, _, _, _, _, _, _, _),
+ [80] = PINGROUP(80, qlink7_request, _, _, _, _, _, _, _, _),
+ [81] = PINGROUP(81, qlink7_enable, _, _, _, _, _, _, _, _),
+ [82] = PINGROUP(82, qlink0_wmss, _, _, _, _, _, _, _, _),
+ [83] = PINGROUP(83, qlink1_wmss, _, _, _, _, _, _, _, _),
+ [84] = PINGROUP(84, qlink4_wmss, _, _, _, _, _, _, _, _),
+ [85] = PINGROUP(85, qlink5_wmss, _, _, _, _, _, _, _, _),
+ [86] = PINGROUP(86, eth012_int_n, gcc_gp1, _, qdss_cti, _, _, _, _, _),
+ [87] = PINGROUP(87, eth345_int_n, gcc_gp2, _, qdss_cti, _, _, _, _, _),
+ [88] = PINGROUP(88, eth6_int_n, smb_alert, gcc_gp3, _,
+ qdss_gpio, _, _, _, _),
+ [89] = PINGROUP(89, phase_flag, cmu_rng, _,
+ qdss_gpio, atest_char, _, _, _, _),
+ [90] = PINGROUP(90, usb2phy_ac, phase_flag,
+ cmu_rng, _, qdss_gpio,
+ atest_char, _, _, _),
+ [91] = PINGROUP(91, usb_phy, phase_flag, cmu_rng,
+ _, qdss_gpio, atest_char, _, _, _),
+ [92] = PINGROUP(92, phase_flag, cmu_rng, _,
+ qdss_gpio, atest_char, _, _, _, _),
+ [93] = PINGROUP(93, vfr_0, qdss_cti, _, _, _, _, _, _, _),
+ [94] = PINGROUP(94, vfr_1, qdss_cti, _, _, _, _, _, _, _),
+ [95] = PINGROUP(95, phase_flag, _, qdss_gpio,
+ atest_char, _, _, _, _, _),
+ [96] = PINGROUP(96, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
+ [97] = PINGROUP(97, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
+ [98] = PINGROUP(98, pll_clk, _, _, _, _, _, _, _, _),
+ [99] = PINGROUP(99, pcie_clkreqn, char_exec, _, _, _, _, _, _, _),
+ [100] = PINGROUP(100, char_exec, _, _, _, _, _, _, _, _),
+ [101] = PINGROUP(101, smb_alert, _, _, _, _, _, _, _, _),
+ [102] = PINGROUP(102, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
+ [103] = PINGROUP(103, CMO_PRI, qdss_gpio, _, _, _, _, _, _, _),
+ [104] = PINGROUP(104, _, _, _, _, _, _, _, _, _),
+ [105] = PINGROUP(105, _, _, _, _, _, _, _, _, _),
+ [106] = PINGROUP(106, _, _, _, _, _, _, _, _, _),
+ [107] = PINGROUP(107, _, _, _, _, _, _, _, _, _),
+ [108] = PINGROUP(108, _, _, _, _, _, _, _, _, _),
+ [109] = PINGROUP(109, _, _, _, _, _, _, _, _, _),
+ [110] = PINGROUP(110, _, _, _, _, _, _, _, _, _),
+ [111] = PINGROUP(111, _, _, _, _, _, _, _, _, _),
+ [112] = PINGROUP(112, _, _, _, _, _, _, _, _, _),
+ [113] = PINGROUP(113, _, _, _, _, _, _, _, _, _),
+ [114] = PINGROUP(114, qspi0, tb_trig, _,
+ atest_usb, ddr_pxi0, _, _, _, _),
+ [115] = PINGROUP(115, qspi1, _, atest_usb,
+ ddr_pxi0, _, _, _, _, _),
+ [116] = PINGROUP(116, qspi2, _, atest_usb,
+ ddr_pxi1, _, _, _, _, _),
+ [117] = PINGROUP(117, qspi3, _, atest_usb,
+ ddr_pxi1, _, _, _, _, _),
+ [118] = PINGROUP(118, _, atest_usb, ddr_pxi2, _, _, _, _, _, _),
+ [119] = PINGROUP(119, _, _, ddr_pxi2, _, _, _, _, _, _),
+ [120] = PINGROUP(120, _, _, ddr_pxi3, _, _, _, _, _, _),
+ [121] = PINGROUP(121, _, ddr_pxi3, _, _, _, _, _, _, _),
+ [122] = PINGROUP(122, _, ddr_pxi4, _, _, _, _, _, _, _),
+ [123] = PINGROUP(123, _, ddr_pxi4, _, _, _, _, _, _, _),
+ [124] = PINGROUP(124, _, ddr_pxi5, _, _, _, _, _, _, _),
+ [125] = PINGROUP(125, qspi_cs, _, ddr_pxi5, _, _, _, _, _, _),
+ [126] = PINGROUP(126, qspi_clk, _, ddr_pxi6, _, _, _, _, _, _),
+ [127] = PINGROUP(127, _, ddr_pxi6, _, _, _, _, _, _, _),
+ [128] = PINGROUP(128, qup22, _, ddr_pxi7, _, _, _, _, _, _),
+ [129] = PINGROUP(129, qup22, ddr_pxi7, _, _, _, _, _, _, _),
+ [130] = PINGROUP(130, qup05, qup06, jitter_bist_ref,
+ qdss_cti, _, _, _, _, _),
+ [131] = PINGROUP(131, qup05, qup06, qdss_cti, _, _, _, _, _, _),
+ [132] = PINGROUP(132, qup06, qup05, smb_dat,
+ qdss_cti, _, _, _, _, _),
+ [133] = PINGROUP(133, qup06, qup05, smb_clk,
+ qdss_cti, _, _, _, _, _),
+ [134] = PINGROUP(134, qup08, qup07, gcc_gp1, _,
+ qdss_cti, _, _, _, _),
+ [135] = PINGROUP(135, qup08, qup07, gcc_gp2, _,
+ qdss_cti, vsense_trigger, _, _, _),
+ [136] = PINGROUP(136, gcc_gp3, dbg_out_clk, _, _, _, _, _, _, _),
+ [137] = PINGROUP(137, _, _, _, _, _, _, _, _, _),
+ [138] = PINGROUP(138, qlink2_wmss, _, _, _, _, _, _, _, _),
+ [139] = PINGROUP(139, qlink3_wmss, _, _, _, _, _, _, _, _),
+ [140] = PINGROUP(140, _, _, _, _, _, _, _, _, _),
+ [141] = PINGROUP(141, intr_c, _, _, _, _, _, _, _, _),
+ [142] = PINGROUP(142, intr_c, _, _, _, _, _, _, _, _),
+ [143] = PINGROUP(143, intr_c, _, _, _, _, _, _, _, _),
+ [144] = PINGROUP(144, qdss_cti, _, _, _, _, _, _, _, _),
+ [145] = PINGROUP(145, qdss_cti, _, _, _, _, _, _, _, _),
+ [146] = PINGROUP(146, _, _, _, _, _, _, _, _, _),
+ [147] = PINGROUP(147, _, _, _, _, _, _, _, _, _),
+ [148] = PINGROUP(148, _, _, _, _, _, _, _, _, _),
+ [149] = PINGROUP(149, _, _, _, _, _, _, _, _, _),
+ [150] = PINGROUP(150, _, _, _, _, _, _, _, _, _),
+ [151] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x9e000, 0, 0),
+ [152] = SDC_QDSD_PINGROUP(sdc1_clk, 0x9d000, 13, 6),
+ [153] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x9d000, 11, 3),
+ [154] = SDC_QDSD_PINGROUP(sdc1_data, 0x9d000, 9, 0),
+};
+static const struct msm_pinctrl_soc_data qdu1000_tlmm = {
+ .pins = qdu1000_pins,
+ .npins = ARRAY_SIZE(qdu1000_pins),
+ .functions = qdu1000_functions,
+ .nfunctions = ARRAY_SIZE(qdu1000_functions),
+ .groups = qdu1000_groups,
+ .ngroups = ARRAY_SIZE(qdu1000_groups),
+ .ngpios = 151,
+};
+
+static int qdu1000_tlmm_probe(struct platform_device *pdev)
+{
+ return msm_pinctrl_probe(pdev, &qdu1000_tlmm);
+}
+
+static const struct of_device_id qdu1000_tlmm_of_match[] = {
+ { .compatible = "qcom,qdu1000-tlmm", },
+ { },
+};
+MODULE_DEVICE_TABLE(of, qdu1000_tlmm_of_match);
+
+static struct platform_driver qdu1000_tlmm_driver = {
+ .driver = {
+ .name = "qdu1000-tlmm",
+ .of_match_table = qdu1000_tlmm_of_match,
+ },
+ .probe = qdu1000_tlmm_probe,
+ .remove = msm_pinctrl_remove,
+};
+
+static int __init qdu1000_tlmm_init(void)
+{
+ return platform_driver_register(&qdu1000_tlmm_driver);
+}
+arch_initcall(qdu1000_tlmm_init);
+
+static void __exit qdu1000_tlmm_exit(void)
+{
+ platform_driver_unregister(&qdu1000_tlmm_driver);
+}
+module_exit(qdu1000_tlmm_exit);
+
+MODULE_DESCRIPTION("QTI QDU1000 TLMM driver");
+MODULE_LICENSE("GPL");
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-18 18:20 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl Melody Olvera
@ 2022-11-20 10:58 ` Krzysztof Kozlowski
2022-11-21 20:38 ` Melody Olvera
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-20 10:58 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 18/11/2022 19:20, Melody Olvera wrote:
> Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
> 1 file changed, 134 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
> new file mode 100644
> index 000000000000..cb0c496d8666
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
> @@ -0,0 +1,134 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
> +
> +maintainers:
> + - Melody Olvera <quic_molvera@quicinc.com>
> +
> +description: |
> + This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
> + QRU1000 platforms.
It's better to keep consistent style which allows to do easy
search/replace, than to have new files using their own sentences. So
keep it the same as was unified in few recent commits.
> +allOf:
> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
> +
> +properties:
> + compatible:
> + const: qcom,qdu1000-tlmm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts: true
> + interrupt-controller: true
> + "#interrupt-cells": true
> + gpio-controller: true
> +
> + gpio-reserved-ranges:
> + minItems: 1
> + maxItems: 75
Technically you can have up to 76 separate ranges (151 GPIOs).
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver
2022-11-18 18:20 ` [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver Melody Olvera
@ 2022-11-21 11:09 ` Konrad Dybcio
2022-11-21 20:41 ` Melody Olvera
0 siblings, 1 reply; 11+ messages in thread
From: Konrad Dybcio @ 2022-11-21 11:09 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 18.11.2022 19:20, Melody Olvera wrote:
> Add pin control driver for the TLMM block found in the QDU1000
> and QRU1000 SoC.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> drivers/pinctrl/qcom/Kconfig | 10 +
> drivers/pinctrl/qcom/Makefile | 1 +
> drivers/pinctrl/qcom/pinctrl-qdu1000.c | 1273 ++++++++++++++++++++++++
> 3 files changed, 1284 insertions(+)
> create mode 100644 drivers/pinctrl/qcom/pinctrl-qdu1000.c
>
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 1378ddca084f..9ff4145646a3 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -248,6 +248,16 @@ config PINCTRL_QCOM_SSBI_PMIC
> which are using SSBI for communication with SoC. Example PMIC's
> devices are pm8058 and pm8921.
>
> +config PINCTRL_QDU1000
[...]
> +DECLARE_MSM_GPIO_PINS(145);
> +DECLARE_MSM_GPIO_PINS(146);
> +DECLARE_MSM_GPIO_PINS(147);
> +DECLARE_MSM_GPIO_PINS(148);
> +DECLARE_MSM_GPIO_PINS(149);
> +DECLARE_MSM_GPIO_PINS(150);
> +
> +static const unsigned int sdc1_rclk_pins[] = { 151 };
> +static const unsigned int sdc1_clk_pins[] = { 152 };
> +static const unsigned int sdc1_cmd_pins[] = { 153 };
> +static const unsigned int sdc1_data_pins[] = { 154 };
> +
> +enum qdu1000_functions {
> + msm_mux_gpio,
> + msm_mux_CMO_PRI,
> + msm_mux_SI5518_INT,
Any reason these two are uppercase?
Konrad
> + msm_mux_atest_char,
> + msm_mux_atest_usb,
> + msm_mux_char_exec,
> + msm_mux_cmu_rng,
> + msm_mux_dbg_out_clk,
> + msm_mux_ddr_bist,
> + msm_mux_ddr_pxi0,
> + msm_mux_ddr_pxi1,
> + msm_mux_ddr_pxi2,
> + msm_mux_ddr_pxi3,
[...]
> +
> +/* Every pin is maintained as a single group, and missing or non-existing pin
/*
* Every pin...
Konrad
> + * would be maintained as dummy group to synchronize pin group index with
> + * pin descriptor registered with pinctrl core.
> + * Clients would not be able to request these dummy pin groups.
> + */
> +static const struct msm_pingroup qdu1000_groups[] = {
> + [0] = PINGROUP(0, qup20, qup21, ddr_bist, _, _, _, _, _, _),
> + [1] = PINGROUP(1, qup20, qup21, ddr_bist, _, _, _, _, _, _),
> + [2] = PINGROUP(2, qup21, qup20, ddr_bist, _,
> + tsense_pwm1, _, _, _, _),
> + [3] = PINGROUP(3, qup21, qup20, ddr_bist, _,
> + tsense_pwm2, _, _, _, _),
> + [4] = PINGROUP(4, qup22, _, _, _, _, _, _, _, _),
> + [5] = PINGROUP(5, qup22, _, _, _, _, _, _, _, _),
> + [6] = PINGROUP(6, qup00, tgu_ch0, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [7] = PINGROUP(7, qup00, tgu_ch1, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [8] = PINGROUP(8, qup00, tgu_ch2, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [9] = PINGROUP(9, qup00, tgu_ch3, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [10] = PINGROUP(10, qup01, qup02, _, _, _, _, _, _, _),
> + [11] = PINGROUP(11, qup01, qup02, _, _, _, _, _, _, _),
> + [12] = PINGROUP(12, qup02, qup01, qup17, _, _, _, _, _, _),
> + [13] = PINGROUP(13, qup02, qup01, qup17, _, _, _, _, _, _),
> + [14] = PINGROUP(14, qup03, qup04, qup17, _, _, _, _, _, _),
> + [15] = PINGROUP(15, qup03, qup04, _, _, _, _, _, _, _),
> + [16] = PINGROUP(16, qup04, qup03, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [17] = PINGROUP(17, qup04, qup03, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [18] = PINGROUP(18, qup10, prng_rosc, phase_flag,
> + _, qdss_gpio, _, _, _, _),
> + [19] = PINGROUP(19, qup10, prng_rosc, phase_flag,
> + _, qdss_gpio, _, _, _, _),
> + [20] = PINGROUP(20, qup10, prng_rosc, pll_bist,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [21] = PINGROUP(21, qup10, prng_rosc, phase_flag,
> + _, qdss_gpio, _, _, _, _),
> + [22] = PINGROUP(22, qup11, qup12, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [23] = PINGROUP(23, qup11, qup12, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [24] = PINGROUP(24, qup12, qup11, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [25] = PINGROUP(25, qup12, qup11, phase_flag, _,
> + qdss_gpio, _, _, _, _),
> + [26] = PINGROUP(26, qup13, qup14, intr_c,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [27] = PINGROUP(27, qup13, qup14, intr_c,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [28] = PINGROUP(28, qup14, qup13, intr_c,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [29] = PINGROUP(29, qup14, qup13, qup16,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [30] = PINGROUP(30, qup17, qup15, tmess_prng3,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [31] = PINGROUP(31, qup17, qup15, tmess_prng2,
> + phase_flag, _, qdss_gpio, _, _, _),
> + [32] = PINGROUP(32, qup15, tmess_prng1, phase_flag,
> + _, qdss_gpio, _, _, _, _),
> + [33] = PINGROUP(33, qup15, tmess_prng0, phase_flag,
> + _, qdss_gpio, _, _, _, _),
> + [34] = PINGROUP(34, qup16, qdss_gpio, _, _, _, _, _, _, _),
> + [35] = PINGROUP(35, qup16, qdss_gpio, _, _, _, _, _, _, _),
> + [36] = PINGROUP(36, qup16, qdss_cti, _, _, _, _, _, _, _),
> + [37] = PINGROUP(37, qup16, qdss_cti, _, _, _, _, _, _, _),
> + [38] = PINGROUP(38, qup16, qdss_cti, _, _, _, _, _, _, _),
> + [39] = PINGROUP(39, qup16, qdss_cti, _, _, _, _, _, _, _),
> + [40] = PINGROUP(40, qup17, qdss_cti, _, _, _, _, _, _, _),
> + [41] = PINGROUP(41, qup17, qdss_cti, _, _, _, _, _, _, _),
> + [42] = PINGROUP(42, usb_con_det, phase_flag, _,
> + qdss_gpio, _, _, _, _, _),
> + [43] = PINGROUP(43, usb_dfp_en, phase_flag, _,
> + qdss_gpio, _, _, _, _, _),
> + [44] = PINGROUP(44, SI5518_INT, tgu_ch4, _, _, _, _, _, _, _),
> + [45] = PINGROUP(45, tgu_ch5, _, _, _, _, _, _, _, _),
> + [46] = PINGROUP(46, tgu_ch6, _, _, _, _, _, _, _, _),
> + [47] = PINGROUP(47, hardsync_pps_in, tgu_ch7, _, _, _, _, _, _, _),
> + [48] = PINGROUP(48, tod_pps_in, qdss_cti, _, _, _, _, _, _, _),
> + [49] = PINGROUP(49, gps_pps_in, qdss_cti, _, _, _, _, _, _, _),
> + [50] = PINGROUP(50, _, _, _, _, _, _, _, _, _),
> + [51] = PINGROUP(51, _, _, _, _, _, _, _, _, _),
> + [52] = PINGROUP(52, _, _, _, _, _, _, _, _, _),
> + [53] = PINGROUP(53, _, _, _, _, _, _, _, _, _),
> + [54] = PINGROUP(54, _, _, _, _, _, _, _, _, _),
> + [55] = PINGROUP(55, _, _, _, _, _, _, _, _, _),
> + [56] = PINGROUP(56, _, qlink6_wmss, _, _, _, _, _, _, _),
> + [57] = PINGROUP(57, _, qlink7_wmss, _, _, _, _, _, _, _),
> + [58] = PINGROUP(58, _, _, _, _, _, _, _, _, _),
> + [59] = PINGROUP(59, _, _, _, _, _, _, _, _, _),
> + [60] = PINGROUP(60, _, _, _, _, _, _, _, _, _),
> + [61] = PINGROUP(61, _, _, _, _, _, _, _, _, _),
> + [62] = PINGROUP(62, _, _, _, _, _, _, _, _, _),
> + [63] = PINGROUP(63, _, _, _, _, _, _, _, _, _),
> + [64] = PINGROUP(64, _, _, _, _, _, _, _, _, _),
> + [65] = PINGROUP(65, _, _, _, _, _, _, _, _, _),
> + [66] = PINGROUP(66, qlink0_request, _, _, _, _, _, _, _, _),
> + [67] = PINGROUP(67, qlink0_enable, _, _, _, _, _, _, _, _),
> + [68] = PINGROUP(68, qlink1_request, _, _, _, _, _, _, _, _),
> + [69] = PINGROUP(69, qlink1_enable, _, _, _, _, _, _, _, _),
> + [70] = PINGROUP(70, qlink2_request, _, _, _, _, _, _, _, _),
> + [71] = PINGROUP(71, qlink2_enable, _, _, _, _, _, _, _, _),
> + [72] = PINGROUP(72, qlink3_request, _, _, _, _, _, _, _, _),
> + [73] = PINGROUP(73, qlink3_enable, _, _, _, _, _, _, _, _),
> + [74] = PINGROUP(74, qlink4_request, _, _, _, _, _, _, _, _),
> + [75] = PINGROUP(75, qlink4_enable, _, _, _, _, _, _, _, _),
> + [76] = PINGROUP(76, qlink5_request, _, _, _, _, _, _, _, _),
> + [77] = PINGROUP(77, qlink5_enable, _, _, _, _, _, _, _, _),
> + [78] = PINGROUP(78, qlink6_request, _, _, _, _, _, _, _, _),
> + [79] = PINGROUP(79, qlink6_enable, _, _, _, _, _, _, _, _),
> + [80] = PINGROUP(80, qlink7_request, _, _, _, _, _, _, _, _),
> + [81] = PINGROUP(81, qlink7_enable, _, _, _, _, _, _, _, _),
> + [82] = PINGROUP(82, qlink0_wmss, _, _, _, _, _, _, _, _),
> + [83] = PINGROUP(83, qlink1_wmss, _, _, _, _, _, _, _, _),
> + [84] = PINGROUP(84, qlink4_wmss, _, _, _, _, _, _, _, _),
> + [85] = PINGROUP(85, qlink5_wmss, _, _, _, _, _, _, _, _),
> + [86] = PINGROUP(86, eth012_int_n, gcc_gp1, _, qdss_cti, _, _, _, _, _),
> + [87] = PINGROUP(87, eth345_int_n, gcc_gp2, _, qdss_cti, _, _, _, _, _),
> + [88] = PINGROUP(88, eth6_int_n, smb_alert, gcc_gp3, _,
> + qdss_gpio, _, _, _, _),
> + [89] = PINGROUP(89, phase_flag, cmu_rng, _,
> + qdss_gpio, atest_char, _, _, _, _),
> + [90] = PINGROUP(90, usb2phy_ac, phase_flag,
> + cmu_rng, _, qdss_gpio,
> + atest_char, _, _, _),
> + [91] = PINGROUP(91, usb_phy, phase_flag, cmu_rng,
> + _, qdss_gpio, atest_char, _, _, _),
> + [92] = PINGROUP(92, phase_flag, cmu_rng, _,
> + qdss_gpio, atest_char, _, _, _, _),
> + [93] = PINGROUP(93, vfr_0, qdss_cti, _, _, _, _, _, _, _),
> + [94] = PINGROUP(94, vfr_1, qdss_cti, _, _, _, _, _, _, _),
> + [95] = PINGROUP(95, phase_flag, _, qdss_gpio,
> + atest_char, _, _, _, _, _),
> + [96] = PINGROUP(96, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
> + [97] = PINGROUP(97, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
> + [98] = PINGROUP(98, pll_clk, _, _, _, _, _, _, _, _),
> + [99] = PINGROUP(99, pcie_clkreqn, char_exec, _, _, _, _, _, _, _),
> + [100] = PINGROUP(100, char_exec, _, _, _, _, _, _, _, _),
> + [101] = PINGROUP(101, smb_alert, _, _, _, _, _, _, _, _),
> + [102] = PINGROUP(102, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
> + [103] = PINGROUP(103, CMO_PRI, qdss_gpio, _, _, _, _, _, _, _),
> + [104] = PINGROUP(104, _, _, _, _, _, _, _, _, _),
> + [105] = PINGROUP(105, _, _, _, _, _, _, _, _, _),
> + [106] = PINGROUP(106, _, _, _, _, _, _, _, _, _),
> + [107] = PINGROUP(107, _, _, _, _, _, _, _, _, _),
> + [108] = PINGROUP(108, _, _, _, _, _, _, _, _, _),
> + [109] = PINGROUP(109, _, _, _, _, _, _, _, _, _),
> + [110] = PINGROUP(110, _, _, _, _, _, _, _, _, _),
> + [111] = PINGROUP(111, _, _, _, _, _, _, _, _, _),
> + [112] = PINGROUP(112, _, _, _, _, _, _, _, _, _),
> + [113] = PINGROUP(113, _, _, _, _, _, _, _, _, _),
> + [114] = PINGROUP(114, qspi0, tb_trig, _,
> + atest_usb, ddr_pxi0, _, _, _, _),
> + [115] = PINGROUP(115, qspi1, _, atest_usb,
> + ddr_pxi0, _, _, _, _, _),
> + [116] = PINGROUP(116, qspi2, _, atest_usb,
> + ddr_pxi1, _, _, _, _, _),
> + [117] = PINGROUP(117, qspi3, _, atest_usb,
> + ddr_pxi1, _, _, _, _, _),
> + [118] = PINGROUP(118, _, atest_usb, ddr_pxi2, _, _, _, _, _, _),
> + [119] = PINGROUP(119, _, _, ddr_pxi2, _, _, _, _, _, _),
> + [120] = PINGROUP(120, _, _, ddr_pxi3, _, _, _, _, _, _),
> + [121] = PINGROUP(121, _, ddr_pxi3, _, _, _, _, _, _, _),
> + [122] = PINGROUP(122, _, ddr_pxi4, _, _, _, _, _, _, _),
> + [123] = PINGROUP(123, _, ddr_pxi4, _, _, _, _, _, _, _),
> + [124] = PINGROUP(124, _, ddr_pxi5, _, _, _, _, _, _, _),
> + [125] = PINGROUP(125, qspi_cs, _, ddr_pxi5, _, _, _, _, _, _),
> + [126] = PINGROUP(126, qspi_clk, _, ddr_pxi6, _, _, _, _, _, _),
> + [127] = PINGROUP(127, _, ddr_pxi6, _, _, _, _, _, _, _),
> + [128] = PINGROUP(128, qup22, _, ddr_pxi7, _, _, _, _, _, _),
> + [129] = PINGROUP(129, qup22, ddr_pxi7, _, _, _, _, _, _, _),
> + [130] = PINGROUP(130, qup05, qup06, jitter_bist_ref,
> + qdss_cti, _, _, _, _, _),
> + [131] = PINGROUP(131, qup05, qup06, qdss_cti, _, _, _, _, _, _),
> + [132] = PINGROUP(132, qup06, qup05, smb_dat,
> + qdss_cti, _, _, _, _, _),
> + [133] = PINGROUP(133, qup06, qup05, smb_clk,
> + qdss_cti, _, _, _, _, _),
> + [134] = PINGROUP(134, qup08, qup07, gcc_gp1, _,
> + qdss_cti, _, _, _, _),
> + [135] = PINGROUP(135, qup08, qup07, gcc_gp2, _,
> + qdss_cti, vsense_trigger, _, _, _),
> + [136] = PINGROUP(136, gcc_gp3, dbg_out_clk, _, _, _, _, _, _, _),
> + [137] = PINGROUP(137, _, _, _, _, _, _, _, _, _),
> + [138] = PINGROUP(138, qlink2_wmss, _, _, _, _, _, _, _, _),
> + [139] = PINGROUP(139, qlink3_wmss, _, _, _, _, _, _, _, _),
> + [140] = PINGROUP(140, _, _, _, _, _, _, _, _, _),
> + [141] = PINGROUP(141, intr_c, _, _, _, _, _, _, _, _),
> + [142] = PINGROUP(142, intr_c, _, _, _, _, _, _, _, _),
> + [143] = PINGROUP(143, intr_c, _, _, _, _, _, _, _, _),
> + [144] = PINGROUP(144, qdss_cti, _, _, _, _, _, _, _, _),
> + [145] = PINGROUP(145, qdss_cti, _, _, _, _, _, _, _, _),
> + [146] = PINGROUP(146, _, _, _, _, _, _, _, _, _),
> + [147] = PINGROUP(147, _, _, _, _, _, _, _, _, _),
> + [148] = PINGROUP(148, _, _, _, _, _, _, _, _, _),
> + [149] = PINGROUP(149, _, _, _, _, _, _, _, _, _),
> + [150] = PINGROUP(150, _, _, _, _, _, _, _, _, _),
> + [151] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x9e000, 0, 0),
> + [152] = SDC_QDSD_PINGROUP(sdc1_clk, 0x9d000, 13, 6),
> + [153] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x9d000, 11, 3),
> + [154] = SDC_QDSD_PINGROUP(sdc1_data, 0x9d000, 9, 0),
> +};
> +static const struct msm_pinctrl_soc_data qdu1000_tlmm = {
> + .pins = qdu1000_pins,
> + .npins = ARRAY_SIZE(qdu1000_pins),
> + .functions = qdu1000_functions,
> + .nfunctions = ARRAY_SIZE(qdu1000_functions),
> + .groups = qdu1000_groups,
> + .ngroups = ARRAY_SIZE(qdu1000_groups),
> + .ngpios = 151,
> +};
> +
> +static int qdu1000_tlmm_probe(struct platform_device *pdev)
> +{
> + return msm_pinctrl_probe(pdev, &qdu1000_tlmm);
> +}
> +
> +static const struct of_device_id qdu1000_tlmm_of_match[] = {
> + { .compatible = "qcom,qdu1000-tlmm", },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, qdu1000_tlmm_of_match);
> +
> +static struct platform_driver qdu1000_tlmm_driver = {
> + .driver = {
> + .name = "qdu1000-tlmm",
> + .of_match_table = qdu1000_tlmm_of_match,
> + },
> + .probe = qdu1000_tlmm_probe,
> + .remove = msm_pinctrl_remove,
> +};
> +
> +static int __init qdu1000_tlmm_init(void)
> +{
> + return platform_driver_register(&qdu1000_tlmm_driver);
> +}
> +arch_initcall(qdu1000_tlmm_init);
> +
> +static void __exit qdu1000_tlmm_exit(void)
> +{
> + platform_driver_unregister(&qdu1000_tlmm_driver);
> +}
> +module_exit(qdu1000_tlmm_exit);
> +
> +MODULE_DESCRIPTION("QTI QDU1000 TLMM driver");
> +MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-20 10:58 ` Krzysztof Kozlowski
@ 2022-11-21 20:38 ` Melody Olvera
2022-11-22 7:48 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Melody Olvera @ 2022-11-21 20:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 11/20/2022 4:58 AM, Krzysztof Kozlowski wrote:
> On 18/11/2022 19:20, Melody Olvera wrote:
>> Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>> .../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
>> 1 file changed, 134 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>> new file mode 100644
>> index 000000000000..cb0c496d8666
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>> @@ -0,0 +1,134 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
>> +
>> +maintainers:
>> + - Melody Olvera <quic_molvera@quicinc.com>
>> +
>> +description: |
>> + This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
>> + QRU1000 platforms.
> It's better to keep consistent style which allows to do easy
> search/replace, than to have new files using their own sentences. So
> keep it the same as was unified in few recent commits.
Ok... Just making sure that's what you want. Last PS you gave comments to change
the wording of this description to remove "This binding describes..." as we've done
in all the other qcom pinctrl/tlmm bindings. I can change the wording back to the
original, just want to be clear here.
>
>> +allOf:
>> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: qcom,qdu1000-tlmm
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts: true
>> + interrupt-controller: true
>> + "#interrupt-cells": true
>> + gpio-controller: true
>> +
>> + gpio-reserved-ranges:
>> + minItems: 1
>> + maxItems: 75
> Technically you can have up to 76 separate ranges (151 GPIOs).
Fair enough. I can fix this.
Thanks,
Melody
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver
2022-11-21 11:09 ` Konrad Dybcio
@ 2022-11-21 20:41 ` Melody Olvera
0 siblings, 0 replies; 11+ messages in thread
From: Melody Olvera @ 2022-11-21 20:41 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Linus Walleij,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 11/21/2022 5:09 AM, Konrad Dybcio wrote:
>
> On 18.11.2022 19:20, Melody Olvera wrote:
>> Add pin control driver for the TLMM block found in the QDU1000
>> and QRU1000 SoC.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
>> drivers/pinctrl/qcom/Kconfig | 10 +
>> drivers/pinctrl/qcom/Makefile | 1 +
>> drivers/pinctrl/qcom/pinctrl-qdu1000.c | 1273 ++++++++++++++++++++++++
>> 3 files changed, 1284 insertions(+)
>> create mode 100644 drivers/pinctrl/qcom/pinctrl-qdu1000.c
>>
>> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
>> index 1378ddca084f..9ff4145646a3 100644
>> --- a/drivers/pinctrl/qcom/Kconfig
>> +++ b/drivers/pinctrl/qcom/Kconfig
>> @@ -248,6 +248,16 @@ config PINCTRL_QCOM_SSBI_PMIC
>> which are using SSBI for communication with SoC. Example PMIC's
>> devices are pm8058 and pm8921.
>>
>> +config PINCTRL_QDU1000
> [...]
>
>> +DECLARE_MSM_GPIO_PINS(145);
>> +DECLARE_MSM_GPIO_PINS(146);
>> +DECLARE_MSM_GPIO_PINS(147);
>> +DECLARE_MSM_GPIO_PINS(148);
>> +DECLARE_MSM_GPIO_PINS(149);
>> +DECLARE_MSM_GPIO_PINS(150);
>> +
>> +static const unsigned int sdc1_rclk_pins[] = { 151 };
>> +static const unsigned int sdc1_clk_pins[] = { 152 };
>> +static const unsigned int sdc1_cmd_pins[] = { 153 };
>> +static const unsigned int sdc1_data_pins[] = { 154 };
>> +
>> +enum qdu1000_functions {
>> + msm_mux_gpio,
>> + msm_mux_CMO_PRI,
>> + msm_mux_SI5518_INT,
> Any reason these two are uppercase?
They're new functions. There's not really any other reason; I can make them lower case.
Thanks,
Melody
>
> Konrad
>> + msm_mux_atest_char,
>> + msm_mux_atest_usb,
>> + msm_mux_char_exec,
>> + msm_mux_cmu_rng,
>> + msm_mux_dbg_out_clk,
>> + msm_mux_ddr_bist,
>> + msm_mux_ddr_pxi0,
>> + msm_mux_ddr_pxi1,
>> + msm_mux_ddr_pxi2,
>> + msm_mux_ddr_pxi3,
> [...]
>
>> +
>> +/* Every pin is maintained as a single group, and missing or non-existing pin
> /*
> * Every pin...
>
> Konrad
>> + * would be maintained as dummy group to synchronize pin group index with
>> + * pin descriptor registered with pinctrl core.
>> + * Clients would not be able to request these dummy pin groups.
>> + */
>> +static const struct msm_pingroup qdu1000_groups[] = {
>> + [0] = PINGROUP(0, qup20, qup21, ddr_bist, _, _, _, _, _, _),
>> + [1] = PINGROUP(1, qup20, qup21, ddr_bist, _, _, _, _, _, _),
>> + [2] = PINGROUP(2, qup21, qup20, ddr_bist, _,
>> + tsense_pwm1, _, _, _, _),
>> + [3] = PINGROUP(3, qup21, qup20, ddr_bist, _,
>> + tsense_pwm2, _, _, _, _),
>> + [4] = PINGROUP(4, qup22, _, _, _, _, _, _, _, _),
>> + [5] = PINGROUP(5, qup22, _, _, _, _, _, _, _, _),
>> + [6] = PINGROUP(6, qup00, tgu_ch0, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [7] = PINGROUP(7, qup00, tgu_ch1, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [8] = PINGROUP(8, qup00, tgu_ch2, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [9] = PINGROUP(9, qup00, tgu_ch3, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [10] = PINGROUP(10, qup01, qup02, _, _, _, _, _, _, _),
>> + [11] = PINGROUP(11, qup01, qup02, _, _, _, _, _, _, _),
>> + [12] = PINGROUP(12, qup02, qup01, qup17, _, _, _, _, _, _),
>> + [13] = PINGROUP(13, qup02, qup01, qup17, _, _, _, _, _, _),
>> + [14] = PINGROUP(14, qup03, qup04, qup17, _, _, _, _, _, _),
>> + [15] = PINGROUP(15, qup03, qup04, _, _, _, _, _, _, _),
>> + [16] = PINGROUP(16, qup04, qup03, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [17] = PINGROUP(17, qup04, qup03, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [18] = PINGROUP(18, qup10, prng_rosc, phase_flag,
>> + _, qdss_gpio, _, _, _, _),
>> + [19] = PINGROUP(19, qup10, prng_rosc, phase_flag,
>> + _, qdss_gpio, _, _, _, _),
>> + [20] = PINGROUP(20, qup10, prng_rosc, pll_bist,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [21] = PINGROUP(21, qup10, prng_rosc, phase_flag,
>> + _, qdss_gpio, _, _, _, _),
>> + [22] = PINGROUP(22, qup11, qup12, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [23] = PINGROUP(23, qup11, qup12, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [24] = PINGROUP(24, qup12, qup11, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [25] = PINGROUP(25, qup12, qup11, phase_flag, _,
>> + qdss_gpio, _, _, _, _),
>> + [26] = PINGROUP(26, qup13, qup14, intr_c,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [27] = PINGROUP(27, qup13, qup14, intr_c,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [28] = PINGROUP(28, qup14, qup13, intr_c,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [29] = PINGROUP(29, qup14, qup13, qup16,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [30] = PINGROUP(30, qup17, qup15, tmess_prng3,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [31] = PINGROUP(31, qup17, qup15, tmess_prng2,
>> + phase_flag, _, qdss_gpio, _, _, _),
>> + [32] = PINGROUP(32, qup15, tmess_prng1, phase_flag,
>> + _, qdss_gpio, _, _, _, _),
>> + [33] = PINGROUP(33, qup15, tmess_prng0, phase_flag,
>> + _, qdss_gpio, _, _, _, _),
>> + [34] = PINGROUP(34, qup16, qdss_gpio, _, _, _, _, _, _, _),
>> + [35] = PINGROUP(35, qup16, qdss_gpio, _, _, _, _, _, _, _),
>> + [36] = PINGROUP(36, qup16, qdss_cti, _, _, _, _, _, _, _),
>> + [37] = PINGROUP(37, qup16, qdss_cti, _, _, _, _, _, _, _),
>> + [38] = PINGROUP(38, qup16, qdss_cti, _, _, _, _, _, _, _),
>> + [39] = PINGROUP(39, qup16, qdss_cti, _, _, _, _, _, _, _),
>> + [40] = PINGROUP(40, qup17, qdss_cti, _, _, _, _, _, _, _),
>> + [41] = PINGROUP(41, qup17, qdss_cti, _, _, _, _, _, _, _),
>> + [42] = PINGROUP(42, usb_con_det, phase_flag, _,
>> + qdss_gpio, _, _, _, _, _),
>> + [43] = PINGROUP(43, usb_dfp_en, phase_flag, _,
>> + qdss_gpio, _, _, _, _, _),
>> + [44] = PINGROUP(44, SI5518_INT, tgu_ch4, _, _, _, _, _, _, _),
>> + [45] = PINGROUP(45, tgu_ch5, _, _, _, _, _, _, _, _),
>> + [46] = PINGROUP(46, tgu_ch6, _, _, _, _, _, _, _, _),
>> + [47] = PINGROUP(47, hardsync_pps_in, tgu_ch7, _, _, _, _, _, _, _),
>> + [48] = PINGROUP(48, tod_pps_in, qdss_cti, _, _, _, _, _, _, _),
>> + [49] = PINGROUP(49, gps_pps_in, qdss_cti, _, _, _, _, _, _, _),
>> + [50] = PINGROUP(50, _, _, _, _, _, _, _, _, _),
>> + [51] = PINGROUP(51, _, _, _, _, _, _, _, _, _),
>> + [52] = PINGROUP(52, _, _, _, _, _, _, _, _, _),
>> + [53] = PINGROUP(53, _, _, _, _, _, _, _, _, _),
>> + [54] = PINGROUP(54, _, _, _, _, _, _, _, _, _),
>> + [55] = PINGROUP(55, _, _, _, _, _, _, _, _, _),
>> + [56] = PINGROUP(56, _, qlink6_wmss, _, _, _, _, _, _, _),
>> + [57] = PINGROUP(57, _, qlink7_wmss, _, _, _, _, _, _, _),
>> + [58] = PINGROUP(58, _, _, _, _, _, _, _, _, _),
>> + [59] = PINGROUP(59, _, _, _, _, _, _, _, _, _),
>> + [60] = PINGROUP(60, _, _, _, _, _, _, _, _, _),
>> + [61] = PINGROUP(61, _, _, _, _, _, _, _, _, _),
>> + [62] = PINGROUP(62, _, _, _, _, _, _, _, _, _),
>> + [63] = PINGROUP(63, _, _, _, _, _, _, _, _, _),
>> + [64] = PINGROUP(64, _, _, _, _, _, _, _, _, _),
>> + [65] = PINGROUP(65, _, _, _, _, _, _, _, _, _),
>> + [66] = PINGROUP(66, qlink0_request, _, _, _, _, _, _, _, _),
>> + [67] = PINGROUP(67, qlink0_enable, _, _, _, _, _, _, _, _),
>> + [68] = PINGROUP(68, qlink1_request, _, _, _, _, _, _, _, _),
>> + [69] = PINGROUP(69, qlink1_enable, _, _, _, _, _, _, _, _),
>> + [70] = PINGROUP(70, qlink2_request, _, _, _, _, _, _, _, _),
>> + [71] = PINGROUP(71, qlink2_enable, _, _, _, _, _, _, _, _),
>> + [72] = PINGROUP(72, qlink3_request, _, _, _, _, _, _, _, _),
>> + [73] = PINGROUP(73, qlink3_enable, _, _, _, _, _, _, _, _),
>> + [74] = PINGROUP(74, qlink4_request, _, _, _, _, _, _, _, _),
>> + [75] = PINGROUP(75, qlink4_enable, _, _, _, _, _, _, _, _),
>> + [76] = PINGROUP(76, qlink5_request, _, _, _, _, _, _, _, _),
>> + [77] = PINGROUP(77, qlink5_enable, _, _, _, _, _, _, _, _),
>> + [78] = PINGROUP(78, qlink6_request, _, _, _, _, _, _, _, _),
>> + [79] = PINGROUP(79, qlink6_enable, _, _, _, _, _, _, _, _),
>> + [80] = PINGROUP(80, qlink7_request, _, _, _, _, _, _, _, _),
>> + [81] = PINGROUP(81, qlink7_enable, _, _, _, _, _, _, _, _),
>> + [82] = PINGROUP(82, qlink0_wmss, _, _, _, _, _, _, _, _),
>> + [83] = PINGROUP(83, qlink1_wmss, _, _, _, _, _, _, _, _),
>> + [84] = PINGROUP(84, qlink4_wmss, _, _, _, _, _, _, _, _),
>> + [85] = PINGROUP(85, qlink5_wmss, _, _, _, _, _, _, _, _),
>> + [86] = PINGROUP(86, eth012_int_n, gcc_gp1, _, qdss_cti, _, _, _, _, _),
>> + [87] = PINGROUP(87, eth345_int_n, gcc_gp2, _, qdss_cti, _, _, _, _, _),
>> + [88] = PINGROUP(88, eth6_int_n, smb_alert, gcc_gp3, _,
>> + qdss_gpio, _, _, _, _),
>> + [89] = PINGROUP(89, phase_flag, cmu_rng, _,
>> + qdss_gpio, atest_char, _, _, _, _),
>> + [90] = PINGROUP(90, usb2phy_ac, phase_flag,
>> + cmu_rng, _, qdss_gpio,
>> + atest_char, _, _, _),
>> + [91] = PINGROUP(91, usb_phy, phase_flag, cmu_rng,
>> + _, qdss_gpio, atest_char, _, _, _),
>> + [92] = PINGROUP(92, phase_flag, cmu_rng, _,
>> + qdss_gpio, atest_char, _, _, _, _),
>> + [93] = PINGROUP(93, vfr_0, qdss_cti, _, _, _, _, _, _, _),
>> + [94] = PINGROUP(94, vfr_1, qdss_cti, _, _, _, _, _, _, _),
>> + [95] = PINGROUP(95, phase_flag, _, qdss_gpio,
>> + atest_char, _, _, _, _, _),
>> + [96] = PINGROUP(96, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
>> + [97] = PINGROUP(97, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
>> + [98] = PINGROUP(98, pll_clk, _, _, _, _, _, _, _, _),
>> + [99] = PINGROUP(99, pcie_clkreqn, char_exec, _, _, _, _, _, _, _),
>> + [100] = PINGROUP(100, char_exec, _, _, _, _, _, _, _, _),
>> + [101] = PINGROUP(101, smb_alert, _, _, _, _, _, _, _, _),
>> + [102] = PINGROUP(102, phase_flag, _, qdss_gpio, _, _, _, _, _, _),
>> + [103] = PINGROUP(103, CMO_PRI, qdss_gpio, _, _, _, _, _, _, _),
>> + [104] = PINGROUP(104, _, _, _, _, _, _, _, _, _),
>> + [105] = PINGROUP(105, _, _, _, _, _, _, _, _, _),
>> + [106] = PINGROUP(106, _, _, _, _, _, _, _, _, _),
>> + [107] = PINGROUP(107, _, _, _, _, _, _, _, _, _),
>> + [108] = PINGROUP(108, _, _, _, _, _, _, _, _, _),
>> + [109] = PINGROUP(109, _, _, _, _, _, _, _, _, _),
>> + [110] = PINGROUP(110, _, _, _, _, _, _, _, _, _),
>> + [111] = PINGROUP(111, _, _, _, _, _, _, _, _, _),
>> + [112] = PINGROUP(112, _, _, _, _, _, _, _, _, _),
>> + [113] = PINGROUP(113, _, _, _, _, _, _, _, _, _),
>> + [114] = PINGROUP(114, qspi0, tb_trig, _,
>> + atest_usb, ddr_pxi0, _, _, _, _),
>> + [115] = PINGROUP(115, qspi1, _, atest_usb,
>> + ddr_pxi0, _, _, _, _, _),
>> + [116] = PINGROUP(116, qspi2, _, atest_usb,
>> + ddr_pxi1, _, _, _, _, _),
>> + [117] = PINGROUP(117, qspi3, _, atest_usb,
>> + ddr_pxi1, _, _, _, _, _),
>> + [118] = PINGROUP(118, _, atest_usb, ddr_pxi2, _, _, _, _, _, _),
>> + [119] = PINGROUP(119, _, _, ddr_pxi2, _, _, _, _, _, _),
>> + [120] = PINGROUP(120, _, _, ddr_pxi3, _, _, _, _, _, _),
>> + [121] = PINGROUP(121, _, ddr_pxi3, _, _, _, _, _, _, _),
>> + [122] = PINGROUP(122, _, ddr_pxi4, _, _, _, _, _, _, _),
>> + [123] = PINGROUP(123, _, ddr_pxi4, _, _, _, _, _, _, _),
>> + [124] = PINGROUP(124, _, ddr_pxi5, _, _, _, _, _, _, _),
>> + [125] = PINGROUP(125, qspi_cs, _, ddr_pxi5, _, _, _, _, _, _),
>> + [126] = PINGROUP(126, qspi_clk, _, ddr_pxi6, _, _, _, _, _, _),
>> + [127] = PINGROUP(127, _, ddr_pxi6, _, _, _, _, _, _, _),
>> + [128] = PINGROUP(128, qup22, _, ddr_pxi7, _, _, _, _, _, _),
>> + [129] = PINGROUP(129, qup22, ddr_pxi7, _, _, _, _, _, _, _),
>> + [130] = PINGROUP(130, qup05, qup06, jitter_bist_ref,
>> + qdss_cti, _, _, _, _, _),
>> + [131] = PINGROUP(131, qup05, qup06, qdss_cti, _, _, _, _, _, _),
>> + [132] = PINGROUP(132, qup06, qup05, smb_dat,
>> + qdss_cti, _, _, _, _, _),
>> + [133] = PINGROUP(133, qup06, qup05, smb_clk,
>> + qdss_cti, _, _, _, _, _),
>> + [134] = PINGROUP(134, qup08, qup07, gcc_gp1, _,
>> + qdss_cti, _, _, _, _),
>> + [135] = PINGROUP(135, qup08, qup07, gcc_gp2, _,
>> + qdss_cti, vsense_trigger, _, _, _),
>> + [136] = PINGROUP(136, gcc_gp3, dbg_out_clk, _, _, _, _, _, _, _),
>> + [137] = PINGROUP(137, _, _, _, _, _, _, _, _, _),
>> + [138] = PINGROUP(138, qlink2_wmss, _, _, _, _, _, _, _, _),
>> + [139] = PINGROUP(139, qlink3_wmss, _, _, _, _, _, _, _, _),
>> + [140] = PINGROUP(140, _, _, _, _, _, _, _, _, _),
>> + [141] = PINGROUP(141, intr_c, _, _, _, _, _, _, _, _),
>> + [142] = PINGROUP(142, intr_c, _, _, _, _, _, _, _, _),
>> + [143] = PINGROUP(143, intr_c, _, _, _, _, _, _, _, _),
>> + [144] = PINGROUP(144, qdss_cti, _, _, _, _, _, _, _, _),
>> + [145] = PINGROUP(145, qdss_cti, _, _, _, _, _, _, _, _),
>> + [146] = PINGROUP(146, _, _, _, _, _, _, _, _, _),
>> + [147] = PINGROUP(147, _, _, _, _, _, _, _, _, _),
>> + [148] = PINGROUP(148, _, _, _, _, _, _, _, _, _),
>> + [149] = PINGROUP(149, _, _, _, _, _, _, _, _, _),
>> + [150] = PINGROUP(150, _, _, _, _, _, _, _, _, _),
>> + [151] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x9e000, 0, 0),
>> + [152] = SDC_QDSD_PINGROUP(sdc1_clk, 0x9d000, 13, 6),
>> + [153] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x9d000, 11, 3),
>> + [154] = SDC_QDSD_PINGROUP(sdc1_data, 0x9d000, 9, 0),
>> +};
>> +static const struct msm_pinctrl_soc_data qdu1000_tlmm = {
>> + .pins = qdu1000_pins,
>> + .npins = ARRAY_SIZE(qdu1000_pins),
>> + .functions = qdu1000_functions,
>> + .nfunctions = ARRAY_SIZE(qdu1000_functions),
>> + .groups = qdu1000_groups,
>> + .ngroups = ARRAY_SIZE(qdu1000_groups),
>> + .ngpios = 151,
>> +};
>> +
>> +static int qdu1000_tlmm_probe(struct platform_device *pdev)
>> +{
>> + return msm_pinctrl_probe(pdev, &qdu1000_tlmm);
>> +}
>> +
>> +static const struct of_device_id qdu1000_tlmm_of_match[] = {
>> + { .compatible = "qcom,qdu1000-tlmm", },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, qdu1000_tlmm_of_match);
>> +
>> +static struct platform_driver qdu1000_tlmm_driver = {
>> + .driver = {
>> + .name = "qdu1000-tlmm",
>> + .of_match_table = qdu1000_tlmm_of_match,
>> + },
>> + .probe = qdu1000_tlmm_probe,
>> + .remove = msm_pinctrl_remove,
>> +};
>> +
>> +static int __init qdu1000_tlmm_init(void)
>> +{
>> + return platform_driver_register(&qdu1000_tlmm_driver);
>> +}
>> +arch_initcall(qdu1000_tlmm_init);
>> +
>> +static void __exit qdu1000_tlmm_exit(void)
>> +{
>> + platform_driver_unregister(&qdu1000_tlmm_driver);
>> +}
>> +module_exit(qdu1000_tlmm_exit);
>> +
>> +MODULE_DESCRIPTION("QTI QDU1000 TLMM driver");
>> +MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-21 20:38 ` Melody Olvera
@ 2022-11-22 7:48 ` Krzysztof Kozlowski
2022-11-22 15:23 ` Melody Olvera
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-22 7:48 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 21/11/2022 21:38, Melody Olvera wrote:
>
>
> On 11/20/2022 4:58 AM, Krzysztof Kozlowski wrote:
>> On 18/11/2022 19:20, Melody Olvera wrote:
>>> Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>>> .../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
>>> 1 file changed, 134 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>> new file mode 100644
>>> index 000000000000..cb0c496d8666
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>> @@ -0,0 +1,134 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
>>> +
>>> +maintainers:
>>> + - Melody Olvera <quic_molvera@quicinc.com>
>>> +
>>> +description: |
>>> + This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
>>> + QRU1000 platforms.
>> It's better to keep consistent style which allows to do easy
>> search/replace, than to have new files using their own sentences. So
>> keep it the same as was unified in few recent commits.
>
> Ok... Just making sure that's what you want. Last PS you gave comments to change
> the wording of this description to remove "This binding describes..." as we've done
> in all the other qcom pinctrl/tlmm bindings. I can change the wording back to the
> original, just want to be clear here.
I propose to have the same wording as other Qualcomm TLMM bindings,
however you changed it to something not the same. Therefore I wonder -
why having here different wording than all other bindings?
By going back to original - what do you mean? If it matches all others,
then yes, but I doubt it.
Just to be sure - are you working on proper (recent) trees or something old?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-22 7:48 ` Krzysztof Kozlowski
@ 2022-11-22 15:23 ` Melody Olvera
2022-11-23 8:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Melody Olvera @ 2022-11-22 15:23 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 11/22/2022 1:48 AM, Krzysztof Kozlowski wrote:
> On 21/11/2022 21:38, Melody Olvera wrote:
>>
>> On 11/20/2022 4:58 AM, Krzysztof Kozlowski wrote:
>>> On 18/11/2022 19:20, Melody Olvera wrote:
>>>> Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
>>>>
>>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>>> ---
>>>> .../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
>>>> 1 file changed, 134 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>> new file mode 100644
>>>> index 000000000000..cb0c496d8666
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>> @@ -0,0 +1,134 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
>>>> +
>>>> +maintainers:
>>>> + - Melody Olvera <quic_molvera@quicinc.com>
>>>> +
>>>> +description: |
>>>> + This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
>>>> + QRU1000 platforms.
>>> It's better to keep consistent style which allows to do easy
>>> search/replace, than to have new files using their own sentences. So
>>> keep it the same as was unified in few recent commits.
>> Ok... Just making sure that's what you want. Last PS you gave comments to change
>> the wording of this description to remove "This binding describes..." as we've done
>> in all the other qcom pinctrl/tlmm bindings. I can change the wording back to the
>> original, just want to be clear here.
> I propose to have the same wording as other Qualcomm TLMM bindings,
> however you changed it to something not the same. Therefore I wonder -
> why having here different wording than all other bindings?
>
> By going back to original - what do you mean? If it matches all others,
> then yes, but I doubt it.
>
> Just to be sure - are you working on proper (recent) trees or something old?
Original matched how it was done on other Qualcomm TLMM bindings. Feedback
was to drop "This binding describes..." from [1], but all the Qualcomm TLMM
bindings start with "This binding describes...". I'm looking at qcom tree for-next
branch; should be recent, no?
[1] https://lore.kernel.org/all/37c53d8c-2810-509a-7404-7ca24d79fed8@linaro.org/
Thanks,
Melody
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-22 15:23 ` Melody Olvera
@ 2022-11-23 8:06 ` Krzysztof Kozlowski
2022-11-23 17:30 ` Melody Olvera
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-23 8:06 UTC (permalink / raw)
To: Melody Olvera, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 22/11/2022 16:23, Melody Olvera wrote:
>
>
> On 11/22/2022 1:48 AM, Krzysztof Kozlowski wrote:
>> On 21/11/2022 21:38, Melody Olvera wrote:
>>>
>>> On 11/20/2022 4:58 AM, Krzysztof Kozlowski wrote:
>>>> On 18/11/2022 19:20, Melody Olvera wrote:
>>>>> Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
>>>>>
>>>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>>>> ---
>>>>> .../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
>>>>> 1 file changed, 134 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..cb0c496d8666
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>> @@ -0,0 +1,134 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
>>>>> +
>>>>> +maintainers:
>>>>> + - Melody Olvera <quic_molvera@quicinc.com>
>>>>> +
>>>>> +description: |
>>>>> + This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
>>>>> + QRU1000 platforms.
>>>> It's better to keep consistent style which allows to do easy
>>>> search/replace, than to have new files using their own sentences. So
>>>> keep it the same as was unified in few recent commits.
>>> Ok... Just making sure that's what you want. Last PS you gave comments to change
>>> the wording of this description to remove "This binding describes..." as we've done
>>> in all the other qcom pinctrl/tlmm bindings. I can change the wording back to the
>>> original, just want to be clear here.
>> I propose to have the same wording as other Qualcomm TLMM bindings,
>> however you changed it to something not the same. Therefore I wonder -
>> why having here different wording than all other bindings?
>>
>> By going back to original - what do you mean? If it matches all others,
>> then yes, but I doubt it.
>>
>> Just to be sure - are you working on proper (recent) trees or something old?
>
> Original matched how it was done on other Qualcomm TLMM bindings. Feedback
> was to drop "This binding describes..." from [1], but all the Qualcomm TLMM
> bindings start with "This binding describes...". I'm looking at qcom tree for-next
> branch; should be recent, no?
No. It's not recent for anything else than managed by Bjorn. You need to
base the patches on maintainer's trees, which is usually the easiest to
achieve via linux-next (especially that these changes were in my tree
for some time before I sent them to Linus).
Your all other patches might have similar issues - wrong base or not
good example/starting point.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl
2022-11-23 8:06 ` Krzysztof Kozlowski
@ 2022-11-23 17:30 ` Melody Olvera
0 siblings, 0 replies; 11+ messages in thread
From: Melody Olvera @ 2022-11-23 17:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 11/23/2022 2:06 AM, Krzysztof Kozlowski wrote:
> On 22/11/2022 16:23, Melody Olvera wrote:
>>
>> On 11/22/2022 1:48 AM, Krzysztof Kozlowski wrote:
>>> On 21/11/2022 21:38, Melody Olvera wrote:
>>>> On 11/20/2022 4:58 AM, Krzysztof Kozlowski wrote:
>>>>> On 18/11/2022 19:20, Melody Olvera wrote:
>>>>>> Add device tree bindings for QDU1000 and QRU1000 TLMM devices.
>>>>>>
>>>>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>>>>> ---
>>>>>> .../bindings/pinctrl/qcom,qdu1000-tlmm.yaml | 134 ++++++++++++++++++
>>>>>> 1 file changed, 134 insertions(+)
>>>>>> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..cb0c496d8666
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qdu1000-tlmm.yaml
>>>>>> @@ -0,0 +1,134 @@
>>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>>> +%YAML 1.2
>>>>>> +---
>>>>>> +$id: http://devicetree.org/schemas/pinctrl/qcom,qdu1000-tlmm.yaml#
>>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>>> +
>>>>>> +title: Qualcomm Technologies, Inc. QDU1000/QRU1000 TLMM block
>>>>>> +
>>>>>> +maintainers:
>>>>>> + - Melody Olvera <quic_molvera@quicinc.com>
>>>>>> +
>>>>>> +description: |
>>>>>> + This Top Level Mode Multiplexer block (TLMM) is found in the QDU1000 and
>>>>>> + QRU1000 platforms.
>>>>> It's better to keep consistent style which allows to do easy
>>>>> search/replace, than to have new files using their own sentences. So
>>>>> keep it the same as was unified in few recent commits.
>>>> Ok... Just making sure that's what you want. Last PS you gave comments to change
>>>> the wording of this description to remove "This binding describes..." as we've done
>>>> in all the other qcom pinctrl/tlmm bindings. I can change the wording back to the
>>>> original, just want to be clear here.
>>> I propose to have the same wording as other Qualcomm TLMM bindings,
>>> however you changed it to something not the same. Therefore I wonder -
>>> why having here different wording than all other bindings?
>>>
>>> By going back to original - what do you mean? If it matches all others,
>>> then yes, but I doubt it.
>>>
>>> Just to be sure - are you working on proper (recent) trees or something old?
>> Original matched how it was done on other Qualcomm TLMM bindings. Feedback
>> was to drop "This binding describes..." from [1], but all the Qualcomm TLMM
>> bindings start with "This binding describes...". I'm looking at qcom tree for-next
>> branch; should be recent, no?
> No. It's not recent for anything else than managed by Bjorn. You need to
> base the patches on maintainer's trees, which is usually the easiest to
> achieve via linux-next (especially that these changes were in my tree
> for some time before I sent them to Linus).
Ah ok; looking at linux-next looks like it should be "Top Level Mode Multiplexer pin
controller in Qualcomm QDU1000 and QRU1000 SoCs."
Thanks,
Melody
>
> Your all other patches might have similar issues - wrong base or not
> good example/starting point.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-23 17:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 18:20 [PATCH v4 0/2] Add pinctrl support for QDU1000/QRU1000 SoCs Melody Olvera
2022-11-18 18:20 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add QDU1000 and QRU1000 pinctrl Melody Olvera
2022-11-20 10:58 ` Krzysztof Kozlowski
2022-11-21 20:38 ` Melody Olvera
2022-11-22 7:48 ` Krzysztof Kozlowski
2022-11-22 15:23 ` Melody Olvera
2022-11-23 8:06 ` Krzysztof Kozlowski
2022-11-23 17:30 ` Melody Olvera
2022-11-18 18:20 ` [PATCH v4 2/2] pinctrl: qcom: Add QDU1000/QRU1000 pinctrl driver Melody Olvera
2022-11-21 11:09 ` Konrad Dybcio
2022-11-21 20:41 ` Melody Olvera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).