* [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set
@ 2022-11-19 5:51 Randy Dunlap
2022-11-23 18:53 ` Liam Howlett
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-11-19 5:51 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Geert Uytterhoeven, kernel test robot,
Liam Howlett, Andrew Morton, linux-mm
Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
"depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
any kconfig dependencies.
WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
Depends on [n]: DEBUG_KERNEL [=n]
Selected by [y]:
- TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2259,6 +2259,7 @@ config TEST_XARRAY
tristate "Test the XArray code at runtime"
config TEST_MAPLE_TREE
+ depends on DEBUG_KERNEL
select DEBUG_MAPLE_TREE
tristate "Test the Maple Tree code at runtime"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set
2022-11-19 5:51 [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set Randy Dunlap
@ 2022-11-23 18:53 ` Liam Howlett
0 siblings, 0 replies; 2+ messages in thread
From: Liam Howlett @ 2022-11-23 18:53 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Geert Uytterhoeven, kernel test robot,
Andrew Morton, linux-mm
Thanks Randy. I'm going to look into doing as Geert requested and avoid
pulling in dependencies, but this is the right thing to do for now.
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
* Randy Dunlap <rdunlap@infradead.org> [221119 00:51]:
> Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
> "depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
> any kconfig dependencies.
>
> WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
> Depends on [n]: DEBUG_KERNEL [=n]
> Selected by [y]:
> - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Liam Howlett <liam.howlett@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2259,6 +2259,7 @@ config TEST_XARRAY
> tristate "Test the XArray code at runtime"
>
> config TEST_MAPLE_TREE
> + depends on DEBUG_KERNEL
> select DEBUG_MAPLE_TREE
> tristate "Test the Maple Tree code at runtime"
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-23 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-19 5:51 [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set Randy Dunlap
2022-11-23 18:53 ` Liam Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).