* [PATCH] ALSA: asihpi: fix missing pci_disable_device()
@ 2022-11-26 2:14 Liu Shixin
2022-11-28 13:54 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Liu Shixin @ 2022-11-26 2:14 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: alsa-devel, linux-kernel, Liu Shixin
pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release().
Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.")
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
sound/pci/asihpi/hpioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/asihpi/hpioctl.c b/sound/pci/asihpi/hpioctl.c
index bb31b7fe867d..477a5b4b50bc 100644
--- a/sound/pci/asihpi/hpioctl.c
+++ b/sound/pci/asihpi/hpioctl.c
@@ -361,7 +361,7 @@ int asihpi_adapter_probe(struct pci_dev *pci_dev,
pci_dev->device, pci_dev->subsystem_vendor,
pci_dev->subsystem_device, pci_dev->devfn);
- if (pci_enable_device(pci_dev) < 0) {
+ if (pcim_enable_device(pci_dev) < 0) {
dev_err(&pci_dev->dev,
"pci_enable_device failed, disabling device\n");
return -EIO;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: asihpi: fix missing pci_disable_device()
2022-11-26 2:14 [PATCH] ALSA: asihpi: fix missing pci_disable_device() Liu Shixin
@ 2022-11-28 13:54 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-11-28 13:54 UTC (permalink / raw)
To: Liu Shixin; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
On Sat, 26 Nov 2022 03:14:29 +0100,
Liu Shixin wrote:
>
> pci_disable_device() need be called while module exiting, switch to use
> pcim_enable(), pci_disable_device() will be called in pcim_release().
>
> Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.")
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-28 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-26 2:14 [PATCH] ALSA: asihpi: fix missing pci_disable_device() Liu Shixin
2022-11-28 13:54 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).