From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: kirill.shutemov@linux.intel.com
Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
jpoimboe@kernel.org, linux-kernel@vger.kernel.org,
mailhol.vincent@wanadoo.fr, mingo@redhat.com,
pbonzini@redhat.com, rostedt@goodmis.org,
sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
tglx@linutronix.de, viro@zeniv.linux.org.uk, x86@kernel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c
Date: Mon, 28 Nov 2022 19:11:17 +0900 [thread overview]
Message-ID: <20221128101117.3614401-1-mailhol.vincent@wanadoo.fr> (raw)
In-Reply-To: <20221128091506.gp4l6klznqhigjxv@box.shutemov.name>
On Mon, 28 Nov 2022 12:15:06 +0300, Kirill A. Shutemov wrote:
> On Sun, Nov 27, 2022 at 03:23:35PM +0900, Vincent Mailhol wrote:
> > Following [1], the macro COMPILE_OFFSETS becomes unused:
>
> Really? I see #ifdef COMPILE_OFFSETS in ftrace.h. Hm?
>
> Have you tested your patch with CONFIG_FTRACE_SYSCALLS=y and
> CONFIG_IA32_EMULATION=y?
Even if I activate those two configurations, the compiler still
tells me it is unused:
$ grep -E "CONFIG_FTRACE_SYSCALLS|CONFIG_IA32_EMULATION" .config
CONFIG_IA32_EMULATION=y
CONFIG_FTRACE_SYSCALLS=y
$ make W=2 arch/x86/kernel/asm-offsets.o
<...>
arch/x86/kernel/asm-offsets.c:7: warning: macro "COMPILE_OFFSETS" is not used [-Wunused-macros]
<...>
> > $ make W=2 arch/x86/kernel/asm-offsets.o
> > <...>
> > arch/x86/kernel/asm-offsets.c:7: warning: macro "COMPILE_OFFSETS" is not used [-Wunused-macros]
> > <...>
> >
> > Remove COMPILE_OFFSETS macro.
> >
> > [1] commit debc5a1ec0d1 ("KVM: x86: use a separate asm-offsets.c file")
> > Link: https://git.kernel.org/torvalds/linux/c/debc5a1ec0d1
> >
> > Fixes: debc5a1ec0d1 ("KVM: x86: use a separate asm-offsets.c file")
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > ---
> > arch/x86/kernel/asm-offsets.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c
> > index 437308004ef2..cf2e02bafbef 100644
> > --- a/arch/x86/kernel/asm-offsets.c
> > +++ b/arch/x86/kernel/asm-offsets.c
> > @@ -4,7 +4,6 @@
> > * This code generates raw asm output which is post-processed to extract
> > * and format the required data.
> > */
> > -#define COMPILE_OFFSETS
> >
> > #include <linux/crypto.h>
> > #include <linux/sched.h>
next prev parent reply other threads:[~2022-11-28 10:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 6:23 [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c Vincent Mailhol
2022-11-28 9:15 ` Kirill A . Shutemov
2022-11-28 10:11 ` Vincent Mailhol [this message]
2022-11-28 11:11 ` kirill.shutemov
2022-11-28 11:30 ` Vincent MAILHOL
2022-11-28 17:45 ` Steven Rostedt
2022-11-28 18:00 ` Paolo Bonzini
2022-11-28 18:06 ` Sean Christopherson
2022-11-28 19:10 ` Steven Rostedt
2022-11-29 10:14 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128101117.3614401-1-mailhol.vincent@wanadoo.fr \
--to=mailhol.vincent@wanadoo.fr \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).