From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kirill.shutemov@linux.intel.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, jpoimboe@kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
sathyanarayanan.kuppuswamy@linux.intel.com, tglx@linutronix.de,
viro@zeniv.linux.org.uk, x86@kernel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c
Date: Tue, 29 Nov 2022 19:14:43 +0900 [thread overview]
Message-ID: <CAMZ6Rq+fb0AkmeBQwQY32d=_ihAPsN1NR5scerBJ2m5hqn7mLQ@mail.gmail.com> (raw)
In-Reply-To: <20221128141056.29ccafd6@gandalf.local.home>
On Tue. 29 Nov. 2022 at 04:10, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 28 Nov 2022 18:06:18 +0000
> Sean Christopherson <seanjc@google.com> wrote:
>
> > > > IIRC, the reason for adding that was because that logic was screwing up
> > > > asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
> > > >
> > > > This is one of those cases I wish I commented that code better :-/
> > >
> > > I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all.
> >
> > >From include/linux/kvm_host.h
> >
> > #include <linux/ftrace.h>
> >
> > Even if that didn't exist, saying that XYZ never includes a header is a dangerous
> > business, it's all too easy to indirectly include headers in the kernel, now or
> > in the future.
ACK. This is why I relied on the compiler's -Wunused-macros to assert
that COMPILE_OFFSETS can be removed from asm-offsets.c but not from
kvm-asm-offsets.c.
I also asserted that it is
https://git.kernel.org/torvalds/linux/c/debc5a1ec0d1 which removed the
dependency.
> But going back to the original intent of COMPILE_OFFSETS. I believe it was
> because some code that did not work with the auto generation of compiler
> offsets and was a way to hide them.
>
> I do not know if it is still an issue or not today.
This I do not know. I only have the confidence to remove
COMPILE_OFFSETS from asm-offsets.c. Nothing more.
prev parent reply other threads:[~2022-11-29 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 6:23 [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c Vincent Mailhol
2022-11-28 9:15 ` Kirill A . Shutemov
2022-11-28 10:11 ` Vincent Mailhol
2022-11-28 11:11 ` kirill.shutemov
2022-11-28 11:30 ` Vincent MAILHOL
2022-11-28 17:45 ` Steven Rostedt
2022-11-28 18:00 ` Paolo Bonzini
2022-11-28 18:06 ` Sean Christopherson
2022-11-28 19:10 ` Steven Rostedt
2022-11-29 10:14 ` Vincent MAILHOL [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6Rq+fb0AkmeBQwQY32d=_ihAPsN1NR5scerBJ2m5hqn7mLQ@mail.gmail.com' \
--to=mailhol.vincent@wanadoo.fr \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).