* [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes
@ 2022-11-28 11:20 AngeloGioacchino Del Regno
2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-28 11:20 UTC (permalink / raw)
To: krzysztof.kozlowski+dt
Cc: thierry.reding, u.kleine-koenig, robh+dt, matthias.bgg, john,
sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, AngeloGioacchino Del Regno
This series converts pwm-mediatek.txt to schema and fixes
mt7622.dtsi to declare the needed #pwm-cells on the pwm node,
required to not trigger a dtbs_check warning... and to make
that node actually usable.
AngeloGioacchino Del Regno (2):
arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node
dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema
.../bindings/pwm/mediatek,mt2712-pwm.yaml | 93 +++++++++++++++++++
.../devicetree/bindings/pwm/pwm-mediatek.txt | 52 -----------
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
3 files changed, 94 insertions(+), 52 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
--
2.38.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node 2022-11-28 11:20 [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes AngeloGioacchino Del Regno @ 2022-11-28 11:20 ` AngeloGioacchino Del Regno 2022-12-02 18:09 ` Uwe Kleine-König 2023-02-01 10:56 ` Matthias Brugger 2022-11-28 11:20 ` [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema AngeloGioacchino Del Regno 2023-01-30 15:46 ` (subset) [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes Thierry Reding 2 siblings, 2 replies; 10+ messages in thread From: AngeloGioacchino Del Regno @ 2022-11-28 11:20 UTC (permalink / raw) To: krzysztof.kozlowski+dt Cc: thierry.reding, u.kleine-koenig, robh+dt, matthias.bgg, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, AngeloGioacchino Del Regno Specify #pwm-cells on pwm@11006000 to make it actually usable. Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 146e18b5b1f4..f321c6d0fd7c 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -435,6 +435,7 @@ uart3: serial@11005000 { pwm: pwm@11006000 { compatible = "mediatek,mt7622-pwm"; reg = <0 0x11006000 0 0x1000>; + #pwm-cells = <2>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>; clocks = <&topckgen CLK_TOP_PWM_SEL>, <&pericfg CLK_PERI_PWM_PD>, -- 2.38.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node 2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno @ 2022-12-02 18:09 ` Uwe Kleine-König 2023-01-17 21:39 ` Uwe Kleine-König 2023-01-30 15:54 ` Thierry Reding 2023-02-01 10:56 ` Matthias Brugger 1 sibling, 2 replies; 10+ messages in thread From: Uwe Kleine-König @ 2022-12-02 18:09 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: krzysztof.kozlowski+dt, thierry.reding, robh+dt, matthias.bgg, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek [-- Attachment #1: Type: text/plain, Size: 1315 bytes --] On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 146e18b5b1f4..f321c6d0fd7c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > pwm: pwm@11006000 { > compatible = "mediatek,mt7622-pwm"; > reg = <0 0x11006000 0 0x1000>; > + #pwm-cells = <2>; 3 should be possible, too. The driver does only support one polarity, so it's not really needed, but would be nice for consistency? Thierry, what's your take here? Other than that: Who would pick this up, I assume it to go via an ARM tree together with the 2nd patch in this series? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node 2022-12-02 18:09 ` Uwe Kleine-König @ 2023-01-17 21:39 ` Uwe Kleine-König 2023-01-19 17:33 ` Matthias Brugger 2023-01-30 15:54 ` Thierry Reding 1 sibling, 1 reply; 10+ messages in thread From: Uwe Kleine-König @ 2023-01-17 21:39 UTC (permalink / raw) To: AngeloGioacchino Del Regno, thierry.reding, krzysztof.kozlowski+dt Cc: robh+dt, matthias.bgg, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek [-- Attachment #1: Type: text/plain, Size: 1513 bytes --] Hello, On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote: > On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: > > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > index 146e18b5b1f4..f321c6d0fd7c 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > > pwm: pwm@11006000 { > > compatible = "mediatek,mt7622-pwm"; > > reg = <0 0x11006000 0 0x1000>; > > + #pwm-cells = <2>; > > 3 should be possible, too. The driver does only support one > polarity, so it's not really needed, but would be nice for consistency? > > Thierry, what's your take here? > > Other than that: Who would pick this up, I assume it to go via an ARM > tree together with the 2nd patch in this series? The questions here are still open and both patches unapplied. :-\ Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node 2023-01-17 21:39 ` Uwe Kleine-König @ 2023-01-19 17:33 ` Matthias Brugger 0 siblings, 0 replies; 10+ messages in thread From: Matthias Brugger @ 2023-01-19 17:33 UTC (permalink / raw) To: Uwe Kleine-König, AngeloGioacchino Del Regno, thierry.reding, krzysztof.kozlowski+dt Cc: robh+dt, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 17/01/2023 22:39, Uwe Kleine-König wrote: > Hello, > > On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote: >> On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: >>> Specify #pwm-cells on pwm@11006000 to make it actually usable. >>> >>> Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> --- >>> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi >>> index 146e18b5b1f4..f321c6d0fd7c 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi >>> @@ -435,6 +435,7 @@ uart3: serial@11005000 { >>> pwm: pwm@11006000 { >>> compatible = "mediatek,mt7622-pwm"; >>> reg = <0 0x11006000 0 0x1000>; >>> + #pwm-cells = <2>; >> >> 3 should be possible, too. The driver does only support one >> polarity, so it's not really needed, but would be nice for consistency? >> >> Thierry, what's your take here? >> >> Other than that: Who would pick this up, I assume it to go via an ARM >> tree together with the 2nd patch in this series? The DT patch should go through my tree once all questions are answered and the dt-binding patch got accpeted by PWM maintainer. Regards, Matthias > > The questions here are still open and both patches unapplied. :-\ > > Best regards > Uwe > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node 2022-12-02 18:09 ` Uwe Kleine-König 2023-01-17 21:39 ` Uwe Kleine-König @ 2023-01-30 15:54 ` Thierry Reding 1 sibling, 0 replies; 10+ messages in thread From: Thierry Reding @ 2023-01-30 15:54 UTC (permalink / raw) To: Uwe Kleine-König Cc: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt, robh+dt, matthias.bgg, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek [-- Attachment #1: Type: text/plain, Size: 1417 bytes --] On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote: > On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: > > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > index 146e18b5b1f4..f321c6d0fd7c 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > > pwm: pwm@11006000 { > > compatible = "mediatek,mt7622-pwm"; > > reg = <0 0x11006000 0 0x1000>; > > + #pwm-cells = <2>; > > 3 should be possible, too. The driver does only support one > polarity, so it's not really needed, but would be nice for consistency? > > Thierry, what's your take here? There's little point in setting this to 3 if the driver doesn't support it. The core should catch misconfiguration, but that's more of a fail- safe and if we can just avoid this from the start by not allowing anyone to specify inversed polarity that seems like a good idea. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node 2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno 2022-12-02 18:09 ` Uwe Kleine-König @ 2023-02-01 10:56 ` Matthias Brugger 1 sibling, 0 replies; 10+ messages in thread From: Matthias Brugger @ 2023-02-01 10:56 UTC (permalink / raw) To: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt Cc: thierry.reding, u.kleine-koenig, robh+dt, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 28/11/2022 12:20, AngeloGioacchino Del Regno wrote: > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Applied, thanks! > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 146e18b5b1f4..f321c6d0fd7c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > pwm: pwm@11006000 { > compatible = "mediatek,mt7622-pwm"; > reg = <0 0x11006000 0 0x1000>; > + #pwm-cells = <2>; > interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>; > clocks = <&topckgen CLK_TOP_PWM_SEL>, > <&pericfg CLK_PERI_PWM_PD>, ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema 2022-11-28 11:20 [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes AngeloGioacchino Del Regno 2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno @ 2022-11-28 11:20 ` AngeloGioacchino Del Regno 2022-11-29 13:58 ` Krzysztof Kozlowski 2023-01-30 15:46 ` (subset) [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes Thierry Reding 2 siblings, 1 reply; 10+ messages in thread From: AngeloGioacchino Del Regno @ 2022-11-28 11:20 UTC (permalink / raw) To: krzysztof.kozlowski+dt Cc: thierry.reding, u.kleine-koenig, robh+dt, matthias.bgg, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, AngeloGioacchino Del Regno This converts pwm-mediatek.txt to mediatek,mt2712-pwm.yaml schema; while at it, the clock names were clarified as previously they were documented as "pwmX-Y", but valid names are "pwmN" only. Also, the example was changed to use "mediatek,mt2712-pwm" instead for consistency with the schema filename. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../bindings/pwm/mediatek,mt2712-pwm.yaml | 93 +++++++++++++++++++ .../devicetree/bindings/pwm/pwm-mediatek.txt | 52 ----------- 2 files changed, 93 insertions(+), 52 deletions(-) create mode 100644 Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mediatek.txt diff --git a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml new file mode 100644 index 000000000000..dbc974bff9e9 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml @@ -0,0 +1,93 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/mediatek,mt2712-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek PWM Controller + +maintainers: + - John Crispin <john@phrozen.org> + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + oneOf: + - enum: + - mediatek,mt2712-pwm + - mediatek,mt6795-pwm + - mediatek,mt7622-pwm + - mediatek,mt7623-pwm + - mediatek,mt7628-pwm + - mediatek,mt7629-pwm + - mediatek,mt8183-pwm + - mediatek,mt8365-pwm + - mediatek,mt8516-pwm + - items: + - enum: + - mediatek,mt8195-pwm + - const: mediatek,mt8183-pwm + + reg: + maxItems: 1 + + "#pwm-cells": + const: 2 + + interrupts: + maxItems: 1 + + clocks: + minItems: 2 + maxItems: 10 + + clock-names: + description: + This controller needs two input clocks for its core and one + clock for each PWM output. + minItems: 2 + items: + - const: top + - const: main + - const: pwm1 + - const: pwm2 + - const: pwm3 + - const: pwm4 + - const: pwm5 + - const: pwm6 + - const: pwm7 + - const: pwm8 + +required: + - compatible + - reg + - "#pwm-cells" + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/mt2712-clk.h> + #include <dt-bindings/interrupt-controller/irq.h> + + pwm0: pwm@11006000 { + compatible = "mediatek,mt2712-pwm"; + reg = <0x11006000 0x1000>; + #pwm-cells = <2>; + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>; + clocks = <&topckgen CLK_TOP_PWM_SEL>, <&pericfg CLK_PERI_PWM>, + <&pericfg CLK_PERI_PWM0>, <&pericfg CLK_PERI_PWM1>, + <&pericfg CLK_PERI_PWM2>, <&pericfg CLK_PERI_PWM3>, + <&pericfg CLK_PERI_PWM4>, <&pericfg CLK_PERI_PWM5>, + <&pericfg CLK_PERI_PWM6>, <&pericfg CLK_PERI_PWM7>; + clock-names = "top", "main", + "pwm1", "pwm2", + "pwm3", "pwm4", + "pwm5", "pwm6", + "pwm7", "pwm8"; + }; diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt deleted file mode 100644 index 554c96b6d0c3..000000000000 --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt +++ /dev/null @@ -1,52 +0,0 @@ -MediaTek PWM controller - -Required properties: - - compatible: should be "mediatek,<name>-pwm": - - "mediatek,mt2712-pwm": found on mt2712 SoC. - - "mediatek,mt6795-pwm": found on mt6795 SoC. - - "mediatek,mt7622-pwm": found on mt7622 SoC. - - "mediatek,mt7623-pwm": found on mt7623 SoC. - - "mediatek,mt7628-pwm": found on mt7628 SoC. - - "mediatek,mt7629-pwm": found on mt7629 SoC. - - "mediatek,mt8183-pwm": found on mt8183 SoC. - - "mediatek,mt8195-pwm", "mediatek,mt8183-pwm": found on mt8195 SoC. - - "mediatek,mt8365-pwm": found on mt8365 SoC. - - "mediatek,mt8516-pwm": found on mt8516 SoC. - - reg: physical base address and length of the controller's registers. - - #pwm-cells: must be 2. See pwm.yaml in this directory for a description of - the cell format. - - clocks: phandle and clock specifier of the PWM reference clock. - - clock-names: must contain the following, except for MT7628 which - has no clocks - - "top": the top clock generator - - "main": clock used by the PWM core - - "pwm1-3": the three per PWM clocks for mt8365 - - "pwm1-8": the eight per PWM clocks for mt2712 - - "pwm1-6": the six per PWM clocks for mt7622 - - "pwm1-5": the five per PWM clocks for mt7623 - - "pwm1" : the PWM1 clock for mt7629 - - pinctrl-names: Must contain a "default" entry. - - pinctrl-0: One property must exist for each entry in pinctrl-names. - See pinctrl/pinctrl-bindings.txt for details of the property values. - -Optional properties: -- assigned-clocks: Reference to the PWM clock entries. -- assigned-clock-parents: The phandle of the parent clock of PWM clock. - -Example: - pwm0: pwm@11006000 { - compatible = "mediatek,mt7623-pwm"; - reg = <0 0x11006000 0 0x1000>; - #pwm-cells = <2>; - clocks = <&topckgen CLK_TOP_PWM_SEL>, - <&pericfg CLK_PERI_PWM>, - <&pericfg CLK_PERI_PWM1>, - <&pericfg CLK_PERI_PWM2>, - <&pericfg CLK_PERI_PWM3>, - <&pericfg CLK_PERI_PWM4>, - <&pericfg CLK_PERI_PWM5>; - clock-names = "top", "main", "pwm1", "pwm2", - "pwm3", "pwm4", "pwm5"; - pinctrl-names = "default"; - pinctrl-0 = <&pwm0_pins>; - }; -- 2.38.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema 2022-11-28 11:20 ` [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema AngeloGioacchino Del Regno @ 2022-11-29 13:58 ` Krzysztof Kozlowski 0 siblings, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2022-11-29 13:58 UTC (permalink / raw) To: AngeloGioacchino Del Regno, krzysztof.kozlowski+dt Cc: thierry.reding, u.kleine-koenig, robh+dt, matthias.bgg, john, sean.wang, linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 28/11/2022 12:20, AngeloGioacchino Del Regno wrote: > This converts pwm-mediatek.txt to mediatek,mt2712-pwm.yaml schema; > while at it, the clock names were clarified as previously they were > documented as "pwmX-Y", but valid names are "pwmN" only. > Also, the example was changed to use "mediatek,mt2712-pwm" instead > for consistency with the schema filename. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes 2022-11-28 11:20 [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes AngeloGioacchino Del Regno 2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno 2022-11-28 11:20 ` [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema AngeloGioacchino Del Regno @ 2023-01-30 15:46 ` Thierry Reding 2 siblings, 0 replies; 10+ messages in thread From: Thierry Reding @ 2023-01-30 15:46 UTC (permalink / raw) To: krzysztof.kozlowski+dt, AngeloGioacchino Del Regno Cc: linux-arm-kernel, john, matthias.bgg, linux-mediatek, robh+dt, linux-kernel, u.kleine-koenig, linux-pwm, sean.wang, devicetree On Mon, 28 Nov 2022 12:20:26 +0100, AngeloGioacchino Del Regno wrote: > This series converts pwm-mediatek.txt to schema and fixes > mt7622.dtsi to declare the needed #pwm-cells on the pwm node, > required to not trigger a dtbs_check warning... and to make > that node actually usable. > > AngeloGioacchino Del Regno (2): > arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node > dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema > > [...] Applied, thanks! [2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema (no commit info) Best regards, -- Thierry Reding <thierry.reding@gmail.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-02-01 10:57 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-28 11:20 [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes AngeloGioacchino Del Regno 2022-11-28 11:20 ` [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node AngeloGioacchino Del Regno 2022-12-02 18:09 ` Uwe Kleine-König 2023-01-17 21:39 ` Uwe Kleine-König 2023-01-19 17:33 ` Matthias Brugger 2023-01-30 15:54 ` Thierry Reding 2023-02-01 10:56 ` Matthias Brugger 2022-11-28 11:20 ` [PATCH v1 2/2] dt-bindings: pwm: mediatek: Convert pwm-mediatek to dt schema AngeloGioacchino Del Regno 2022-11-29 13:58 ` Krzysztof Kozlowski 2023-01-30 15:46 ` (subset) [PATCH v1 0/2] pwm-mediatek: Convert to schema and fixes Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).