From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y
Date: Mon, 28 Nov 2022 20:29:56 +0530 [thread overview]
Message-ID: <20221128145956.6rgswicmtsuxxhdt@riteshh-domain> (raw)
In-Reply-To: <20221128135056.325-1-jszhang@kernel.org>
On 22/11/28 09:50PM, Jisheng Zhang wrote:
> fix below build warning when ELF_CORE=n while COREDUMP=y:
>
> fs/coredump.c:834:12: warning: ‘dump_emit_page’ defined but not used [-Wunused-function]
> 834 | static int dump_emit_page(struct coredump_params *cprm, struct
> page *page)
> | ^~~~~~~~~~~~~~
Fixes: 06bbaa6dc53c: "[coredump] don't use __kernel_write() on kmap_local_page()"
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> fs/coredump.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 7bad7785e8e6..8663042ebe9c 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
> }
> }
>
> +#ifdef CONFIG_ELF_CORE
Instead of this ^^^, we could even move the definition of dump_emit_page() in
the same #ifdef as of dump_user_range(). Since dump_user_range() is the only
caller of dump_emit_page().
#ifdef CONFIG_ELF_CORE
[here]
int dump_user_range(struct coredump_params *cprm, unsigned long start,
unsigned long len)
{..}
#endif
But I guess that's just a nitpick. Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
-ritesh
> static int dump_emit_page(struct coredump_params *cprm, struct page *page)
> {
> struct bio_vec bvec = {
> @@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
>
> return 1;
> }
> +#endif
>
> int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
> {
> --
> 2.37.2
>
next prev parent reply other threads:[~2022-11-28 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:50 [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y Jisheng Zhang
2022-11-28 14:59 ` Ritesh Harjani (IBM) [this message]
2022-11-28 23:22 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128145956.6rgswicmtsuxxhdt@riteshh-domain \
--to=ritesh.list@gmail.com \
--cc=jszhang@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).