* [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y
@ 2022-11-28 13:50 Jisheng Zhang
2022-11-28 14:59 ` Ritesh Harjani (IBM)
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2022-11-28 13:50 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-fsdevel, linux-kernel
fix below build warning when ELF_CORE=n while COREDUMP=y:
fs/coredump.c:834:12: warning: ‘dump_emit_page’ defined but not used [-Wunused-function]
834 | static int dump_emit_page(struct coredump_params *cprm, struct
page *page)
| ^~~~~~~~~~~~~~
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
fs/coredump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/coredump.c b/fs/coredump.c
index 7bad7785e8e6..8663042ebe9c 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
}
}
+#ifdef CONFIG_ELF_CORE
static int dump_emit_page(struct coredump_params *cprm, struct page *page)
{
struct bio_vec bvec = {
@@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
return 1;
}
+#endif
int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
{
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y
2022-11-28 13:50 [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y Jisheng Zhang
@ 2022-11-28 14:59 ` Ritesh Harjani (IBM)
2022-11-28 23:22 ` Jisheng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Ritesh Harjani (IBM) @ 2022-11-28 14:59 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: Alexander Viro, linux-fsdevel, linux-kernel
On 22/11/28 09:50PM, Jisheng Zhang wrote:
> fix below build warning when ELF_CORE=n while COREDUMP=y:
>
> fs/coredump.c:834:12: warning: ‘dump_emit_page’ defined but not used [-Wunused-function]
> 834 | static int dump_emit_page(struct coredump_params *cprm, struct
> page *page)
> | ^~~~~~~~~~~~~~
Fixes: 06bbaa6dc53c: "[coredump] don't use __kernel_write() on kmap_local_page()"
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> fs/coredump.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 7bad7785e8e6..8663042ebe9c 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
> }
> }
>
> +#ifdef CONFIG_ELF_CORE
Instead of this ^^^, we could even move the definition of dump_emit_page() in
the same #ifdef as of dump_user_range(). Since dump_user_range() is the only
caller of dump_emit_page().
#ifdef CONFIG_ELF_CORE
[here]
int dump_user_range(struct coredump_params *cprm, unsigned long start,
unsigned long len)
{..}
#endif
But I guess that's just a nitpick. Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
-ritesh
> static int dump_emit_page(struct coredump_params *cprm, struct page *page)
> {
> struct bio_vec bvec = {
> @@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
>
> return 1;
> }
> +#endif
>
> int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
> {
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y
2022-11-28 14:59 ` Ritesh Harjani (IBM)
@ 2022-11-28 23:22 ` Jisheng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2022-11-28 23:22 UTC (permalink / raw)
To: Ritesh Harjani (IBM); +Cc: Alexander Viro, linux-fsdevel, linux-kernel
On Mon, Nov 28, 2022 at 08:29:56PM +0530, Ritesh Harjani (IBM) wrote:
> On 22/11/28 09:50PM, Jisheng Zhang wrote:
> > fix below build warning when ELF_CORE=n while COREDUMP=y:
> >
> > fs/coredump.c:834:12: warning: ‘dump_emit_page’ defined but not used [-Wunused-function]
> > 834 | static int dump_emit_page(struct coredump_params *cprm, struct
> > page *page)
> > | ^~~~~~~~~~~~~~
>
> Fixes: 06bbaa6dc53c: "[coredump] don't use __kernel_write() on kmap_local_page()"
>
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > fs/coredump.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/coredump.c b/fs/coredump.c
> > index 7bad7785e8e6..8663042ebe9c 100644
> > --- a/fs/coredump.c
> > +++ b/fs/coredump.c
> > @@ -831,6 +831,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
> > }
> > }
> >
> > +#ifdef CONFIG_ELF_CORE
>
> Instead of this ^^^, we could even move the definition of dump_emit_page() in
> the same #ifdef as of dump_user_range(). Since dump_user_range() is the only
> caller of dump_emit_page().
>
> #ifdef CONFIG_ELF_CORE
> [here]
> int dump_user_range(struct coredump_params *cprm, unsigned long start,
> unsigned long len)
> {..}
> #endif
>
I planed to patch like this, but I saw the final patch diffstat was
a bit more. I'll send out a v2.
Thanks
> But I guess that's just a nitpick. Feel free to add:
>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
>
> -ritesh
>
> > static int dump_emit_page(struct coredump_params *cprm, struct page *page)
> > {
> > struct bio_vec bvec = {
> > @@ -863,6 +864,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
> >
> > return 1;
> > }
> > +#endif
> >
> > int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
> > {
> > --
> > 2.37.2
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-28 23:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 13:50 [PATCH] coredump: fix compile warning when ELF_CORE=n while COREDUMP=y Jisheng Zhang
2022-11-28 14:59 ` Ritesh Harjani (IBM)
2022-11-28 23:22 ` Jisheng Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).