From: Jonathan Cameron <jic23@kernel.org>
To: Gerald Loacker <gerald.loacker@wolfvision.net>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jakob Hauser <jahau@rocketmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH v6 3/3] iio: magnetometer: add ti tmag5273 driver
Date: Sat, 3 Dec 2022 17:20:47 +0000 [thread overview]
Message-ID: <20221203172047.2792343e@jic23-huawei> (raw)
In-Reply-To: <20221201072220.402585-4-gerald.loacker@wolfvision.net>
On Thu, 1 Dec 2022 08:22:20 +0100
Gerald Loacker <gerald.loacker@wolfvision.net> wrote:
> Add support for TI TMAG5273 Low-Power Linear 3D Hall-Effect Sensor.
> Additionally to temperature and magnetic X, Y and Z-axes the angle and
> magnitude are reported.
> The sensor is operating in continuous measurement mode and changes to sleep
> mode if not used for 5 seconds.
>
> Datasheet: https://www.ti.com/lit/gpn/tmag5273
> Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> + case IIO_ANGL:
> + /*
> + * Angle is in degrees and has four fractional bits,
> + * therefore use 1/16 * pi/180 to convert to radiants.
typo. radians
I'll fix whilst applying.
> + */
> +}
next prev parent reply other threads:[~2022-12-03 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 7:22 [PATCH v6 0/3] add ti tmag5273 driver Gerald Loacker
2022-12-01 7:22 ` [PATCH v6 1/3] iio: add struct declaration for iio types Gerald Loacker
2022-12-01 7:22 ` [PATCH v6 2/3] dt-bindings: iio: magnetometer: add ti tmag5273 documentation file Gerald Loacker
2022-12-01 7:22 ` [PATCH v6 3/3] iio: magnetometer: add ti tmag5273 driver Gerald Loacker
2022-12-03 17:20 ` Jonathan Cameron [this message]
2022-12-03 17:25 ` [PATCH v6 0/3] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221203172047.2792343e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=jahau@rocketmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).