Re: [PATCH v6 0/3] add ti tmag5273 driver

[Jonathan Cameron <jic23@kernel.org>]

On Thu,  1 Dec 2022 08:22:17 +0100
Gerald Loacker <gerald.loacker@wolfvision.net> wrote:

> Hi all,
> 
> This patch set adds support for the TI TMAG5273 Low-Power Linear 3D Hall-
> Effect Sensor. Additionally to temperature and magnetic X, Y and Z-axes the
> angle and magnitude are reported. The sensor is operating in continuous
> measurement mode and changes to sleep mode if not used for 5 seconds.
> 
> Tests were done on a ROCK3 Model A board using the TMAG5273 evaluation
> module.

Hi Gerald,

Looks good to me (thanks to Andy for his work reviewing!)

Unfortunately timing is such that we are too close to the merge window, so
I'm not planning on doing another pull request for this cycle. As such it's
the first thing I've queued up for 6.3.

Applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a look at it.

Note I'll probably rebase the tree after rc1 and so it won't push out as
togreg (which is meant to be non-rebasing) until after that point.

Thanks,

Jonathan


> 
> Changes in v6:
>  - Defined TMAG5273_MAX_REG
>  - Added comment for wrong device ID
>  
> Changes in v5:
>  - Fixed dev_err_probe
>  - Removed unnecessary '&' for function pointers
>  - Removed warning for device tree reading failure as Linux should not
>    validate device tree.
>  - Added comment for device name
>  - Added tmag5273_wake_up() and improved comments
>  - Reformatted pm_ops
>  
> Changes in v4:
>  - Add only struct for IIO_VAL_INT_PLUS_MICRO iio type to iio.h.
>  - Simplified tmag5273_write_scale()
>  - Removed unnecessary  != 0
>  - Fixed regmap max_register
>  - Simplified tmag5273_read_device_property()
>  - Fixed some line breaks.
> 
> Changes in v3:
>  - Added structs for iio types to iio.h. Using these structs for iio type
>    arrays such as IIO_AVAIL_LIST makes the code more readable than just
>    using (int *). It was suggested by Andy Shevchenko to move these structs
>    to the iio headers to avoid different approaches.
>  - dt-bindings: dropped quotes from strings
>  - Added include <linux/bitfield.h>
>    | Reported-by: kernel test robot <lkp@intel.com> 
>  - Added include <linux/bits.h>
>  - Removed <asm/unaligned.h>
>  - Added missing "static const" for tmag5273_avg_table
>  - Documented Device ID
>  - Fixed index of tmag5273_scale definition
>  - Clarify TMAG5273_MAG_CH_EN_X_Y_Z as an index
>  - Removed unnecessary print
>  - Introduced tmag5273_write_scale() and tmag5273_write_osr() helper
>    functions
>  - Use of match_string()
>  - Format
> 
> Changes in v2:
>  Thanks to Krzysztof, Andy and Jonathan for your detailed review and
>  explanations on the first version. This patch includes all your
>  suggestions and some additional cleanup in the probe function.
> 
> Gerald Loacker (3):
>   iio: add struct declaration for iio types
>   dt-bindings: iio: magnetometer: add ti tmag5273 documentation file
>   iio: magnetometer: add ti tmag5273 driver
> 
>  .../iio/magnetometer/ti,tmag5273.yaml         |  75 ++
>  MAINTAINERS                                   |   7 +
>  drivers/iio/magnetometer/Kconfig              |  12 +
>  drivers/iio/magnetometer/Makefile             |   2 +
>  drivers/iio/magnetometer/tmag5273.c           | 743 ++++++++++++++++++
>  include/linux/iio/iio.h                       |   5 +
>  6 files changed, 844 insertions(+)
>  create mode 100644 .../bindings/iio/magnetometer/ti,tmag5273.yaml
>  create mode 100644 drivers/iio/magnetometer/tmag5273.c
>