From: Oleg Nesterov <oleg@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Frederic Weisbecker <frederic@kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Pengfei Xu <pengfei.xu@intel.com>,
Boqun Feng <boqun.feng@gmail.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
rcu@vger.kernel.org
Subject: Re: [PATCH 3/3] rcu-tasks: Fix synchronize_rcu_tasks() VS zap_pid_ns_processes()
Date: Tue, 6 Dec 2022 17:49:28 +0100 [thread overview]
Message-ID: <20221206164927.GD3866@redhat.com> (raw)
In-Reply-To: <871qpkqof8.fsf@email.froward.int.ebiederm.org>
On 11/30, Eric W. Biederman wrote:
>
> 2) I keep thinking zap_pid_ns_processes() should be changed so that
> after it sends SIGKILL to all of the relevant processes to not wait,
At least I think it should not wait for the tasks injected into this ns.
Because this looks like a kernel bug even if we forget about this deadlock.
Say we create a task P using clone(CLONE_NEWPID), then inject a task T into
P's pid-namespace via setns/fork. This make the process P "unkillable", it
will hang in zap_pid_ns_processes() "forever" until T->parent reaps a zombie
task T killed by P.
Oleg.
next prev parent reply other threads:[~2022-12-06 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 13:54 [PATCH 0/3] rcu-tasks: Fix race against exiting pid_ns Frederic Weisbecker
2022-11-25 13:54 ` [PATCH 1/3] rcu-tasks: Improve comments explaining tasks_rcu_exit_srcu purpose Frederic Weisbecker
2022-11-25 13:54 ` [PATCH 2/3] rcu-tasks: Remove preemption disablement around srcu_read_[un]lock() calls Frederic Weisbecker
2022-11-25 13:55 ` [PATCH 3/3] rcu-tasks: Fix synchronize_rcu_tasks() VS zap_pid_ns_processes() Frederic Weisbecker
2022-11-30 18:37 ` Eric W. Biederman
2022-12-02 19:51 ` Paul E. McKenney
2022-12-02 22:54 ` Frederic Weisbecker
2022-12-02 23:28 ` Eric W. Biederman
2022-12-04 0:03 ` Frederic Weisbecker
2022-12-06 16:49 ` Oleg Nesterov [this message]
2022-12-07 14:34 ` Paul E. McKenney
2022-12-07 20:01 ` Frederic Weisbecker
2022-12-07 20:39 ` Oleg Nesterov
2022-12-09 20:26 ` Frederic Weisbecker
2022-11-29 0:22 ` [PATCH 0/3] rcu-tasks: Fix race against exiting pid_ns Paul E. McKenney
2022-11-29 9:55 ` Frederic Weisbecker
2022-11-29 14:48 ` Paul E. McKenney
2022-12-02 22:55 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206164927.GD3866@redhat.com \
--to=oleg@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=pengfei.xu@intel.com \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).