* [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property
@ 2022-12-07 20:43 Rob Herring
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-07 20:43 UTC (permalink / raw)
To: Pavel Machek, Krzysztof Kozlowski, Yi Xin, Mallikarjuna reddy
Cc: linux-leds, devicetree, linux-kernel
The example has 'led-gpio' properties, but that's not documented. As the
'gpio' form is deprecated, add 'led-gpios' to the schema and update the
example.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
index f8d7963c3a13..3f13db0dc915 100644
--- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
@@ -64,6 +64,9 @@ properties:
minimum: 0
maximum: 2
+ led-gpios:
+ maxItems: 1
+
intel,sso-hw-trigger:
type: boolean
description: This property indicates Hardware driven/control LED.
@@ -118,14 +121,14 @@ examples:
reg = <0>;
function = "gphy";
color = <LED_COLOR_ID_GREEN>;
- led-gpio = <&ssogpio 0 0>;
+ led-gpios = <&ssogpio 0 0>;
};
led@2 {
reg = <2>;
function = LED_FUNCTION_POWER;
color = <LED_COLOR_ID_GREEN>;
- led-gpio = <&ssogpio 23 0>;
+ led-gpios = <&ssogpio 23 0>;
};
};
};
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema
2022-12-07 20:43 [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Rob Herring
@ 2022-12-07 20:43 ` Rob Herring
2022-12-08 9:28 ` Bartosz Golaszewski
` (3 more replies)
2022-12-08 10:34 ` [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 4 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-07 20:43 UTC (permalink / raw)
To: Pavel Machek, Krzysztof Kozlowski, Yi Xin, Mallikarjuna reddy,
Bartosz Golaszewski, Matti Vaittinen
Cc: linux-leds, devicetree, linux-kernel, Bartosz Golaszewski
'led' nodes should have a reference to LED common.yaml schema. Add it where
missing and drop any duplicate properties.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/leds/leds-lgm.yaml | 3 ++-
.../devicetree/bindings/leds/leds-max77650.yaml | 9 ++-------
.../bindings/leds/rohm,bd71828-leds.yaml | 16 +++-------------
3 files changed, 7 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
index 3f13db0dc915..8b3b3bf1eaf2 100644
--- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
@@ -56,7 +56,8 @@ properties:
patternProperties:
"^led@[0-2]$":
- type: object
+ $ref: common.yaml#
+ unevaluatedProperties: false
properties:
reg:
diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
index c6f96cabd4d1..fdb08f44a45d 100644
--- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
@@ -30,9 +30,8 @@ properties:
patternProperties:
"^led@[0-2]$":
- type: object
- description: |
- Properties for a single LED.
+ $ref: common.yaml#
+ unevaluatedProperties: false
properties:
reg:
@@ -41,10 +40,6 @@ patternProperties:
minimum: 0
maximum: 2
- label: true
-
- linux,default-trigger: true
-
required:
- compatible
- "#address-cells"
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
index 86a37c92b834..ca92cea56a6f 100644
--- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
+++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
@@ -26,26 +26,16 @@ properties:
patternProperties:
"^led-[1-2]$":
- type: object
- description:
- Properties for a single LED.
+ $ref: common.yaml#
+ unevaluatedProperties: false
+
properties:
- #allOf:
- #- $ref: "common.yaml#"
rohm,led-compatible:
description: LED identification string
$ref: "/schemas/types.yaml#/definitions/string"
enum:
- bd71828-ambled
- bd71828-grnled
- function:
- description:
- Purpose of LED as defined in dt-bindings/leds/common.h
- $ref: "/schemas/types.yaml#/definitions/string"
- color:
- description:
- LED colour as defined in dt-bindings/leds/common.h
- $ref: "/schemas/types.yaml#/definitions/uint32"
required:
- compatible
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
@ 2022-12-08 9:28 ` Bartosz Golaszewski
2022-12-08 10:34 ` Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2022-12-08 9:28 UTC (permalink / raw)
To: Rob Herring
Cc: Pavel Machek, Krzysztof Kozlowski, Yi Xin, Mallikarjuna reddy,
Matti Vaittinen, linux-leds, devicetree, linux-kernel,
Bartosz Golaszewski
On Wed, Dec 7, 2022 at 9:43 PM Rob Herring <robh@kernel.org> wrote:
>
> 'led' nodes should have a reference to LED common.yaml schema. Add it where
> missing and drop any duplicate properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++-------
> diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
> index c6f96cabd4d1..fdb08f44a45d 100644
> --- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
> @@ -30,9 +30,8 @@ properties:
>
> patternProperties:
> "^led@[0-2]$":
> - type: object
> - description: |
> - Properties for a single LED.
> + $ref: common.yaml#
> + unevaluatedProperties: false
>
> properties:
> reg:
> @@ -41,10 +40,6 @@ patternProperties:
> minimum: 0
> maximum: 2
>
> - label: true
> -
> - linux,default-trigger: true
> -
> required:
> - compatible
> - "#address-cells"
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property
2022-12-07 20:43 [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Rob Herring
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
@ 2022-12-08 10:34 ` Krzysztof Kozlowski
2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
3 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 10:34 UTC (permalink / raw)
To: Rob Herring, Pavel Machek, Krzysztof Kozlowski, Yi Xin,
Mallikarjuna reddy
Cc: linux-leds, devicetree, linux-kernel
On 07/12/2022 21:43, Rob Herring wrote:
> The example has 'led-gpio' properties, but that's not documented. As the
> 'gpio' form is deprecated, add 'led-gpios' to the schema and update the
> example.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
2022-12-08 9:28 ` Bartosz Golaszewski
@ 2022-12-08 10:34 ` Krzysztof Kozlowski
2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
3 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-08 10:34 UTC (permalink / raw)
To: Rob Herring, Pavel Machek, Krzysztof Kozlowski, Yi Xin,
Mallikarjuna reddy, Bartosz Golaszewski, Matti Vaittinen
Cc: linux-leds, devicetree, linux-kernel, Bartosz Golaszewski
On 07/12/2022 21:43, Rob Herring wrote:
> 'led' nodes should have a reference to LED common.yaml schema. Add it where
> missing and drop any duplicate properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++-
> .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++-------
> .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++-------------
> 3 files changed, 7 insertions(+), 21 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property
2022-12-07 20:43 [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Rob Herring
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
2022-12-08 10:34 ` [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Krzysztof Kozlowski
@ 2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
3 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2022-12-08 10:56 UTC (permalink / raw)
To: Rob Herring
Cc: Pavel Machek, Krzysztof Kozlowski, Yi Xin, Mallikarjuna reddy,
linux-leds, devicetree, linux-kernel
On Wed, 07 Dec 2022, Rob Herring wrote:
> The example has 'led-gpio' properties, but that's not documented. As the
> 'gpio' form is deprecated, add 'led-gpios' to the schema and update the
> example.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Looks good. Who usually takes these?
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
2022-12-08 9:28 ` Bartosz Golaszewski
2022-12-08 10:34 ` Krzysztof Kozlowski
@ 2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
3 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2022-12-08 10:56 UTC (permalink / raw)
To: Rob Herring
Cc: Pavel Machek, Krzysztof Kozlowski, Yi Xin, Mallikarjuna reddy,
Bartosz Golaszewski, Matti Vaittinen, linux-leds, devicetree,
linux-kernel, Bartosz Golaszewski
On Wed, 07 Dec 2022, Rob Herring wrote:
> 'led' nodes should have a reference to LED common.yaml schema. Add it where
> missing and drop any duplicate properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++-
> .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++-------
> .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++-------------
> 3 files changed, 7 insertions(+), 21 deletions(-)
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property
2022-12-07 20:43 [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Rob Herring
` (2 preceding siblings ...)
2022-12-08 10:56 ` Lee Jones
@ 2022-12-12 1:06 ` Rob Herring
3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-12 1:06 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, Pavel Machek, Yi Xin, Krzysztof Kozlowski,
devicetree, linux-leds, Mallikarjuna reddy
On Wed, 07 Dec 2022 14:43:26 -0600, Rob Herring wrote:
> The example has 'led-gpio' properties, but that's not documented. As the
> 'gpio' form is deprecated, add 'led-gpios' to the schema and update the
> example.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
` (2 preceding siblings ...)
2022-12-08 10:56 ` Lee Jones
@ 2022-12-12 1:06 ` Rob Herring
3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-12 1:06 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Matti Vaittinen, linux-leds,
Bartosz Golaszewski, Mallikarjuna reddy, Bartosz Golaszewski,
linux-kernel, devicetree, Pavel Machek, Yi Xin
On Wed, 07 Dec 2022 14:43:27 -0600, Rob Herring wrote:
> 'led' nodes should have a reference to LED common.yaml schema. Add it where
> missing and drop any duplicate properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++-
> .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++-------
> .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++-------------
> 3 files changed, 7 insertions(+), 21 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-12-12 1:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 20:43 [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Rob Herring
2022-12-07 20:43 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Rob Herring
2022-12-08 9:28 ` Bartosz Golaszewski
2022-12-08 10:34 ` Krzysztof Kozlowski
2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
2022-12-08 10:34 ` [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Krzysztof Kozlowski
2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).