[PATCH] clk: samsung: Fix memory leak in _samsung_clk_register_pll()

[PATCH] clk: samsung: Fix memory leak in _samsung_clk_register_pll()

[Xiu Jianfeng]

If clk_register() fails, @pll->rate_table may have allocated memory by
kmemdup(), so it needs to be freed, otherwise will cause memory leak
issue, this patch fixes it.

Fixes: 3ff6e0d8d64d ("clk: samsung: Add support to register rate_table for samsung plls")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 drivers/clk/samsung/clk-pll.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c
index fe383471c5f0..0ff28938943f 100644
--- a/drivers/clk/samsung/clk-pll.c
+++ b/drivers/clk/samsung/clk-pll.c
@@ -1583,6 +1583,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx,
 	if (ret) {
 		pr_err("%s: failed to register pll clock %s : %d\n",
 			__func__, pll_clk->name, ret);
+		kfree(pll->rate_table);
 		kfree(pll);
 		return;
 	}
-- 
2.17.1

RE: [PATCH] clk: samsung: Fix memory leak in _samsung_clk_register_pll()

[Alim Akhtar]

Hi Xiu

>-----Original Message-----
>From: Xiu Jianfeng [mailto:xiujianfeng@huawei.com]
>Sent: Wednesday, November 23, 2022 8:50 AM
>To: krzysztof.kozlowski@linaro.org; s.nawrocki@samsung.com;
>tomasz.figa@gmail.com; cw00.choi@samsung.com;
>alim.akhtar@samsung.com; mturquette@baylibre.com; sboyd@kernel.org;
>dianders@chromium.org; yadi.brar@samsung.com; mturquette@linaro.org
>Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH] clk: samsung: Fix memory leak in
>_samsung_clk_register_pll()
>
>If clk_register() fails, @pll->rate_table may have allocated memory by
>kmemdup(), so it needs to be freed, otherwise will cause memory leak issue,
>this patch fixes it.
>
>Fixes: 3ff6e0d8d64d ("clk: samsung: Add support to register rate_table for
>samsung plls")
>Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>---
Thanks!

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> drivers/clk/samsung/clk-pll.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c
index
>fe383471c5f0..0ff28938943f 100644
>--- a/drivers/clk/samsung/clk-pll.c
>+++ b/drivers/clk/samsung/clk-pll.c
>@@ -1583,6 +1583,7 @@ static void __init _samsung_clk_register_pll(struct
>samsung_clk_provider *ctx,
> 	if (ret) {
> 		pr_err("%s: failed to register pll clock %s : %d\n",
> 			__func__, pll_clk->name, ret);
>+		kfree(pll->rate_table);
> 		kfree(pll);
> 		return;
> 	}
>--
>2.17.1

Re: [PATCH] clk: samsung: Fix memory leak in _samsung_clk_register_pll()

[Stephen Boyd]

Quoting Xiu Jianfeng (2022-11-22 19:20:15)
> If clk_register() fails, @pll->rate_table may have allocated memory by
> kmemdup(), so it needs to be freed, otherwise will cause memory leak
> issue, this patch fixes it.
> 
> Fixes: 3ff6e0d8d64d ("clk: samsung: Add support to register rate_table for samsung plls")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---

Applied to clk-next