* [PATCH] iio: health: afe440x: Convert to use sysfs_emit_at() API
@ 2022-12-07 7:37 ye.xingchen
2022-12-11 12:10 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-12-07 7:37 UTC (permalink / raw)
To: jic23; +Cc: lars, andriy.shevchenko, linux-iio, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/iio/health/afe440x.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h
index 0adea0047eba..7750b1adc423 100644
--- a/drivers/iio/health/afe440x.h
+++ b/drivers/iio/health/afe440x.h
@@ -122,9 +122,7 @@ static ssize_t _name ## _show(struct device *dev, \
int i; \
\
for (i = 0; i < ARRAY_SIZE(_table); i++) \
- len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ", \
- _table[i].integer, \
- _table[i].fract); \
+ len += sysfs_emit_at(buf, len, "%d.%06u ", _table[i].integer, _table[i].fract); \
\
buf[len - 1] = '\n'; \
\
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: health: afe440x: Convert to use sysfs_emit_at() API
2022-12-07 7:37 [PATCH] iio: health: afe440x: Convert to use sysfs_emit_at() API ye.xingchen
@ 2022-12-11 12:10 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-12-11 12:10 UTC (permalink / raw)
To: ye.xingchen; +Cc: lars, andriy.shevchenko, linux-iio, linux-kernel
On Wed, 7 Dec 2022 15:37:40 +0800 (CST)
<ye.xingchen@zte.com.cn> wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/iio/health/afe440x.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h
> index 0adea0047eba..7750b1adc423 100644
> --- a/drivers/iio/health/afe440x.h
> +++ b/drivers/iio/health/afe440x.h
> @@ -122,9 +122,7 @@ static ssize_t _name ## _show(struct device *dev, \
> int i; \
> \
> for (i = 0; i < ARRAY_SIZE(_table); i++) \
> - len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ", \
> - _table[i].integer, \
> - _table[i].fract); \
> + len += sysfs_emit_at(buf, len, "%d.%06u ", _table[i].integer, _table[i].fract); \
Please keep to the shorter original wrapping on this.
It's fine to go above 80 chars (below 100) if it makes a significant improvement
to readability. I don't think that's true here, so better to stick to the shorter length.
> \
> buf[len - 1] = '\n'; \
> \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-11 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 7:37 [PATCH] iio: health: afe440x: Convert to use sysfs_emit_at() API ye.xingchen
2022-12-11 12:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).