* [PATCH] dt-bindings: watchdog: allow "timer" as node name
@ 2022-12-12 17:49 Krzysztof Kozlowski
2022-12-13 15:57 ` Rob Herring
2023-01-31 16:59 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-12 17:49 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, linux-watchdog, devicetree, linux-kernel
On some SoCs the watchdog device is actually mixed with timer, e.g.
the qcom,msm-timer on older Qualcomm SoCs where this is actually one
hardware block responsible for both system timer and watchdog.
Allow calling such device nodes as "timer".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
See also:
https://lore.kernel.org/linux-arm-msm/20221212163532.142533-1-krzysztof.kozlowski@linaro.org/T/#t
which causes warnings:
qcom-msm8960-cdp.dtb: timer@200a000: $nodename:0: 'timer@200a000' does not match '^watchdog(@.*|-[0-9a-f])?$'
From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
---
Documentation/devicetree/bindings/watchdog/watchdog.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
index e3dfb02f0ca5..b1daefec86af 100644
--- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
@@ -14,9 +14,14 @@ description: |
This document describes generic bindings which can be used to
describe watchdog devices in a device tree.
+select:
+ properties:
+ $nodename:
+ pattern: "^watchdog(@.*|-[0-9a-f])?$"
+
properties:
$nodename:
- pattern: "^watchdog(@.*|-[0-9a-f])?$"
+ pattern: "^(timer|watchdog)(@.*|-[0-9a-f])?$"
timeout-sec:
description:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: watchdog: allow "timer" as node name
2022-12-12 17:49 [PATCH] dt-bindings: watchdog: allow "timer" as node name Krzysztof Kozlowski
@ 2022-12-13 15:57 ` Rob Herring
2023-01-31 16:59 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-12-13 15:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Guenter Roeck, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-watchdog, Wim Van Sebroeck
On Mon, 12 Dec 2022 18:49:33 +0100, Krzysztof Kozlowski wrote:
> On some SoCs the watchdog device is actually mixed with timer, e.g.
> the qcom,msm-timer on older Qualcomm SoCs where this is actually one
> hardware block responsible for both system timer and watchdog.
>
> Allow calling such device nodes as "timer".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> See also:
> https://lore.kernel.org/linux-arm-msm/20221212163532.142533-1-krzysztof.kozlowski@linaro.org/T/#t
>
> which causes warnings:
>
> qcom-msm8960-cdp.dtb: timer@200a000: $nodename:0: 'timer@200a000' does not match '^watchdog(@.*|-[0-9a-f])?$'
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> ---
> Documentation/devicetree/bindings/watchdog/watchdog.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: watchdog: allow "timer" as node name
2022-12-12 17:49 [PATCH] dt-bindings: watchdog: allow "timer" as node name Krzysztof Kozlowski
2022-12-13 15:57 ` Rob Herring
@ 2023-01-31 16:59 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-01-31 16:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wim Van Sebroeck, Rob Herring, Krzysztof Kozlowski,
linux-watchdog, devicetree, linux-kernel
On Mon, Dec 12, 2022 at 06:49:33PM +0100, Krzysztof Kozlowski wrote:
> On some SoCs the watchdog device is actually mixed with timer, e.g.
> the qcom,msm-timer on older Qualcomm SoCs where this is actually one
> hardware block responsible for both system timer and watchdog.
>
> Allow calling such device nodes as "timer".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> See also:
> https://lore.kernel.org/linux-arm-msm/20221212163532.142533-1-krzysztof.kozlowski@linaro.org/T/#t
>
> which causes warnings:
>
> qcom-msm8960-cdp.dtb: timer@200a000: $nodename:0: 'timer@200a000' does not match '^watchdog(@.*|-[0-9a-f])?$'
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> ---
> Documentation/devicetree/bindings/watchdog/watchdog.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> index e3dfb02f0ca5..b1daefec86af 100644
> --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> @@ -14,9 +14,14 @@ description: |
> This document describes generic bindings which can be used to
> describe watchdog devices in a device tree.
>
> +select:
> + properties:
> + $nodename:
> + pattern: "^watchdog(@.*|-[0-9a-f])?$"
> +
> properties:
> $nodename:
> - pattern: "^watchdog(@.*|-[0-9a-f])?$"
> + pattern: "^(timer|watchdog)(@.*|-[0-9a-f])?$"
>
> timeout-sec:
> description:
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-12 17:49 [PATCH] dt-bindings: watchdog: allow "timer" as node name Krzysztof Kozlowski
2022-12-13 15:57 ` Rob Herring
2023-01-31 16:59 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).