* [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9
[not found] <CGME20221214044418epcas5p3c2708eda3abcf5b217eddacf533e0a0f@epcas5p3.samsung.com>
@ 2022-12-14 4:43 ` Sriranjani P
[not found] ` <CGME20221214044423epcas5p2920e87930665345169745002ec6993c3@epcas5p2.samsung.com>
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Sriranjani P @ 2022-12-14 4:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya
Cc: linux-arm-kernel, linux-kernel, linux-samsung-soc, Sriranjani P
Exynos850 and Exynosautov9 has several different SYSREGs, so use dedicated
compatibles for them in dtsi file and add respective compatible in the
samsung exynos devicetree binding document.
Changes since v2:
1. Addressed the review comment from Rob and removed const from the enum
compatible list.
Changes since v1:
1. As per Krzysztof comment made an enum of deprecated compatibles.
Sriranjani P (4):
dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG
compatibles to Exynos850
arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos850
dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG
compatibles to Exynosautov9
arm64: dts: exynos: add dedicated SYSREG compatibles to Exynosautov9
.../soc/samsung/samsung,exynos-sysreg.yaml | 24 +++++++++++++++----
arch/arm64/boot/dts/exynos/exynos850.dtsi | 6 +++--
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 ++++---
3 files changed, 30 insertions(+), 9 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
[not found] ` <CGME20221214044423epcas5p2920e87930665345169745002ec6993c3@epcas5p2.samsung.com>
@ 2022-12-14 4:43 ` Sriranjani P
2022-12-15 21:39 ` Sam Protsenko
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Sriranjani P @ 2022-12-14 4:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya
Cc: linux-arm-kernel, linux-kernel, linux-samsung-soc, Sriranjani P
Exynos850 has two different SYSREGs, hence add dedicated compatibles for
them and deprecate usage of generic Exynos850 compatible alone.
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
.../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 4954790eda6c..427df05224e5 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,7 +17,6 @@ properties:
- samsung,exynos3-sysreg
- samsung,exynos4-sysreg
- samsung,exynos5-sysreg
- - samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
- tesla,fsd-cam-sysreg
- tesla,fsd-fsys0-sysreg
@@ -33,9 +32,17 @@ properties:
- const: samsung,exynos5433-sysreg
- const: syscon
- items:
- - const: samsung,exynos5433-sysreg
+ - enum:
+ - samsung,exynos5433-sysreg
+ - samsung,exynos850-sysreg
+ - const: syscon
+ deprecated: true
+ - items:
+ - enum:
+ - samsung,exynos850-cmgp-sysreg
+ - samsung,exynos850-peri-sysreg
+ - const: samsung,exynos850-sysreg
- const: syscon
- deprecated: true
reg:
maxItems: 1
@@ -53,6 +60,8 @@ allOf:
compatible:
contains:
enum:
+ - samsung,exynos850-cmgp-sysreg
+ - samsung,exynos850-peri-sysreg
- samsung,exynos850-sysreg
then:
required:
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3 2/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos850
[not found] ` <CGME20221214044427epcas5p39131549dc4529ea41d9916d81d3d5fce@epcas5p3.samsung.com>
@ 2022-12-14 4:43 ` Sriranjani P
2022-12-15 21:39 ` Sam Protsenko
0 siblings, 1 reply; 14+ messages in thread
From: Sriranjani P @ 2022-12-14 4:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya
Cc: linux-arm-kernel, linux-kernel, linux-samsung-soc, Sriranjani P
Exynos850 has two different SYSREGs, so use dedicated compatibles for them.
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos850.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
index c61441f3a89a..a38fe5129937 100644
--- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
@@ -549,13 +549,15 @@
};
sysreg_peri: syscon@10020000 {
- compatible = "samsung,exynos850-sysreg", "syscon";
+ compatible = "samsung,exynos850-peri-sysreg",
+ "samsung,exynos850-sysreg", "syscon";
reg = <0x10020000 0x10000>;
clocks = <&cmu_peri CLK_GOUT_SYSREG_PERI_PCLK>;
};
sysreg_cmgp: syscon@11c20000 {
- compatible = "samsung,exynos850-sysreg", "syscon";
+ compatible = "samsung,exynos850-cmgp-sysreg",
+ "samsung,exynos850-sysreg", "syscon";
reg = <0x11c20000 0x10000>;
clocks = <&cmu_cmgp CLK_GOUT_SYSREG_CMGP_PCLK>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9
[not found] ` <CGME20221214044430epcas5p4c896fde60471fea774387bd74abe0ea5@epcas5p4.samsung.com>
@ 2022-12-14 4:43 ` Sriranjani P
2022-12-20 12:32 ` Chanho Park
2022-12-20 17:18 ` Rob Herring
0 siblings, 2 replies; 14+ messages in thread
From: Sriranjani P @ 2022-12-14 4:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya
Cc: linux-arm-kernel, linux-kernel, linux-samsung-soc, Sriranjani P
Exynosautov9 has several different SYSREGs, so use dedicated compatibles
for them and deprecate usage of generic Exynosautov9 compatible alone.
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
.../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 427df05224e5..da43efb0ce80 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,7 +17,6 @@ properties:
- samsung,exynos3-sysreg
- samsung,exynos4-sysreg
- samsung,exynos5-sysreg
- - samsung,exynosautov9-sysreg
- tesla,fsd-cam-sysreg
- tesla,fsd-fsys0-sysreg
- tesla,fsd-fsys1-sysreg
@@ -35,6 +34,7 @@ properties:
- enum:
- samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
+ - samsung,exynosautov9-sysreg
- const: syscon
deprecated: true
- items:
@@ -43,6 +43,13 @@ properties:
- samsung,exynos850-peri-sysreg
- const: samsung,exynos850-sysreg
- const: syscon
+ - items:
+ - enum:
+ - samsung,exynosautov9-fsys2-sysreg
+ - samsung,exynosautov9-peric0-sysreg
+ - samsung,exynosautov9-peric1-sysreg
+ - const: samsung,exynosautov9-sysreg
+ - const: syscon
reg:
maxItems: 1
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3 4/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynosautov9
[not found] ` <CGME20221214044434epcas5p212735c11a8ff9f72e25742e4ac8a7794@epcas5p2.samsung.com>
@ 2022-12-14 4:43 ` Sriranjani P
2022-12-20 12:34 ` Chanho Park
0 siblings, 1 reply; 14+ messages in thread
From: Sriranjani P @ 2022-12-14 4:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya
Cc: linux-arm-kernel, linux-kernel, linux-samsung-soc, Sriranjani P
Exynosautov9 has several different SYSREGs, so use dedicated compatibles
for them.
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index 5dc361734cfe..d3c5cdeff47f 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -370,17 +370,20 @@
};
syscon_fsys2: syscon@17c20000 {
- compatible = "samsung,exynosautov9-sysreg", "syscon";
+ compatible = "samsung,exynosautov9-fsys2-sysreg",
+ "samsung,exynosautov9-sysreg", "syscon";
reg = <0x17c20000 0x1000>;
};
syscon_peric0: syscon@10220000 {
- compatible = "samsung,exynosautov9-sysreg", "syscon";
+ compatible = "samsung,exynosautov9-peric0-sysreg",
+ "samsung,exynosautov9-sysreg", "syscon";
reg = <0x10220000 0x2000>;
};
syscon_peric1: syscon@10820000 {
- compatible = "samsung,exynosautov9-sysreg", "syscon";
+ compatible = "samsung,exynosautov9-peric1-sysreg",
+ "samsung,exynosautov9-sysreg", "syscon";
reg = <0x10820000 0x2000>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
2022-12-14 4:43 ` [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
@ 2022-12-15 21:39 ` Sam Protsenko
2022-12-20 17:17 ` Rob Herring
2023-01-09 1:15 ` Rob Herring
2 siblings, 0 replies; 14+ messages in thread
From: Sam Protsenko @ 2022-12-15 21:39 UTC (permalink / raw)
To: Sriranjani P
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya, linux-arm-kernel, linux-kernel,
linux-samsung-soc
On Tue, 13 Dec 2022 at 22:47, Sriranjani P <sriranjani.p@samsung.com> wrote:
>
> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
> them and deprecate usage of generic Exynos850 compatible alone.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Thanks!
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 4954790eda6c..427df05224e5 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,7 +17,6 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - tesla,fsd-cam-sysreg
> - tesla,fsd-fsys0-sysreg
> @@ -33,9 +32,17 @@ properties:
> - const: samsung,exynos5433-sysreg
> - const: syscon
> - items:
> - - const: samsung,exynos5433-sysreg
> + - enum:
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - const: syscon
> + deprecated: true
> + - items:
> + - enum:
> + - samsung,exynos850-cmgp-sysreg
> + - samsung,exynos850-peri-sysreg
> + - const: samsung,exynos850-sysreg
> - const: syscon
> - deprecated: true
>
> reg:
> maxItems: 1
> @@ -53,6 +60,8 @@ allOf:
> compatible:
> contains:
> enum:
> + - samsung,exynos850-cmgp-sysreg
> + - samsung,exynos850-peri-sysreg
> - samsung,exynos850-sysreg
> then:
> required:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos850
2022-12-14 4:43 ` [PATCH v3 2/4] arm64: dts: exynos: " Sriranjani P
@ 2022-12-15 21:39 ` Sam Protsenko
0 siblings, 0 replies; 14+ messages in thread
From: Sam Protsenko @ 2022-12-15 21:39 UTC (permalink / raw)
To: Sriranjani P
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya, linux-arm-kernel, linux-kernel,
linux-samsung-soc
On Tue, 13 Dec 2022 at 22:47, Sriranjani P <sriranjani.p@samsung.com> wrote:
>
> Exynos850 has two different SYSREGs, so use dedicated compatibles for them.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Thanks!
> arch/arm64/boot/dts/exynos/exynos850.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> index c61441f3a89a..a38fe5129937 100644
> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi
> @@ -549,13 +549,15 @@
> };
>
> sysreg_peri: syscon@10020000 {
> - compatible = "samsung,exynos850-sysreg", "syscon";
> + compatible = "samsung,exynos850-peri-sysreg",
> + "samsung,exynos850-sysreg", "syscon";
> reg = <0x10020000 0x10000>;
> clocks = <&cmu_peri CLK_GOUT_SYSREG_PERI_PCLK>;
> };
>
> sysreg_cmgp: syscon@11c20000 {
> - compatible = "samsung,exynos850-sysreg", "syscon";
> + compatible = "samsung,exynos850-cmgp-sysreg",
> + "samsung,exynos850-sysreg", "syscon";
> reg = <0x11c20000 0x10000>;
> clocks = <&cmu_cmgp CLK_GOUT_SYSREG_CMGP_PCLK>;
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9
2022-12-14 4:43 ` [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 Sriranjani P
@ 2022-12-20 12:32 ` Chanho Park
2022-12-20 17:18 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Chanho Park @ 2022-12-20 12:32 UTC (permalink / raw)
To: Sriranjani P
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya, linux-arm-kernel, linux-kernel,
linux-samsung-soc
On Wed, Dec 14, 2022 at 1:49 PM Sriranjani P <sriranjani.p@samsung.com> wrote:
>
> Exynosautov9 has several different SYSREGs, so use dedicated compatibles
> for them and deprecate usage of generic Exynosautov9 compatible alone.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
Reviewed-by: Chanho Park <chanho61.park@samsung.com>
> ---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 427df05224e5..da43efb0ce80 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,7 +17,6 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynosautov9-sysreg
> - tesla,fsd-cam-sysreg
> - tesla,fsd-fsys0-sysreg
> - tesla,fsd-fsys1-sysreg
> @@ -35,6 +34,7 @@ properties:
> - enum:
> - samsung,exynos5433-sysreg
> - samsung,exynos850-sysreg
> + - samsung,exynosautov9-sysreg
> - const: syscon
> deprecated: true
> - items:
> @@ -43,6 +43,13 @@ properties:
> - samsung,exynos850-peri-sysreg
> - const: samsung,exynos850-sysreg
> - const: syscon
> + - items:
> + - enum:
> + - samsung,exynosautov9-fsys2-sysreg
> + - samsung,exynosautov9-peric0-sysreg
> + - samsung,exynosautov9-peric1-sysreg
> + - const: samsung,exynosautov9-sysreg
> + - const: syscon
>
> reg:
> maxItems: 1
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 4/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynosautov9
2022-12-14 4:43 ` [PATCH v3 4/4] arm64: dts: exynos: " Sriranjani P
@ 2022-12-20 12:34 ` Chanho Park
0 siblings, 0 replies; 14+ messages in thread
From: Chanho Park @ 2022-12-20 12:34 UTC (permalink / raw)
To: Sriranjani P
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, alim.akhtar,
pankaj.dubey, ravi.patel, sathya, linux-arm-kernel, linux-kernel,
linux-samsung-soc
On Wed, Dec 14, 2022 at 1:50 PM Sriranjani P <sriranjani.p@samsung.com> wrote:
>
> Exynosautov9 has several different SYSREGs, so use dedicated compatibles
> for them.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
Reviewed-by: Chanho Park <chanho61.park@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> index 5dc361734cfe..d3c5cdeff47f 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> @@ -370,17 +370,20 @@
> };
>
> syscon_fsys2: syscon@17c20000 {
> - compatible = "samsung,exynosautov9-sysreg", "syscon";
> + compatible = "samsung,exynosautov9-fsys2-sysreg",
> + "samsung,exynosautov9-sysreg", "syscon";
> reg = <0x17c20000 0x1000>;
> };
>
> syscon_peric0: syscon@10220000 {
> - compatible = "samsung,exynosautov9-sysreg", "syscon";
> + compatible = "samsung,exynosautov9-peric0-sysreg",
> + "samsung,exynosautov9-sysreg", "syscon";
> reg = <0x10220000 0x2000>;
> };
>
> syscon_peric1: syscon@10820000 {
> - compatible = "samsung,exynosautov9-sysreg", "syscon";
> + compatible = "samsung,exynosautov9-peric1-sysreg",
> + "samsung,exynosautov9-sysreg", "syscon";
> reg = <0x10820000 0x2000>;
> };
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
2022-12-14 4:43 ` [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
2022-12-15 21:39 ` Sam Protsenko
@ 2022-12-20 17:17 ` Rob Herring
2023-01-09 1:15 ` Rob Herring
2 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-12-20 17:17 UTC (permalink / raw)
To: Sriranjani P
Cc: pankaj.dubey, devicetree, ravi.patel, sathya, linux-arm-kernel,
alim.akhtar, linux-samsung-soc, krzysztof.kozlowski+dt, robh+dt,
linux-kernel
On Wed, 14 Dec 2022 10:13:39 +0530, Sriranjani P wrote:
> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
> them and deprecate usage of generic Exynos850 compatible alone.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9
2022-12-14 4:43 ` [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 Sriranjani P
2022-12-20 12:32 ` Chanho Park
@ 2022-12-20 17:18 ` Rob Herring
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-12-20 17:18 UTC (permalink / raw)
To: Sriranjani P
Cc: linux-arm-kernel, sathya, robh+dt, devicetree, linux-samsung-soc,
ravi.patel, pankaj.dubey, linux-kernel, alim.akhtar,
krzysztof.kozlowski+dt
On Wed, 14 Dec 2022 10:13:41 +0530, Sriranjani P wrote:
> Exynosautov9 has several different SYSREGs, so use dedicated compatibles
> for them and deprecate usage of generic Exynosautov9 compatible alone.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9
2022-12-14 4:43 ` [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Sriranjani P
` (3 preceding siblings ...)
[not found] ` <CGME20221214044434epcas5p212735c11a8ff9f72e25742e4ac8a7794@epcas5p2.samsung.com>
@ 2022-12-26 15:17 ` Krzysztof Kozlowski
4 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-26 15:17 UTC (permalink / raw)
To: robh+dt, pankaj.dubey, alim.akhtar, sathya,
krzysztof.kozlowski+dt, ravi.patel, devicetree, Sriranjani P
Cc: Krzysztof Kozlowski, linux-kernel, linux-samsung-soc, linux-arm-kernel
On Wed, 14 Dec 2022 10:13:38 +0530, Sriranjani P wrote:
> Exynos850 and Exynosautov9 has several different SYSREGs, so use dedicated
> compatibles for them in dtsi file and add respective compatible in the
> samsung exynos devicetree binding document.
>
> Changes since v2:
> 1. Addressed the review comment from Rob and removed const from the enum
> compatible list.
>
> [...]
Applied, thanks!
[1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
https://git.kernel.org/krzk/linux/c/0a2af7bdeeb498e68771f9bb744aac79999f5980
[2/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos850
https://git.kernel.org/krzk/linux/c/40a1827ea4c91c9c3cdfb8f18c78ba52da55b043
[3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9
https://git.kernel.org/krzk/linux/c/dd5cc8072a3f285cff4f9a3869012557d547fb9d
[4/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynosautov9
https://git.kernel.org/krzk/linux/c/138d72031ec3d60edf6b382cd089a7939f73697c
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
2022-12-14 4:43 ` [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
2022-12-15 21:39 ` Sam Protsenko
2022-12-20 17:17 ` Rob Herring
@ 2023-01-09 1:15 ` Rob Herring
2023-01-09 8:37 ` Krzysztof Kozlowski
2 siblings, 1 reply; 14+ messages in thread
From: Rob Herring @ 2023-01-09 1:15 UTC (permalink / raw)
To: Sriranjani P
Cc: krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey,
ravi.patel, sathya, linux-arm-kernel, linux-kernel,
linux-samsung-soc
On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@samsung.com> wrote:
>
> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
> them and deprecate usage of generic Exynos850 compatible alone.
>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 4954790eda6c..427df05224e5 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -17,7 +17,6 @@ properties:
> - samsung,exynos3-sysreg
> - samsung,exynos4-sysreg
> - samsung,exynos5-sysreg
> - - samsung,exynos850-sysreg
> - samsung,exynosautov9-sysreg
> - tesla,fsd-cam-sysreg
> - tesla,fsd-fsys0-sysreg
> @@ -33,9 +32,17 @@ properties:
> - const: samsung,exynos5433-sysreg
> - const: syscon
> - items:
> - - const: samsung,exynos5433-sysreg
> + - enum:
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - const: syscon
> + deprecated: true
This is throwing an error in linux-next now.
How can 1 item in a list be deprecated? What's the not deprecated
value for the entry? Probably this needs to move up to 'items' as the
whole entry is deprecated.
> + - items:
> + - enum:
> + - samsung,exynos850-cmgp-sysreg
> + - samsung,exynos850-peri-sysreg
> + - const: samsung,exynos850-sysreg
> - const: syscon
> - deprecated: true
>
> reg:
> maxItems: 1
> @@ -53,6 +60,8 @@ allOf:
> compatible:
> contains:
> enum:
> + - samsung,exynos850-cmgp-sysreg
> + - samsung,exynos850-peri-sysreg
> - samsung,exynos850-sysreg
> then:
> required:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850
2023-01-09 1:15 ` Rob Herring
@ 2023-01-09 8:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-09 8:37 UTC (permalink / raw)
To: Rob Herring, Sriranjani P
Cc: krzysztof.kozlowski+dt, devicetree, alim.akhtar, pankaj.dubey,
ravi.patel, sathya, linux-arm-kernel, linux-kernel,
linux-samsung-soc
On 09/01/2023 02:15, Rob Herring wrote:
> On Tue, Dec 13, 2022 at 10:47 PM Sriranjani P <sriranjani.p@samsung.com> wrote:
>>
>> Exynos850 has two different SYSREGs, hence add dedicated compatibles for
>> them and deprecate usage of generic Exynos850 compatible alone.
>>
>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>> ---
>> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++---
>> 1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> index 4954790eda6c..427df05224e5 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> @@ -17,7 +17,6 @@ properties:
>> - samsung,exynos3-sysreg
>> - samsung,exynos4-sysreg
>> - samsung,exynos5-sysreg
>> - - samsung,exynos850-sysreg
>> - samsung,exynosautov9-sysreg
>> - tesla,fsd-cam-sysreg
>> - tesla,fsd-fsys0-sysreg
>> @@ -33,9 +32,17 @@ properties:
>> - const: samsung,exynos5433-sysreg
>> - const: syscon
>> - items:
>> - - const: samsung,exynos5433-sysreg
>> + - enum:
>> + - samsung,exynos5433-sysreg
>> + - samsung,exynos850-sysreg
>> + - const: syscon
>> + deprecated: true
>
> This is throwing an error in linux-next now.
>
> How can 1 item in a list be deprecated? What's the not deprecated
> value for the entry? Probably this needs to move up to 'items' as the
> whole entry is deprecated.
I missed this. I'll fix it. I'll updated my dtschema and see the error now.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-01-09 8:37 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20221214044418epcas5p3c2708eda3abcf5b217eddacf533e0a0f@epcas5p3.samsung.com>
2022-12-14 4:43 ` [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Sriranjani P
[not found] ` <CGME20221214044423epcas5p2920e87930665345169745002ec6993c3@epcas5p2.samsung.com>
2022-12-14 4:43 ` [PATCH v3 1/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos850 Sriranjani P
2022-12-15 21:39 ` Sam Protsenko
2022-12-20 17:17 ` Rob Herring
2023-01-09 1:15 ` Rob Herring
2023-01-09 8:37 ` Krzysztof Kozlowski
[not found] ` <CGME20221214044427epcas5p39131549dc4529ea41d9916d81d3d5fce@epcas5p3.samsung.com>
2022-12-14 4:43 ` [PATCH v3 2/4] arm64: dts: exynos: " Sriranjani P
2022-12-15 21:39 ` Sam Protsenko
[not found] ` <CGME20221214044430epcas5p4c896fde60471fea774387bd74abe0ea5@epcas5p4.samsung.com>
2022-12-14 4:43 ` [PATCH v3 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynosautov9 Sriranjani P
2022-12-20 12:32 ` Chanho Park
2022-12-20 17:18 ` Rob Herring
[not found] ` <CGME20221214044434epcas5p212735c11a8ff9f72e25742e4ac8a7794@epcas5p2.samsung.com>
2022-12-14 4:43 ` [PATCH v3 4/4] arm64: dts: exynos: " Sriranjani P
2022-12-20 12:34 ` Chanho Park
2022-12-26 15:17 ` [PATCH v3 0/4] amr64: dts: exynos: add dedicated SYSREG compatibles to Exynos850 and Exynosautov9 Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).