* [PATCH] PCI: endpoint: pci-epf-vntb: fix doc warnings in pci-epf-vntb.c
@ 2022-12-14 6:26 Yang Yingliang
2023-04-08 9:23 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-12-14 6:26 UTC (permalink / raw)
To: linux-pci, linux-kernel
Cc: jdmason, dave.jiang, allenbh, lpieralisi, kw, mani, kishon,
bhelgaas, helgaas, Frank.Li
Fix the following make W=1 warnings:
drivers/pci/endpoint/functions/pci-epf-vntb.c:338: warning: Function parameter or member 'ntb' not described in 'epf_ntb_config_sspad_bar_clear'
drivers/pci/endpoint/functions/pci-epf-vntb.c:338: warning: Excess function parameter 'ntb_epc' description in 'epf_ntb_config_sspad_bar_clear'
drivers/pci/endpoint/functions/pci-epf-vntb.c:645: warning: Function parameter or member 'num_mws' not described in 'epf_ntb_mw_bar_clear'
Fixes: 8e4bfbe644a6 ("PCI: endpoint: pci-epf-vntb: fix error handle in epf_ntb_mw_bar_init()")
Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/pci/endpoint/functions/pci-epf-vntb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
index 0ea85e1d292e..9e3a21c9debe 100644
--- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
+++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
@@ -321,7 +321,7 @@ static void epf_ntb_cmd_handler(struct work_struct *work)
/**
* epf_ntb_config_sspad_bar_clear() - Clear Config + Self scratchpad BAR
- * @ntb_epc: EPC associated with one of the HOST which holds peer's outbound
+ * @ntb: EPC associated with one of the HOST which holds peer's outbound
* address.
*
* Clear BAR0 of EP CONTROLLER 1 which contains the HOST1's config and
@@ -640,6 +640,7 @@ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb)
/**
* epf_ntb_mw_bar_clear() - Clear Memory window BARs
* @ntb: NTB device that facilitates communication between HOST and vHOST
+ * @num_mws: the number of Memory window BARs that to be cleared
*/
static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: endpoint: pci-epf-vntb: fix doc warnings in pci-epf-vntb.c
2022-12-14 6:26 [PATCH] PCI: endpoint: pci-epf-vntb: fix doc warnings in pci-epf-vntb.c Yang Yingliang
@ 2023-04-08 9:23 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2023-04-08 9:23 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-pci, linux-kernel, jdmason, dave.jiang, allenbh,
lpieralisi, kw, kishon, bhelgaas, helgaas, Frank.Li
On Wed, Dec 14, 2022 at 02:26:17PM +0800, Yang Yingliang wrote:
> Fix the following make W=1 warnings:
>
> drivers/pci/endpoint/functions/pci-epf-vntb.c:338: warning: Function parameter or member 'ntb' not described in 'epf_ntb_config_sspad_bar_clear'
> drivers/pci/endpoint/functions/pci-epf-vntb.c:338: warning: Excess function parameter 'ntb_epc' description in 'epf_ntb_config_sspad_bar_clear'
> drivers/pci/endpoint/functions/pci-epf-vntb.c:645: warning: Function parameter or member 'num_mws' not described in 'epf_ntb_mw_bar_clear'
>
> Fixes: 8e4bfbe644a6 ("PCI: endpoint: pci-epf-vntb: fix error handle in epf_ntb_mw_bar_init()")
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
> drivers/pci/endpoint/functions/pci-epf-vntb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index 0ea85e1d292e..9e3a21c9debe 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -321,7 +321,7 @@ static void epf_ntb_cmd_handler(struct work_struct *work)
>
> /**
> * epf_ntb_config_sspad_bar_clear() - Clear Config + Self scratchpad BAR
> - * @ntb_epc: EPC associated with one of the HOST which holds peer's outbound
> + * @ntb: EPC associated with one of the HOST which holds peer's outbound
> * address.
> *
> * Clear BAR0 of EP CONTROLLER 1 which contains the HOST1's config and
> @@ -640,6 +640,7 @@ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb)
> /**
> * epf_ntb_mw_bar_clear() - Clear Memory window BARs
> * @ntb: NTB device that facilitates communication between HOST and vHOST
> + * @num_mws: the number of Memory window BARs that to be cleared
> */
> static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws)
> {
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-08 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 6:26 [PATCH] PCI: endpoint: pci-epf-vntb: fix doc warnings in pci-epf-vntb.c Yang Yingliang
2023-04-08 9:23 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).