* [PATCH] rust: prelude: prevent doc inline of external imports
@ 2022-12-14 9:34 Finn Behrens
2022-12-21 9:33 ` Vincenzo
2023-01-16 23:35 ` Miguel Ojeda
0 siblings, 2 replies; 3+ messages in thread
From: Finn Behrens @ 2022-12-14 9:34 UTC (permalink / raw)
To: Miguel Ojeda, Wedson Almeida Filho, Alex Gaynor, Boqun Feng,
Gary Guo, Björn Roy Baron
Cc: rust-for-linux, linux-kernel, patches
This shows exactly where the items are from, previously the items from
macros, alloc and core where shown as a decleration from the kernel crate,
this shows the correct path.
Signed-off-by: Finn Behrens <fin@nyantec.com>
---
rust/kernel/prelude.rs | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
index 7a90249ee9b9..917721e791b6 100644
--- a/rust/kernel/prelude.rs
+++ b/rust/kernel/prelude.rs
@@ -11,15 +11,21 @@
//! use kernel::prelude::*;
//! ```
+#[doc(no_inline)]
pub use core::pin::Pin;
+#[doc(no_inline)]
pub use alloc::{boxed::Box, vec::Vec};
+#[doc(no_inline)]
pub use macros::{module, vtable};
pub use super::build_assert;
-pub use super::{dbg, pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
+// super::std_vendor is hidden, which makes the macro inline for some reason
+#[doc(no_inline)]
+pub use super::dbg;
+pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
pub use super::static_assert;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: prelude: prevent doc inline of external imports
2022-12-14 9:34 [PATCH] rust: prelude: prevent doc inline of external imports Finn Behrens
@ 2022-12-21 9:33 ` Vincenzo
2023-01-16 23:35 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Vincenzo @ 2022-12-21 9:33 UTC (permalink / raw)
To: Finn Behrens, Miguel Ojeda, Wedson Almeida Filho, Alex Gaynor,
Boqun Feng, Gary Guo, Björn Roy Baron
Cc: rust-for-linux, linux-kernel, patches
IMOHO this make sense.
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
On Wed Dec 14, 2022 at 10:34 AM CET, Finn Behrens wrote:
> This shows exactly where the items are from, previously the items from
> macros, alloc and core where shown as a decleration from the kernel crate,
> this shows the correct path.
>
> Signed-off-by: Finn Behrens <fin@nyantec.com>
> ---
> rust/kernel/prelude.rs | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
> index 7a90249ee9b9..917721e791b6 100644
> --- a/rust/kernel/prelude.rs
> +++ b/rust/kernel/prelude.rs
> @@ -11,15 +11,21 @@
> //! use kernel::prelude::*;
> //! ```
>
> +#[doc(no_inline)]
> pub use core::pin::Pin;
>
> +#[doc(no_inline)]
> pub use alloc::{boxed::Box, vec::Vec};
>
> +#[doc(no_inline)]
> pub use macros::{module, vtable};
>
> pub use super::build_assert;
>
> -pub use super::{dbg, pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
> +// super::std_vendor is hidden, which makes the macro inline for some reason
> +#[doc(no_inline)]
> +pub use super::dbg;
> +pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
>
> pub use super::static_assert;
>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: prelude: prevent doc inline of external imports
2022-12-14 9:34 [PATCH] rust: prelude: prevent doc inline of external imports Finn Behrens
2022-12-21 9:33 ` Vincenzo
@ 2023-01-16 23:35 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2023-01-16 23:35 UTC (permalink / raw)
To: Finn Behrens
Cc: Miguel Ojeda, Wedson Almeida Filho, Alex Gaynor, Boqun Feng,
Gary Guo, Björn Roy Baron, rust-for-linux, linux-kernel,
patches
On Wed, Dec 14, 2022 at 10:35 AM Finn Behrens <fin@nyantec.com> wrote:
>
> This shows exactly where the items are from, previously the items from
> macros, alloc and core where shown as a decleration from the kernel crate,
> this shows the correct path.
Applied to rust-next, thanks all! (as discussed, I added the Link on
my side, plus fixed a couple typos and the comment style).
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-16 23:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 9:34 [PATCH] rust: prelude: prevent doc inline of external imports Finn Behrens
2022-12-21 9:33 ` Vincenzo
2023-01-16 23:35 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).