[PATCH 1/2] kselftest/arm64: Remove the local NUM_VL definition

[PATCH 1/2] kselftest/arm64: Remove the local NUM_VL definition

[Zenghui Yu]

It was introduced in commit b77e995e3b96 ("kselftest/arm64: Add a test
program to exercise the syscall ABI") but never actually used. Remove it.

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 tools/testing/selftests/arm64/abi/syscall-abi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/arm64/abi/syscall-abi.c b/tools/testing/selftests/arm64/abi/syscall-abi.c
index 9800f9dc6b35..24a498029c78 100644
--- a/tools/testing/selftests/arm64/abi/syscall-abi.c
+++ b/tools/testing/selftests/arm64/abi/syscall-abi.c
@@ -20,8 +20,6 @@
 
 #include "syscall-abi.h"
 
-#define NUM_VL ((SVE_VQ_MAX - SVE_VQ_MIN) + 1)
-
 static int default_sme_vl;
 
 extern void do_syscall(int sve_vl, int sme_vl);
-- 
2.33.0

[PATCH 2/2] kselftest/arm64: Correct buffer size for SME ZA storage

[Zenghui Yu]

It looks like a copy-paste error to describe the ZA buffer size using (the
number of P registers * the maximum size of a Z register). This doesn't
have practical impact though as we're always allocating enough space even
for the architectural maximum ZA storage, with SVL equals to 2048 bits.

Switch to use ZA_SIG_REGS_SIZE(SVE_VQ_MAX). setup_za() will need to
initialize two 64MB arraies with this change and can be optimized later (if
someone complain).

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
 tools/testing/selftests/arm64/abi/syscall-abi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/arm64/abi/syscall-abi.c b/tools/testing/selftests/arm64/abi/syscall-abi.c
index 24a498029c78..4adeb21f500e 100644
--- a/tools/testing/selftests/arm64/abi/syscall-abi.c
+++ b/tools/testing/selftests/arm64/abi/syscall-abi.c
@@ -282,8 +282,8 @@ static int check_svcr(struct syscall_cfg *cfg, int sve_vl, int sme_vl,
 	return errors;
 }
 
-uint8_t za_in[SVE_NUM_PREGS * __SVE_ZREG_SIZE(SVE_VQ_MAX)];
-uint8_t za_out[SVE_NUM_PREGS * __SVE_ZREG_SIZE(SVE_VQ_MAX)];
+uint8_t za_in[ZA_SIG_REGS_SIZE(SVE_VQ_MAX)];
+uint8_t za_out[ZA_SIG_REGS_SIZE(SVE_VQ_MAX)];
 
 static void setup_za(struct syscall_cfg *cfg, int sve_vl, int sme_vl,
 		     uint64_t svcr)
-- 
2.33.0

Re: [PATCH 2/2] kselftest/arm64: Correct buffer size for SME ZA storage

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

On Sun, Dec 18, 2022 at 05:29:42PM +0800, Zenghui Yu wrote:
> It looks like a copy-paste error to describe the ZA buffer size using (the
> number of P registers * the maximum size of a Z register). This doesn't
> have practical impact though as we're always allocating enough space even
> for the architectural maximum ZA storage, with SVL equals to 2048 bits.

Reviewed-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] kselftest/arm64: Remove the local NUM_VL definition

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

On Sun, Dec 18, 2022 at 05:29:41PM +0800, Zenghui Yu wrote:
> It was introduced in commit b77e995e3b96 ("kselftest/arm64: Add a test
> program to exercise the syscall ABI") but never actually used. Remove it.

Reviewed-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/2] kselftest/arm64: Remove the local NUM_VL definition

[Catalin Marinas]

On Sun, 18 Dec 2022 17:29:41 +0800, Zenghui Yu wrote:
> It was introduced in commit b77e995e3b96 ("kselftest/arm64: Add a test
> program to exercise the syscall ABI") but never actually used. Remove it.
> 
> 

Applied to arm64 (for-next/kselftest), thanks!

[1/2] kselftest/arm64: Remove the local NUM_VL definition
      https://git.kernel.org/arm64/c/00598857e38f
[2/2] kselftest/arm64: Correct buffer size for SME ZA storage
      https://git.kernel.org/arm64/c/daac835347a5

-- 
Catalin