* [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins
@ 2022-12-31 16:42 Adam Skladowski
2022-12-31 20:14 ` Marijn Suijten
2023-01-09 13:40 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Adam Skladowski @ 2022-12-31 16:42 UTC (permalink / raw)
Cc: phone-devel, ~postmarketos/upstreaming, Adam Skladowski,
Bjorn Andersson, Andy Gross, Konrad Dybcio, Linus Walleij,
AngeloGioacchino Del Regno, linux-arm-msm, linux-gpio,
linux-kernel
Adjust names of function for wcss pins, also fix third gpio in bt group.
Fixes: bcd11493f0ab ("pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956")
Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-msm8976.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
index ec43edf9b660..e11d84584719 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
@@ -733,7 +733,7 @@ static const char * const codec_int2_groups[] = {
"gpio74",
};
static const char * const wcss_bt_groups[] = {
- "gpio39", "gpio47", "gpio88",
+ "gpio39", "gpio47", "gpio48",
};
static const char * const sdc3_groups[] = {
"gpio39", "gpio40", "gpio41",
@@ -958,9 +958,9 @@ static const struct msm_pingroup msm8976_groups[] = {
PINGROUP(37, NA, NA, NA, qdss_tracedata_b, NA, NA, NA, NA, NA),
PINGROUP(38, NA, NA, NA, NA, NA, NA, NA, qdss_tracedata_b, NA),
PINGROUP(39, wcss_bt, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
- PINGROUP(40, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
- PINGROUP(41, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
- PINGROUP(42, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
+ PINGROUP(40, wcss_wlan2, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
+ PINGROUP(41, wcss_wlan1, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
+ PINGROUP(42, wcss_wlan0, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
PINGROUP(43, wcss_wlan, sdc3, NA, NA, qdss_tracedata_a, NA, NA, NA, NA),
PINGROUP(44, wcss_wlan, sdc3, NA, NA, NA, NA, NA, NA, NA),
PINGROUP(45, wcss_fm, NA, qdss_tracectl_a, NA, NA, NA, NA, NA, NA),
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins
2022-12-31 16:42 [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins Adam Skladowski
@ 2022-12-31 20:14 ` Marijn Suijten
2023-01-09 13:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Marijn Suijten @ 2022-12-31 20:14 UTC (permalink / raw)
To: Adam Skladowski
Cc: phone-devel, ~postmarketos/upstreaming, Bjorn Andersson,
Andy Gross, Konrad Dybcio, Linus Walleij,
AngeloGioacchino Del Regno, linux-arm-msm, linux-gpio,
linux-kernel
On 2022-12-31 17:42:50, Adam Skladowski wrote:
> Adjust names of function for wcss pins, also fix third gpio in bt group.
Agreed, the wcss_wlan[210]_groups arrays and functions are unused prior
to this patch nor are pins 40/41/42 part of wcss_wlan_groups (which only
contains 43 and 44). Same for the BT fix, the pingroup for pin 48 is
clearly wcss_bt and there's none for pin 88.
You could have made that more clear in the commit message though (and
I'm not even sure if pinctrl allows the pins to be used when the groups
are misaligned like this, at least there's a fixes: tag), but for the
change itself:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Fixes: bcd11493f0ab ("pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956")
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
> drivers/pinctrl/qcom/pinctrl-msm8976.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8976.c b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> index ec43edf9b660..e11d84584719 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8976.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8976.c
> @@ -733,7 +733,7 @@ static const char * const codec_int2_groups[] = {
> "gpio74",
> };
> static const char * const wcss_bt_groups[] = {
> - "gpio39", "gpio47", "gpio88",
> + "gpio39", "gpio47", "gpio48",
> };
> static const char * const sdc3_groups[] = {
> "gpio39", "gpio40", "gpio41",
> @@ -958,9 +958,9 @@ static const struct msm_pingroup msm8976_groups[] = {
> PINGROUP(37, NA, NA, NA, qdss_tracedata_b, NA, NA, NA, NA, NA),
> PINGROUP(38, NA, NA, NA, NA, NA, NA, NA, qdss_tracedata_b, NA),
> PINGROUP(39, wcss_bt, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> - PINGROUP(40, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> - PINGROUP(41, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> - PINGROUP(42, wcss_wlan, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> + PINGROUP(40, wcss_wlan2, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> + PINGROUP(41, wcss_wlan1, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> + PINGROUP(42, wcss_wlan0, sdc3, NA, qdss_tracedata_a, NA, NA, NA, NA, NA),
> PINGROUP(43, wcss_wlan, sdc3, NA, NA, qdss_tracedata_a, NA, NA, NA, NA),
> PINGROUP(44, wcss_wlan, sdc3, NA, NA, NA, NA, NA, NA, NA),
> PINGROUP(45, wcss_fm, NA, qdss_tracectl_a, NA, NA, NA, NA, NA, NA),
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins
2022-12-31 16:42 [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins Adam Skladowski
2022-12-31 20:14 ` Marijn Suijten
@ 2023-01-09 13:40 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-01-09 13:40 UTC (permalink / raw)
To: Adam Skladowski
Cc: phone-devel, ~postmarketos/upstreaming, Bjorn Andersson,
Andy Gross, Konrad Dybcio, AngeloGioacchino Del Regno,
linux-arm-msm, linux-gpio, linux-kernel
On Sat, Dec 31, 2022 at 5:43 PM Adam Skladowski <a39.skl@gmail.com> wrote:
> Adjust names of function for wcss pins, also fix third gpio in bt group.
>
> Fixes: bcd11493f0ab ("pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956")
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-09 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-31 16:42 [PATCH] pinctrl: qcom: pinctrl-msm8976: Correct function names for wcss pins Adam Skladowski
2022-12-31 20:14 ` Marijn Suijten
2023-01-09 13:40 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).