From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: angelo@amarulasolutions.com, michael@amarulasolutions.com,
tommaso.merciai@amarulasolutions.com,
Chen-Yu Tsai <wenst@chromium.org>,
linux-amarula@amarulasolutions.com, anthony@amarulasolutions.com,
jagan@amarulasolutions.com,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Abel Vesa <abelvesa@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: [RFC PATCH v2 08/11] clk: imx: gate2: add device tree support
Date: Sun, 1 Jan 2023 18:57:37 +0100 [thread overview]
Message-ID: <20230101175740.1010258-9-dario.binacchi@amarulasolutions.com> (raw)
In-Reply-To: <20230101175740.1010258-1-dario.binacchi@amarulasolutions.com>
The patch, backwards compatible, extends the driver to initialize the
clock directly from the device tree.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
(no changes since v1)
drivers/clk/imx/clk-gate2.c | 86 +++++++++++++++++++++++++++++++++++++
1 file changed, 86 insertions(+)
diff --git a/drivers/clk/imx/clk-gate2.c b/drivers/clk/imx/clk-gate2.c
index f16c4019f402..b28150bf1ff6 100644
--- a/drivers/clk/imx/clk-gate2.c
+++ b/drivers/clk/imx/clk-gate2.c
@@ -12,9 +12,26 @@
#include <linux/slab.h>
#include <linux/io.h>
#include <linux/err.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
#include <linux/string.h>
#include "clk.h"
+#define CLK_GATE2_CGR_DISABLED 0
+#define CLK_GATE2_CGR_RUN 1
+#define CLK_GATE2_CGR_RUN_WAIT 2
+#define CLK_GATE2_CGR_RUN_WAIT_STOP 3
+#define CLK_GATE2_CGR_MASK 3
+
+#define CLK_GATE2_MAX_GROUPS 16
+
+struct clk_gate2_group {
+ const char *name;
+ unsigned int share_count;
+};
+
+static struct clk_gate2_group clk_gate2_groups[CLK_GATE2_MAX_GROUPS];
+
/**
* DOC: basic gateable clock which can gate and ungate its output
*
@@ -175,3 +192,72 @@ struct clk_hw *clk_hw_register_gate2(struct device *dev, const char *name,
return hw;
}
EXPORT_SYMBOL_GPL(clk_hw_register_gate2);
+
+/**
+ * of_imx_gate2_clk_setup() - Setup function for imx low power gate
+ * clock
+ * @node: device node for the clock
+ */
+static void __init of_imx_gate2_clk_setup(struct device_node *node)
+{
+ void __iomem *reg;
+ u8 i, bit_idx = 0;
+ u8 cgr_val = CLK_GATE2_CGR_RUN_WAIT_STOP;
+ u8 cgr_mask = CLK_GATE2_CGR_MASK;
+ unsigned long flags = CLK_OPS_PARENT_ENABLE | CLK_SET_RATE_PARENT;
+ u8 gate2_flags = 0;
+ unsigned int *share_count = NULL;
+ const char *name = node->name, *parent_name;
+ const char *str;
+ struct clk_hw *hw;
+ u32 val;
+
+ reg = of_iomap(node, 0);
+ if (IS_ERR(reg)) {
+ pr_err("failed to get reg address for %pOFn\n", node);
+ return;
+ }
+
+ if (!of_property_read_u32(node, "fsl,bit-shift", &val))
+ bit_idx = val;
+
+ if (of_clk_get_parent_count(node) != 1) {
+ pr_err("%pOFn must have 1 parent clock\n", node);
+ return;
+ }
+
+ if (!of_property_read_string(node, "sharing-group", &str)) {
+ for (i = 0; clk_gate2_groups[i].name &&
+ i < ARRAY_SIZE(clk_gate2_groups); i++) {
+ if (!strcmp(clk_gate2_groups[i].name, str)) {
+ share_count = &clk_gate2_groups[i].share_count;
+ break;
+ }
+ }
+
+ if (i == ARRAY_SIZE(clk_gate2_groups)) {
+ pr_err("failed to get shared count for %pOFn\n", node);
+ return;
+ }
+
+ if (!share_count) {
+ clk_gate2_groups[i].name =
+ kstrdup_const(str, GFP_KERNEL);
+ share_count = &clk_gate2_groups[i].share_count;
+ }
+ }
+
+ parent_name = of_clk_get_parent_name(node, 0);
+ of_property_read_string(node, "clock-output-names", &name);
+
+ hw = clk_hw_register_gate2(NULL, name, parent_name, flags, reg, bit_idx,
+ cgr_val, cgr_mask, gate2_flags,
+ &imx_ccm_lock, share_count);
+ if (!IS_ERR(hw))
+ of_clk_add_hw_provider(node, of_clk_hw_simple_get, hw);
+
+ pr_debug("name: %s, parent: %s, enable-bit: %d, flags: 0x%lx, gate2_flags: 0x%x\n",
+ name, parent_name, bit_idx, flags, gate2_flags);
+}
+CLK_OF_DECLARE(fsl_imx8mn_gate2_clk, "fsl,imx8mn-low-power-gate-clock",
+ of_imx_gate2_clk_setup);
--
2.32.0
next prev parent reply other threads:[~2023-01-01 17:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 17:57 [RFC PATCH v2 00/11] clk: imx8mn: setup clocks from the device tree Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 01/11] clk: imx: add structure to extend register accesses Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 02/11] clk: imx: add clk_hw based API imx_get_clk_hw_from_dt() Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 03/11] clk: imx8mn: add gate driver Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 04/11] clk: imx8mn: add mux driver Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 05/11] clk: imx8mn: add divider driver Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 06/11] clk: imx: pll14xx: add device tree support Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 07/11] clk: imx: composite-8m: " Dario Binacchi
2023-01-01 17:57 ` Dario Binacchi [this message]
2023-01-01 17:57 ` [RFC PATCH v2 09/11] clk: imx: cpu: " Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 10/11] arm64: dts: imx8mn: add dumy clock Dario Binacchi
2023-01-01 17:57 ` [RFC PATCH v2 11/11] arm64: dts: imx8mn: add clocks description Dario Binacchi
2023-01-16 14:35 ` Abel Vesa
2023-01-20 17:47 ` Dario Binacchi
2023-01-02 23:04 ` [RFC PATCH v2 00/11] clk: imx8mn: setup clocks from the device tree Marek Vasut
2023-01-04 16:09 ` Dario Binacchi
2023-01-25 21:10 ` Stephen Boyd
2023-01-26 10:49 ` Michael Nazzareno Trimarchi
2023-02-10 22:49 ` Stephen Boyd
2023-02-11 9:19 ` Michael Nazzareno Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230101175740.1010258-9-dario.binacchi@amarulasolutions.com \
--to=dario.binacchi@amarulasolutions.com \
--cc=abelvesa@kernel.org \
--cc=angelo@amarulasolutions.com \
--cc=anthony@amarulasolutions.com \
--cc=festevam@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=kernel@pengutronix.de \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tommaso.merciai@amarulasolutions.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).