* [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable
@ 2023-01-05 8:25 Anshuman Khandual
2023-01-05 9:43 ` Mike Rapoport
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Anshuman Khandual @ 2023-01-05 8:25 UTC (permalink / raw)
To: linux-mm; +Cc: rppt, mgorman, Anshuman Khandual, linux-kernel
Instead of directly accessing static deferred_pages, replace such instances
with the helper deferred_pages_enabled(). No functional change is intended.
Cc; Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
This applies on v6.2-rc2.
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0745aedebb37..232d0323047b 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4244,7 +4244,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
* Watermark failed for this zone, but see if we can
* grow this zone if it contains deferred pages.
*/
- if (static_branch_unlikely(&deferred_pages)) {
+ if (deferred_pages_enabled()) {
if (_deferred_grow_zone(zone, order))
goto try_this_zone;
}
@@ -4293,7 +4293,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
} else {
#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
/* Try again if zone has deferred pages */
- if (static_branch_unlikely(&deferred_pages)) {
+ if (deferred_pages_enabled()) {
if (_deferred_grow_zone(zone, order))
goto try_this_zone;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable
2023-01-05 8:25 [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable Anshuman Khandual
@ 2023-01-05 9:43 ` Mike Rapoport
2023-01-05 13:00 ` David Hildenbrand
2023-01-09 13:32 ` Mel Gorman
2 siblings, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2023-01-05 9:43 UTC (permalink / raw)
To: Anshuman Khandual; +Cc: linux-mm, mgorman, linux-kernel
On Thu, Jan 05, 2023 at 01:55:06PM +0530, Anshuman Khandual wrote:
> Instead of directly accessing static deferred_pages, replace such instances
> with the helper deferred_pages_enabled(). No functional change is intended.
>
> Cc; Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> This applies on v6.2-rc2.
>
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0745aedebb37..232d0323047b 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4244,7 +4244,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> * Watermark failed for this zone, but see if we can
> * grow this zone if it contains deferred pages.
> */
> - if (static_branch_unlikely(&deferred_pages)) {
> + if (deferred_pages_enabled()) {
> if (_deferred_grow_zone(zone, order))
> goto try_this_zone;
> }
> @@ -4293,7 +4293,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> } else {
> #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
> /* Try again if zone has deferred pages */
> - if (static_branch_unlikely(&deferred_pages)) {
> + if (deferred_pages_enabled()) {
> if (_deferred_grow_zone(zone, order))
> goto try_this_zone;
> }
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable
2023-01-05 8:25 [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable Anshuman Khandual
2023-01-05 9:43 ` Mike Rapoport
@ 2023-01-05 13:00 ` David Hildenbrand
2023-01-09 13:32 ` Mel Gorman
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2023-01-05 13:00 UTC (permalink / raw)
To: Anshuman Khandual, linux-mm; +Cc: rppt, mgorman, linux-kernel
s/Repalce/Replace/
n 05.01.23 09:25, Anshuman Khandual wrote:
> Instead of directly accessing static deferred_pages, replace such instances
> with the helper deferred_pages_enabled(). No functional change is intended.
>
> Cc; Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable
2023-01-05 8:25 [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable Anshuman Khandual
2023-01-05 9:43 ` Mike Rapoport
2023-01-05 13:00 ` David Hildenbrand
@ 2023-01-09 13:32 ` Mel Gorman
2 siblings, 0 replies; 4+ messages in thread
From: Mel Gorman @ 2023-01-09 13:32 UTC (permalink / raw)
To: Anshuman Khandual; +Cc: linux-mm, rppt, linux-kernel
On Thu, Jan 05, 2023 at 01:55:06PM +0530, Anshuman Khandual wrote:
> Instead of directly accessing static deferred_pages, replace such instances
> with the helper deferred_pages_enabled(). No functional change is intended.
>
> Cc; Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-09 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 8:25 [PATCH] mm/page_alloc: Repalce with deferred_pages_enabled() wherever applicable Anshuman Khandual
2023-01-05 9:43 ` Mike Rapoport
2023-01-05 13:00 ` David Hildenbrand
2023-01-09 13:32 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).